All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: dccp@vger.kernel.org
Subject: Re: [PATCH v4 net 0/4] dccp/tcp: Fix bhash2 issues related to WARN_ON() in inet_csk_get_port().
Date: Wed, 23 Nov 2022 04:53:32 +0000	[thread overview]
Message-ID: <166917961972.4515.12267352129449341755.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221119014914.31792-1-kuniyu@amazon.com>

Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 18 Nov 2022 17:49:10 -0800 you wrote:
> syzkaller was hitting a WARN_ON() in inet_csk_get_port() in the 4th patch,
> which was because we forgot to fix up bhash2 bucket when connect() for a
> socket bound to a wildcard address fails in __inet_stream_connect().
> 
> There was a similar report [0], but its repro does not fire the WARN_ON() due
> to inconsistent error handling.
> 
> [...]

Here is the summary with links:
  - [v4,net,1/4] dccp/tcp: Reset saddr on failure after inet6?_hash_connect().
    https://git.kernel.org/netdev/net/c/77934dc6db0d
  - [v4,net,2/4] dccp/tcp: Remove NULL check for prev_saddr in inet_bhash2_update_saddr().
    https://git.kernel.org/netdev/net/c/8acdad37cd13
  - [v4,net,3/4] dccp/tcp: Update saddr under bhash's lock.
    https://git.kernel.org/netdev/net/c/8c5dae4c1a49
  - [v4,net,4/4] dccp/tcp: Fixup bhash2 bucket when connect() fails.
    https://git.kernel.org/netdev/net/c/e0833d1fedb0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html


WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
	acme@mandriva.com, joannelkoong@gmail.com, martin.lau@kernel.org,
	mathew.j.martineau@linux.intel.com,
	william.xuanziyang@huawei.com, stephen@networkplumber.org,
	pengfei.xu@intel.com, kuni1840@gmail.com, netdev@vger.kernel.org,
	dccp@vger.kernel.org
Subject: Re: [PATCH v4 net 0/4] dccp/tcp: Fix bhash2 issues related to WARN_ON() in inet_csk_get_port().
Date: Wed, 23 Nov 2022 05:00:19 +0000	[thread overview]
Message-ID: <166917961972.4515.12267352129449341755.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221119014914.31792-1-kuniyu@amazon.com>

Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 18 Nov 2022 17:49:10 -0800 you wrote:
> syzkaller was hitting a WARN_ON() in inet_csk_get_port() in the 4th patch,
> which was because we forgot to fix up bhash2 bucket when connect() for a
> socket bound to a wildcard address fails in __inet_stream_connect().
> 
> There was a similar report [0], but its repro does not fire the WARN_ON() due
> to inconsistent error handling.
> 
> [...]

Here is the summary with links:
  - [v4,net,1/4] dccp/tcp: Reset saddr on failure after inet6?_hash_connect().
    https://git.kernel.org/netdev/net/c/77934dc6db0d
  - [v4,net,2/4] dccp/tcp: Remove NULL check for prev_saddr in inet_bhash2_update_saddr().
    https://git.kernel.org/netdev/net/c/8acdad37cd13
  - [v4,net,3/4] dccp/tcp: Update saddr under bhash's lock.
    https://git.kernel.org/netdev/net/c/8c5dae4c1a49
  - [v4,net,4/4] dccp/tcp: Fixup bhash2 bucket when connect() fails.
    https://git.kernel.org/netdev/net/c/e0833d1fedb0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



  parent reply	other threads:[~2022-11-23  4:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19  1:49 [PATCH v4 net 0/4] dccp/tcp: Fix bhash2 issues related to WARN_ON() in inet_csk_get_port() Kuniyuki Iwashima
2022-11-19  1:49 ` Kuniyuki Iwashima
2022-11-22 17:54 ` Eric Dumazet
2022-11-22 17:54   ` Eric Dumazet
2022-11-23  4:53 ` patchwork-bot+netdevbpf [this message]
2022-11-23  5:00   ` patchwork-bot+netdevbpf
  -- strict thread matches above, loose matches on Subject: below --
2022-11-19  1:49 [PATCH v4 net 1/4] dccp/tcp: Reset saddr on failure after inet6?_hash_connect() Kuniyuki Iwashima
2022-11-19  1:49 ` Kuniyuki Iwashima
2022-11-19  1:49 [PATCH v4 net 2/4] dccp/tcp: Remove NULL check for prev_saddr in inet_bhash2_update_saddr() Kuniyuki Iwashima
2022-11-19  1:49 ` Kuniyuki Iwashima
2022-11-19  1:49 [PATCH v4 net 3/4] dccp/tcp: Update saddr under bhash's lock Kuniyuki Iwashima
2022-11-19  1:49 ` Kuniyuki Iwashima
2022-11-22  0:11 ` Joanne Koong
2022-11-22  0:11   ` Joanne Koong
2022-11-19  1:49 [PATCH v4 net 4/4] dccp/tcp: Fixup bhash2 bucket when connect() fails Kuniyuki Iwashima
2022-11-19  1:49 ` Kuniyuki Iwashima
2022-11-21 23:41 ` Joanne Koong
2022-11-21 23:41   ` Joanne Koong
2022-11-22  0:50 ` Kuniyuki Iwashima
2022-11-22  0:50   ` Kuniyuki Iwashima
2022-11-22 17:54 ` Joanne Koong
2022-11-22 17:54   ` Joanne Koong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166917961972.4515.12267352129449341755.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.