From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60F981F12F8 for ; Wed, 12 Mar 2025 23:17:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741821422; cv=none; b=G/4TsH8zmKujvgWa5GtalUNTan4IXwmfYwxAmA3M8uBy7QDOKdMfdZujtjffbC1iSbuNIO2Lie7STYxek2oGKhP0uDqIAQ9KLFou8/ZnaBGrOw1TSb2LdUBEUs6h+uDGdTaa0jU4X8RZb2NEyiXJkHqOjHv65XV24bo7E3hTcL8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741821422; c=relaxed/simple; bh=wqg9zUtWmVpF6JzOb+JkHva2UgAbpiTGxmzAbHTOhuk=; h=Message-ID:Content-Type:MIME-Version:In-Reply-To:References: Subject:From:Cc:To:Date; b=l7SZnkbl50IiIIlbX9CiB9lPPOs3iNA1CO5vNwrxgkAPJpCuVdwZXoQlNZeLgnIhYDEkMTXFfQuU24eKY2bTkM6xG+eU3wz5N+MIlgHpJ7sO5FRvrBE1+cAh8xTQNcaAHKWhty06OK180Ig+NF94VIehtUEBbVasBE+TAK6Gelo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qLB8YGlD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qLB8YGlD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFDBFC4CEDD; Wed, 12 Mar 2025 23:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741821421; bh=wqg9zUtWmVpF6JzOb+JkHva2UgAbpiTGxmzAbHTOhuk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=qLB8YGlDoAxC9HiQ57QktFZPg3r7oWUMovsr6+YkytP5AyMV05LkV0+3FQ70vLC+6 fyViw6+XuaIZgXeNBoePnB8YddiUVeEOK5eoTynIre7kP9rlPE7QEQn/HtvauAU7yo AX1mCioV8c6R4s6ZeKOKdsFqHaN3kvaQeVrAqwyG6qdbzePQ9aaKoLANzyA8AQIh6F FEZ/pj0AxRb/Zrs06996kmp7BlcS+bDHRdAjuQMHfX7im4Ep7C/uBbQnON+A46IU0j 1yZPBFWDdiHzAkIWkmLC0M2Kqt7Eb0o7mOg9Ab6qMqTfNGWjD12/wO5giT65WhWcsy KLN3TGslQp3VA== Message-ID: <166bb0476a377d8159ce669007e49689.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <2216284.irdbgypaU6@phil> References: <8574162.T7Z3S40VBb@phil> <33a5e73e9c3919dd0554f9dcbee8b733.sboyd@kernel.org> <2216284.irdbgypaU6@phil> Subject: Re: [GIT PULL] Rockchip clock changes for 6.15 #1 From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org To: Heiko Stuebner , kever.yang@rock-chips.com, mturquette@baylibre.com Date: Wed, 12 Mar 2025 16:16:59 -0700 User-Agent: alot/0.12.dev8+g17a99a841c4b Quoting Heiko Stuebner (2025-03-11 23:03:00) > Am Dienstag, 11. M=C3=A4rz 2025, 19:05:50 MEZ schrieb Stephen Boyd: > >=20 > > Did you see this warning? > >=20 > > drivers/clk/rockchip/rst-rk3562.c:21:57: error: initialized field overw= ritten [-Werror=3Doverride-init] > > 21 | #define RK3562_DDRCRU_RESET_OFFSET(id, reg, bit) [id] =3D (0x20= 000*4 + reg * 16 + bit) > > | ^ > > drivers/clk/rockchip/rst-rk3562.c:266:9: note: in expansion of macro 'R= K3562_DDRCRU_RESET_OFFSET' > > 266 | RK3562_DDRCRU_RESET_OFFSET(SRST_P_DDR_PHY, 0, 8), > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > drivers/clk/rockchip/rst-rk3562.c:21:57: note: (near initialization for= 'rk3562_register_offset[173]') > > 21 | #define RK3562_DDRCRU_RESET_OFFSET(id, reg, bit) [id] =3D (0x20= 000*4 + reg * 16 + bit) > > | ^ > > drivers/clk/rockchip/rst-rk3562.c:266:9: note: in expansion of macro 'R= K3562_DDRCRU_RESET_OFFSET' > > 266 | RK3562_DDRCRU_RESET_OFFSET(SRST_P_DDR_PHY, 0, 8), > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > cc1: all warnings being treated as errors >=20 >=20 > interestingly, this did not turn up in my build test. > But that splat is really helpful too, because it made it easy to see > that one of the ids is doubled in the dt-binding header. >=20 > include/dt-bindings/reset/rockchip,rk3562-cru.h: >=20 > #define SRST_P_DDR_HWLP 173 > #define SRST_P_DDR_PHY 173 >=20 >=20 > I'll fix up the double id. Thanks. >=20 >=20 > Out of curiosity, what toolchain was that? >=20 $ ~/compilers/gcc-12.2.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc --versi= on aarch64-linux-gcc (GCC) 12.2.0 Copyright (C) 2022 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DEA8C28B28 for ; Wed, 12 Mar 2025 23:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WrvBzOIRbI9Cc318doelXM4Oi9sMWMJHCf/nmbVotqA=; b=S+hKt12zMaV0Se F6W5soH0SdG5lfPlFpLvNMeVKsgYCQCJr02YGV8CuCB0OmoNw3INj3K14JJqluIGRQ/WvkyF8Ig/i WPl8huHAxTnQJF6gMbDqfYARWP+MNPDSLEU6ZvT+yGw7OwY2+iAXaK+5hKxyGL6sXLZmK2v9TuE+G SMbhYjJTpVHG3NMjz5wwV6FYvLvagJY5mwsdHF0G1omztE0722Rs5UvZXpDvvYK8mLtJXMyw1jgFA R6kPATKRs93dmYLGCgDVSVu6VzHmmM3qYO73O43IPe09u6RVoQXuMmDM+iXUuqpCmA1FHuKIH9+1E rVDVFgM1me5c9KPGlbZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsVJy-00000009hed-0HHM; Wed, 12 Mar 2025 23:17:06 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tsVJv-00000009hdn-1L3U for linux-rockchip@lists.infradead.org; Wed, 12 Mar 2025 23:17:04 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 492F8A43B15; Wed, 12 Mar 2025 23:11:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFDBFC4CEDD; Wed, 12 Mar 2025 23:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741821421; bh=wqg9zUtWmVpF6JzOb+JkHva2UgAbpiTGxmzAbHTOhuk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=qLB8YGlDoAxC9HiQ57QktFZPg3r7oWUMovsr6+YkytP5AyMV05LkV0+3FQ70vLC+6 fyViw6+XuaIZgXeNBoePnB8YddiUVeEOK5eoTynIre7kP9rlPE7QEQn/HtvauAU7yo AX1mCioV8c6R4s6ZeKOKdsFqHaN3kvaQeVrAqwyG6qdbzePQ9aaKoLANzyA8AQIh6F FEZ/pj0AxRb/Zrs06996kmp7BlcS+bDHRdAjuQMHfX7im4Ep7C/uBbQnON+A46IU0j 1yZPBFWDdiHzAkIWkmLC0M2Kqt7Eb0o7mOg9Ab6qMqTfNGWjD12/wO5giT65WhWcsy KLN3TGslQp3VA== Message-ID: <166bb0476a377d8159ce669007e49689.sboyd@kernel.org> MIME-Version: 1.0 In-Reply-To: <2216284.irdbgypaU6@phil> References: <8574162.T7Z3S40VBb@phil> <33a5e73e9c3919dd0554f9dcbee8b733.sboyd@kernel.org> <2216284.irdbgypaU6@phil> Subject: Re: [GIT PULL] Rockchip clock changes for 6.15 #1 From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org To: Heiko Stuebner , kever.yang@rock-chips.com, mturquette@baylibre.com Date: Wed, 12 Mar 2025 16:16:59 -0700 User-Agent: alot/0.12.dev8+g17a99a841c4b X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250312_161703_422588_E46BCD68 X-CRM114-Status: GOOD ( 13.03 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org UXVvdGluZyBIZWlrbyBTdHVlYm5lciAoMjAyNS0wMy0xMSAyMzowMzowMCkKPiBBbSBEaWVuc3Rh ZywgMTEuIE3DpHJ6IDIwMjUsIDE5OjA1OjUwIE1FWiBzY2hyaWViIFN0ZXBoZW4gQm95ZDoKPiA+ IAo+ID4gRGlkIHlvdSBzZWUgdGhpcyB3YXJuaW5nPwo+ID4gCj4gPiBkcml2ZXJzL2Nsay9yb2Nr Y2hpcC9yc3QtcmszNTYyLmM6MjE6NTc6IGVycm9yOiBpbml0aWFsaXplZCBmaWVsZCBvdmVyd3Jp dHRlbiBbLVdlcnJvcj1vdmVycmlkZS1pbml0XQo+ID4gICAgMjEgfCAjZGVmaW5lIFJLMzU2Ml9E RFJDUlVfUkVTRVRfT0ZGU0VUKGlkLCByZWcsIGJpdCkgW2lkXSA9ICgweDIwMDAwKjQgKyByZWcg KiAxNiArIGJpdCkKPiA+ICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBeCj4gPiBkcml2ZXJzL2Nsay9yb2NrY2hpcC9yc3Qtcmsz NTYyLmM6MjY2Ojk6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyAnUkszNTYyX0REUkNSVV9S RVNFVF9PRkZTRVQnCj4gPiAgIDI2NiB8ICAgICAgICAgUkszNTYyX0REUkNSVV9SRVNFVF9PRkZT RVQoU1JTVF9QX0REUl9QSFksIDAsIDgpLAo+ID4gICAgICAgfCAgICAgICAgIF5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+Cj4gPiBkcml2ZXJzL2Nsay9yb2NrY2hpcC9yc3QtcmszNTYyLmM6MjE6 NTc6IG5vdGU6IChuZWFyIGluaXRpYWxpemF0aW9uIGZvciAncmszNTYyX3JlZ2lzdGVyX29mZnNl dFsxNzNdJykKPiA+ICAgIDIxIHwgI2RlZmluZSBSSzM1NjJfRERSQ1JVX1JFU0VUX09GRlNFVChp ZCwgcmVnLCBiaXQpIFtpZF0gPSAoMHgyMDAwMCo0ICsgcmVnICogMTYgKyBiaXQpCj4gPiAgICAg ICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgXgo+ID4gZHJpdmVycy9jbGsvcm9ja2NoaXAvcnN0LXJrMzU2Mi5jOjI2Njo5OiBub3RlOiBp biBleHBhbnNpb24gb2YgbWFjcm8gJ1JLMzU2Ml9ERFJDUlVfUkVTRVRfT0ZGU0VUJwo+ID4gICAy NjYgfCAgICAgICAgIFJLMzU2Ml9ERFJDUlVfUkVTRVRfT0ZGU0VUKFNSU1RfUF9ERFJfUEhZLCAw LCA4KSwKPiA+ICAgICAgIHwgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fgo+ID4g Y2MxOiBhbGwgd2FybmluZ3MgYmVpbmcgdHJlYXRlZCBhcyBlcnJvcnMKPiAKPiAKPiBpbnRlcmVz dGluZ2x5LCB0aGlzIGRpZCBub3QgdHVybiB1cCBpbiBteSBidWlsZCB0ZXN0Lgo+IEJ1dCB0aGF0 IHNwbGF0IGlzIHJlYWxseSBoZWxwZnVsIHRvbywgYmVjYXVzZSBpdCBtYWRlIGl0IGVhc3kgdG8g c2VlCj4gdGhhdCBvbmUgb2YgdGhlIGlkcyBpcyBkb3VibGVkIGluIHRoZSBkdC1iaW5kaW5nIGhl YWRlci4KPiAKPiBpbmNsdWRlL2R0LWJpbmRpbmdzL3Jlc2V0L3JvY2tjaGlwLHJrMzU2Mi1jcnUu aDoKPiAKPiAjZGVmaW5lIFNSU1RfUF9ERFJfSFdMUCAgICAgICAgIDE3Mwo+ICNkZWZpbmUgU1JT VF9QX0REUl9QSFkgICAgICAgICAgICAgICAgICAxNzMKPiAKPiAKPiBJJ2xsIGZpeCB1cCB0aGUg ZG91YmxlIGlkLgoKVGhhbmtzLgoKPiAKPiAKPiBPdXQgb2YgY3VyaW9zaXR5LCB3aGF0IHRvb2xj aGFpbiB3YXMgdGhhdD8KPiAKCiQgfi9jb21waWxlcnMvZ2NjLTEyLjIuMC1ub2xpYmMvYWFyY2g2 NC1saW51eC9iaW4vYWFyY2g2NC1saW51eC1nY2MgLS12ZXJzaW9uCmFhcmNoNjQtbGludXgtZ2Nj IChHQ0MpIDEyLjIuMApDb3B5cmlnaHQgKEMpIDIwMjIgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9u LCBJbmMuClRoaXMgaXMgZnJlZSBzb2Z0d2FyZTsgc2VlIHRoZSBzb3VyY2UgZm9yIGNvcHlpbmcg Y29uZGl0aW9ucy4gIFRoZXJlIGlzIE5PCndhcnJhbnR5OyBub3QgZXZlbiBmb3IgTUVSQ0hBTlRB QklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGlu ZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo=