From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1296FC25B75 for ; Wed, 29 May 2024 12:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2lOkkl9+wutF5aVU7dzk2B5HyVpIkCEp2zNO+rMUlLo=; b=xvB4eaka+TdjhfNEZ3LjVgUjPb xDh7x4R+WXEi2jU+Zj39etRpWqoARQq/wvDNCivVd9q9OaSHfq1gzym57CIIWIiiLW1FXyPGjkNFy vAycOclRpGGYOEbxB7XSDMpDRG9tl2gVWJVukCCB3DO9tPmciFEQAe1U0bvyEMH6eNSx+Yhyso8s7 5d/sIyh42CbU4jdVLEHgdynB4zOwtfkzqL9mV2q1LIJgqTcdXbX0jI0vUt5eiNNnfQ9dq5F8h5byT l1XgTNBTdBzIpFhCpJwxRlyliwpke0pakLUNAx5NA4LcQkvqEUHj16hSwOyzw9diVDR8kzYX2izVp 3ogW0g5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCIKS-000000045Oc-1GTU; Wed, 29 May 2024 12:22:52 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCIKN-000000045Lz-3SqJ; Wed, 29 May 2024 12:22:49 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1716985364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k16WSJ/s5kyBDGJQ4RDBCe5wIP6JXIMvufcMH5cikmk=; b=fMvgdpzO7yFxWjNKSZdXZ4GIYveKWDSgchzK589AIZOWaCyWfYueIzruN/4gpzmXzbr18/ LZeT86TRJxqY08jpugpu+zXDW6UBPA6oAIy3Ii8x7skT3UwPhGSfTPeX6qqRUpBKVGy1qR OqfzfY8N3/SzLTLVyOR+4OcNmcDDimTZdjsfRo8E/w04NXLz4L/XOn6TSt6qXx6mvyURvD S1M9a7Jx20cfnXZRsdkUWVrf7v80IzeOdRZbeFGX9XaAXLNIXkO/4wSlpZ6H75GV4BHT8d Ut70UzEl22e7UAEZVlXPKVzI5x7cSldBWps1zRqiSTMBkac1pu+Mq2Y/6tW+iA== Date: Wed, 29 May 2024 14:22:44 +0200 From: Dragan Simic To: Alexey Charkov Cc: linux-rockchip@lists.infradead.org, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, quentin.schulz@cherry.de, wens@kernel.org, daniel.lezcano@linaro.org, didi.debian@cknow.org, krzysztof.kozlowski+dt@linaro.org, viresh.kumar@linaro.org Subject: Re: [RFC PATCH] arm64: dts: rockchip: Make preparations for per-RK3588-variant OPPs In-Reply-To: References: <673dcf47596e7bc8ba065034e339bb1bbf9cdcb0.1716948159.git.dsimic@manjaro.org> <8f8623e29a479c4108141302e708dc3b@manjaro.org> Message-ID: <166cc4e46f31644a50306625b2ab18a6@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_052248_338085_001265DE X-CRM114-Status: GOOD ( 47.79 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wNS0yOSAxNDowNCwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4gT24gV2VkLCBNYXkg MjksIDIwMjQgYXQgMjo0NeKAr1BNIERyYWdhbiBTaW1pYyA8ZHNpbWljQG1hbmphcm8ub3JnPiAK PiB3cm90ZToKPj4gT24gMjAyNC0wNS0yOSAxMTo1NywgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4+ ID4gT24gV2VkLCBNYXkgMjksIDIwMjQgYXQgNjoxNOKAr0FNIERyYWdhbiBTaW1pYyA8ZHNpbWlj QG1hbmphcm8ub3JnPgo+PiA+IHdyb3RlOgo+PiA+Pgo+PiA+PiBSZW5hbWUgYW5kIG1vZGlmeSB0 aGUgUkszNTg4IGR0c2kgZmlsZXMgYSBiaXQsIHRvIG1ha2UgcHJlcGFyYXRpb25zCj4+ID4+IGZv cgo+PiA+PiB0aGUgYWJpbGl0eSB0byBzcGVjaWZ5IGRpZmZlcmVudCBDUFUgYW5kIEdQVSBPUFBz IGZvciBlYWNoIG9mIHRoZQo+PiA+PiBzdXBwb3J0ZWQKPj4gPj4gUkszNTg4IFNvQyB2YXJpYW50 cywgaW5jbHVkaW5nIHRoZSBSSzM1ODhKLgo+PiA+Pgo+PiA+PiBBcyBhbHJlYWR5IGRpc2N1c3Nl ZCwgWzFdWzJdWzNdIHNvbWUgb2YgdGhlIGRpZmZlcmVudCBSSzM1ODggU29DCj4+ID4+IHZhcmlh bnRzCj4+ID4+IHJlcXVpcmUgZGlmZmVyZW50IE9QUHMsIGFuZCBpdCBtYWtlcyBtb3JlIHNlbnNl IHRvIGhhdmUgdGhlIE9QUHMKPj4gPj4gYWxyZWFkeQo+PiA+PiBkZWZpbmVkIHdoZW4gYSBib2Fy ZCBkdHMgaW5jbHVkZXMgb25lIG9mIHRoZSBTb0MgZHRzaSBmaWxlcwo+PiA+PiAocmszNTg4LmR0 c2ksCj4+ID4+IHJrMzU4OGouZHRzaSBvciByazM1ODhzLmR0c2kpLCByYXRoZXIgdGhhbiByZXF1 aXJpbmcgdGhlIGJvYXJkIGR0cwo+PiA+PiBmaWxlIHRvCj4+ID4+IGFsc28gaW5jbHVkZSBhIHNl cGFyYXRlIHJrMzU4OCotb3BwLmR0c2kgZmlsZS4gIFRoZSBjaG9pY2Ugb2YgdGhlIFNvQwo+PiA+ PiB2YXJpYW50Cj4+ID4+IGlzIGFscmVhZHkgbWFkZSBieSB0aGUgaW5jbHVzaW9uIG9mIHRoZSBT b0MgZHRzaSBmaWxlLCBhbmQgaXQgZG9lc24ndAo+PiA+PiBtYWtlCj4+ID4+IG11Y2ggc2Vuc2Ug dG8sIGVmZmVjdGl2ZWx5LCBhbGxvdyB0aGUgYm9hcmQgZHRzIGZpbGUgdG8gaW5jbHVkZSBhbmQK Pj4gPj4gdXNlIGFuCj4+ID4+IGluY29tcGF0aWJsZSBzZXQgb2YgT1BQcyBmb3IgdGhlIGFscmVh ZHkgc2VsZWN0ZWQgU29DIHZhcmlhbnQuCj4+ID4KPj4gPiBJbmRlZWQsIGluY2x1ZGluZyBqdXN0 IG9uZSAuZHRzaSBmb3IgdGhlIGNvcnJlY3QgU29DIHZhcmlhbnQgYW5kIG5vdAo+PiA+IGhhdmlu ZyB0byBib3RoZXIgYWJvdXQgd2hhdCBvdGhlciBiaXRzIGFuZCBwaWVjZXMgYXJlIHJlcXVpcmVk IHRvIHVzZQo+PiA+IHRoZSBmdWxsIFNvQyBmdW5jdGlvbmFsaXR5IHNvdW5kcyBncmVhdCEgVGhh bmtzIGZvciBwdXR0aW5nIHRoaXMKPj4gPiB0b2dldGhlciBzbyBwcm9tcHRseSEKPj4gCj4+IFlv dSdyZSB3ZWxjb21lLiA6KQo+PiAKPj4gPiBTb21lIGNvbnNpZGVyYXRpb25zIGJlbG93Lgo+PiA+ Cj4+ID4+IE5vIGludGVuZGVkIGZ1bmN0aW9uYWwgY2hhbmdlcyBhcmUgaW50cm9kdWNlZC4gIChT dGlsbCB0byBiZQo+PiA+PiBhZGRpdGlvbmFsbHkKPj4gPj4gdmVyaWZpZWQgaWYgdGhlIHBhdGNo IG1vdmVzIGZvcndhcmQgZnJvbSB0aGUgUkZDIHN0YXRlLikKPj4gPj4KPj4gPj4gWzFdCj4+ID4+ IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LXJvY2tjaGlwLzY0NmEzM2UwLTVjMWItNDcx Yy04MTgzLTJjMGRmNDBlYTUxYUBjaGVycnkuZGUvCj4+ID4+IFsyXQo+PiA+PiBodHRwczovL2xv cmUua2VybmVsLm9yZy9saW51eC1yb2NrY2hpcC9DQUJqZDRZeGk9KzNna05uSDNCeXNVenpZc2pp LT0teVJPdHpFYzhqTV9nMHJvS0IwLXdAbWFpbC5nbWFpbC5jb20vCj4+ID4+IFszXQo+PiA+PiBo dHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1yb2NrY2hpcC8wMzVhMjc0YmUyNjI1MjgwMTIx NzNkNDYzZTI1YjU1ZkBtYW5qYXJvLm9yZy8KPj4gPj4KPj4gPj4gU2lnbmVkLW9mZi1ieTogRHJh Z2FuIFNpbWljIDxkc2ltaWNAbWFuamFyby5vcmc+Cj4+ID4+IC0tLQo+PiA+PiAgLi4uaW5jdHJs LmR0c2kgPT4gcmszNTg4LWNvbW1vbi1waW5jdHJsLmR0c2l9IHwgICAgMAo+PiA+Cj4+ID4gUmVu YW1pbmcgdGhlIHBpbmN0cmwgaW5jbHVkZXMgc2VlbXMgc3VwZXJmbHVvdXMgLSBtYXliZSBrZWVw IHRoZW0gYXMKPj4gPiB0aGV5IHdlcmUgdG8gbWluaW1pemUgY2h1cm4/Cj4+IAo+PiBCZWxpZXZl IGl0IG9yIG5vdCwgdGhlIHNhbWUgdGhvdWdodHMgY3Jvc3NlZCBteSBtaW5kLiAgSG93ZXZlciwK Pj4gYWZ0ZXIgdGhpbmtpbmcgYSBiaXQgYWJvdXQgaXQsIEkgY29uY2x1ZGVkIHRoYXQgcmVuYW1p bmcgdGhlIHBpbmN0cmwKPj4gLmR0c2kgZmlsZXMgYXMgd2VsbCBtYWtlcyB0aGUgb3ZlcmFsbCBu YW1pbmcgb2YgdGhlIHJld29ya2VkIFJLMzU4OAo+PiAuZHRzaSBmaWxlcyBtb3JlIGNvbnNpc3Rl bnQuCj4+IAo+PiBJdCdzIGFsc28gcmF0aGVyIG5lYXQgdG8gaGF2ZSB0aGUgImNvbW1vbiIgYW5k ICJmdWxsZmF0IiBmaWxlIHBhaXJzCj4+IHRvZ2V0aGVyIGluIHRoZSBhcmNoL2FybTY0L2Jvb3Qv ZHRzL3JvY2tjaGlwIGRpcmVjdG9yeSBsaXN0aW5nLCB3aGVuCj4+IGl0J3Mgc29ydGVkIGJ5IHRo ZSBmaWxlIG5hbWUsIHdoaWNoIGlzIHRoZSBkZWZhdWx0IGluIG1vc3QgKGlmIG5vdAo+PiBhbGwp IGVudmlyb25tZW50cy4KPj4gCj4+ID4+ICAuLi4ve3JrMzU4OHMuZHRzaSA9PiByazM1ODgtY29t bW9uLmR0c2l9ICAgICAgfCAgICAyICstCj4+ID4+ICAuLi5uY3RybC5kdHNpID0+IHJrMzU4OC1m dWxsZmF0LXBpbmN0cmwuZHRzaX0gfCAgICAwCj4+ID4+ICAuLi4ve3JrMzU4OC5kdHNpID0+IHJr MzU4OC1mdWxsZmF0LmR0c2l9ICAgICAgfCAgICA0ICstCj4+ID4KPj4gPiBUbyBtZSwgImZ1bGxm YXQiIGRvZXNuJ3QgbG9vayBzdXBlciBkZXNjcmlwdGl2ZSwgYWxiZWl0IGZ1biA6KQo+PiAKPj4g WWVhaCwgSSByZXNvcnRlZCB0byAiZnVsbGZhdCIgYXMgc29tZSBraW5kIG9mIGEgZnVubnkgb3B0 aW9uLiA6KQo+PiBUaGF0J3MgZm9yIHRoZSAiYmVlZnkiIFNvQyB2YXJpYW50cywgc28gaXQga2lu ZCBvZiBmaXRzIHdlbGwuIDopCj4+IAo+PiA+IEhvdyBhYm91dCB3ZSByZW5hbWUgdGhlIGV4aXN0 aW5nIHJrMzU4OC5kdHNpIGFuZCByazM1ODhzLmR0c2kgdG8KPj4gPiBzb21ldGhpbmcgbGlrZSBy azM1ODgtZGV2aWNlcy5kdHNpIGFuZCByazM1ODhzLWRldmljZXMuZHRzaQo+PiA+IChwcmVzZXJ2 aW5nIHRoZSBpbmhlcml0YW5jZSBiZXR3ZWVuIHRoZW0pLCBhbmQgdGhlbiBJIGFkZAo+PiA+IHJr MzU4OHMtb3BwLmR0c2kgYW5kIHJrMzU4OGotb3BwLmR0c2kgaW4gYSBmb2xsb3ctdXAgcGF0Y2g/ Cj4+IAo+PiBUaGUgdHJvdWJsZSB3aXRoIGluY2x1ZGluZyAiZGV2aWNlcyIgaW50byB0aGUgZmls ZW5hbWVzIGlzLCB3ZWxsLAo+PiB0aGUgZmFjdCB0aGF0IHRob3NlIGZpbGVzIGlzbid0IGFib3V0 IGFueSBkZXZpY2VzLCBidXQgYWJvdXQgdGhlCj4+IFNvQyB2YXJpYW50cy4gIFRodXMsICJkZXZp Y2VzIiBzaW1wbHkgd291bGRuJ3QgZml0IHRoZXJlLgo+IAo+IE15IHRoaW5raW5nIHdhcyBhbG9u ZyB0aGUgbGluZXMgb2YgImhlcmUgaXMgdGhlIGZpbGUgdGhhdCBjb250YWlucyBhbGwKPiBEVCBu b2RlcyBmb3IgYnVpbHQtaW4gX2RldmljZXNfIChhcyBpbiBvbi1jaGlwIElQIGJsb2Nrcykgb24g UkszNTg4IC0KPiB0aHVzIGl0J3MgY2FsbGVkIHJrMzU4OC1kZXZpY2VzLmR0c2kiLCBhbmQgImhl cmUncyB0aGUgZmlsZSB0aGF0Cj4gY29udGFpbnMgb3BlcmF0aW5nIHBhcmFtZXRlcnMgdGhhdCBk aXN0aW5ndWlzaCBSSzM1ODggYW5kIFJLMzU4OHMgZnJvbQo+IFJLMzU4OGogLSBpdCdzIGNhbGxl ZCByazM1ODhzLW9wcC5kdHNpIgoKSG1tLi4uICBJIHNlZSwgYnV0IGEgZGV2aWNlIGlzIHVzdWFs bHkgdGhvdWdoIG9mIGFzIHNvbWUgc3RhbmRhbG9uZQpjb21wdXRlciwgYXQgbGVhc3QgaW4gdGhp cyBjb250ZXh0LiAgU3VyZWx5LCBhbiBTb0MgaXMgYWxzbyBzb21lIGtpbmQKb2YgYSBkZXZpY2Us IGZvciBleGFtcGxlLCBidXQgSSdtIHByZXR0eSBzdXJlIHdlJ2xsIHZlcnkgcmFyZWx5IGNhbGwK YW4gU29DIGEgZGV2aWNlLiAgSXQncyBhbHdheXMgZ29vZCB0byBhZGhlcmUgdG8gdGhlIHVzdWFs IG1lYW5pbmcgb2YKdGhlIHdvcmRzIGluIGEgcGFydGljdWxhciBsaW5nby4KCldoZW4gaXQgY29t ZXMgdG8gcmszNTg4cy1vcHAuZHRzaSwgaXQgd291bGQgYmUgbW9yZSBvZiBhIGZpbGUgdGhhdApj b21wbGV0ZXMgdGhlIHJrMzU4OHMuZHRzaSBieSBhZGRpbmcgdGhlIE9QUHMsIGJ1dCB3ZSBjYW4g aW4gZmFjdAphZGQgdGhlIE9QUHMgZGlyZWN0bHkgaW50byByazM1ODhzLmR0c2ksIGJlY2F1c2Ug aW4gdGhlIG5ldyBsYXlvdXQKcmszNTg4cy5kdHNpIGlzbid0IGEgcGFyZW50IHRvIGFueSBvdGhl ciBmaWxlLgoKPj4gTW9yZW92ZXIsIGluIHRoZSBlbnZpc2lvbmVkIHNjaGVtZSB0aGVyZSBzaG91 bGQgYmUgbm8gc2VwYXJhdGUKPj4gT1BQIC5kdHNpIGZpbGVzOyAgdGhlIE9QUCBkYXRhIHNob3Vs ZCBnbyBkaXJlY3RseSBpbnRvIHRoZSBuZXcKPj4gcmszNTg4LmR0c2ksIHJrMzU4OHMuZHRzaSBh bmQgcmszNTg4ai5kdHNpIGZpbGVzLCB3aGVyZSBpdCBhY3R1YWxseQo+PiBiZWxvbmdzLiAgVGhh dCdzIHdoeSB0aG9zZSAuZHRzaSBmaWxlcyBleGlzdCBhbmQgYXJlIG1vc3RseSBlbXB0eSwKPj4g YXQgbGVhc3QgdGhlIHdheSBJIHNlZSBpdC4gIEknbGwgZ2V0IGJhY2sgdG8gdGhpcyBiZWxvdy4K Pj4gCj4+ID4gVGhlbiB3ZSBrZWVwICJ0aGluIiB2ZXJzaW9ucyBvZiByazM1ODguZHRzaSwgcmsz NTg4cy5kdHNpIGFuZAo+PiA+IHJrMzU4OGouZHRzaSBmb3IgYm9hcmQgZmlsZXMgdG8gaW5jbHVk ZS4gVGhlIG1peC1hbmQtbWF0Y2ggb2YKPj4gPiBkaWZmZXJlbnQgb24tY2hpcCBkZXZpY2VzIGFu ZCBkaWZmZXJlbnQgT1BQcyB0aGVuIGdldHMgdHJhbnNwYXJlbnRseQo+PiA+IHJlcHJlc2VudGVk IHdpdGhpbiB0aG9zZSAidGhpbiIgLmR0c2ksIHNvbWV0aGluZyBsaWtlIHRoaXM6Cj4+ID4KPj4g PiByazM1ODguZHRzaToKPj4gPiAjaW5jbHVkZSAicmszNTg4LWRldmljZXMuZHRzaSIKPj4gPiAj aW5jbHVkZSAicmszNTg4cy1vcHAuZHRzaSIKPj4gPgo+PiA+IHJrMzU4OHMuZHRzaToKPj4gPiAj aW5jbHVkZSAicmszNTg4cy1kZXZpY2VzLmR0c2kiCj4+ID4gI2luY2x1ZGUgInJrMzU4OHMtb3Bw LmR0c2kiCj4+ID4KPj4gPiByazM1ODhqLmR0c2k6Cj4+ID4gI2luY2x1ZGUgInJrMzU4OC1kZXZp Y2VzLmR0c2kiCj4+ID4gI2luY2x1ZGUgInJrMzU4OGotb3BwLmR0c2kiCj4+IAo+PiBTdWNoIGEg bGF5b3V0LCBpbiBnZW5lcmFsLCBoYXMgYWxzbyBjcm9zc2VkIG15IG1pbmQsIGJ1dCBteSBjb25j bHVzaW9uCj4+IHdhcyB0aGF0IGhhdmluZyB0aGUgcGVyLVNvQy12YXJpYW50IE9QUCBkYXRhIHNw ZWNpZmllZCBkaXJlY3RseSBpbiB0aGUKPj4gcmV3b3JrZWQgcmszNTg4LmR0c2ksIHJrMzU4OHMu ZHRzaSBhbmQgcmszNTg4ai5kdHNpIGZpbGVzIGlzIGEgYmV0dGVyCj4+IG9wdGlvbiBpbiB0aGUg bG9uZyB0ZXJtLCBldmVuIGlmIHdlIGVuZCB1cCB0aGF0IHdheSB3aXRoIHJrMzU4OC5kdHNpIAo+ PiBhbmQKPj4gcmszNTg4cy5kdHNpIHJlcGVhdGluZyBtb3N0IChpZiBub3QgYWxsKSBvZiB0aGUg c2FtZSBPUFAgZGF0YS4KPiAKPiBGcm9tIGFsbCB0aGUgaW5mbyB3ZSBoYXZlIGF2YWlsYWJsZSBz byBmYXIsIFJLMzU4OCBhbmQgUkszNTg4cyBzaGFyZQo+IGlkZW50aWNhbCBPUFBzLCBzbyBoYXZp bmcgb25lIGZpbGUgd2l0aCBPUFBzIHRoYXQgYm90aCB2YXJpYW50cyByZWZlcgo+IHRvIHNob3Vs ZCBiZSBtb3JlIG1haW50YWluYWJsZSAoYW5kIGZld2VyIGxpbmVzIG9mIERUIGNvZGUpLgoKSG1t LiAgUGVyaGFwcyB3ZSBjYW4gaGF2ZSByazM1ODgtb3BwLmR0c2kgYXMgYSBzZXBhcmF0ZSBmaWxl IHdpdGggdGhlCk9QUHMgc2hhcmVkIGJldHdlZW4gdGhlIFJLMzU4OCBhbmQgdGhlIFJLMzU4OFMs IHdoaWNoIHdvdWxkIGJlIGluY2x1ZGVkCmZyb20gcmszNTg4LmR0c2kgYW5kIHJrMzU4OHMuZHRz aS4KClRob3VnaCwgdGhlIE9QUHMgZm9yIHRoZSBSSzM1ODhKIHNob3VsZCBnbyBkaXJlY3RseSBp bnRvIHJrMzU4OGouZHRzaTsKaWYgd2UgZXZlciBzcGxpdCB0aGUgT1BQcyBmb3IgdGhlIFJLMzU4 OCBhbmQgdGhlIFJLMzU4OFMsIHRoZSBuZXcgT1BQcwpzaG91bGQgYWxzbyBnbyBkaXJlY3RseSBp bnRvIHJrMzU4OC5kdHNpIGFuZCByazM1ODhzLmR0c2kuCgo+IEFsbCBpbiBhbGwsIGl0IGFwcGVh cnMgdGhhdCBSSzM1ODggYW5kIFJLMzU4OGogaGF2ZSBhbiBpZGVudGljYWwgc2V0Cj4gb2YgYnVp bHQtaW4gZGV2aWNlcywgYnV0IGRpZmZlcmVudCBPUFBzIGR1ZSB0byBSSzM1ODhqIGJlaW5nIHNw ZWMnZAo+IGZvciBpbmR1c3RyaWFsIHVzZSB3aGljaCBhcHBhcmVudGx5IGhhcyBkaWZmZXJlbnQg cmVxdWlyZW1lbnRzLiBBdCB0aGUKPiBzYW1lIHRpbWUsIFJLMzU4OHMgdXNlcyBhbiBpZGVudGlj YWwgc2V0IG9mIE9QUHMgYXMgUkszNTg4IGJ1dCBhCj4gcmVkdWNlZCBzZXQgb2YgYnVpbHQtaW4g ZGV2aWNlcy4gVGhlIGNvbWJpbmF0aW9uIG9mIGluY2x1ZGVzIEkKPiBwcm9wb3NlZCBhYm92ZSBt YWtlcyB0aGlzIGV4cGxpY2l0LgoKQWdhaW4sIGNhbGxpbmcgSVAgYmxvY2tzIGRldmljZXMgaXMs IEFGQUlLLCB2ZXJ5IHVuY29tbW9uLgoKPiBBcyBmb3IgUkszNTg4bSwgaXQgc2VlbXMgdG8gaW5j bHVkZSBhbGwgdGhlIHNhbWUgZGV2aWNlcyBhcyBSSzM1ODggYW5kCj4gUkszNTg4aiwgYnV0IGEg c2xpZ2h0bHkgbW9kaWZpZWQgc2V0IG9mIE9QUHMgY29tcGFyZWQgdG8gUkszNTg4ai4gV2UKPiBk b24ndCBoYXZlIGFueSBib2FyZHMgdXNpbmcgdGhhdCB2YXJpYW50IGluIHRoZSBtYWlubGluZSB0 cmVlIHJpZ2h0Cj4gbm93LCBidXQgaXQgd291bGQgYmUgZWFzeSwgd2hlbiB0aGUgbmVlZCBhcmlz ZXMsIHRvIGFkZCBzb21ldGhpbmcKPiBhbG9uZyB0aGUgbGluZXMgb2Y6Cj4gCj4gcmszNTg4bS5k dHNpOgo+ICNpbmNsdWRlICJyazM1ODgtZGV2aWNlcy5kdHNpIgo+ICNpbmNsdWRlICJyazM1ODht LW9wcC5kdHNpIgo+IAo+IHJrMzU4OG0tb3BwLmR0c2k6Cj4gI2luY2x1ZGUgInJrMzU4OGotb3Bw LmR0c2kiCj4gJmNsdXN0ZXIwX29wcF90YWJsZSB7Cj4gICAgICAgICAvZGVsZXRlLW5vZGUvIG9w cC0xMjk2MDAwMDAwOwo+IH07CgpJIGRvbid0IHRoaW5rIHRoYXQgZGVsZXRpbmcgbm9kZXMgdGhh dCB3YXkgaXMgYSBnb29kIG9wdGlvbi4gIEl0J3MKcmF0aGVyIGVycm9yLXByb25lIGFuZCBoYXJk IHRvIHRyYWNrLCBzbyBpdCB3b3VsZCBiZSBiZXR0ZXIgdG8gaGF2ZQp0aGUgT1BQcyBmb3IgUksz NTg4TSBzcGVjaWZpZWQgZGlyZWN0bHkgKGFuZCBmdWxseSkgaW4gdGhlIGZ1dHVyZQpyazM1ODht LmR0c2kgZmlsZSwganVzdCBsaWtlIGluIHJrMzU4OGouZHRzaS4KCj4+IFRoYXQgd2F5IHdlJ2xs IGhhdmUgbm8gcm9hZGJsb2NrcyBpZiwgYXQgc29tZSBwb2ludCwgd2UgZW5kIHVwIHdpdGgKPj4g aGF2aW5nCj4+IGRpZmZlcmVudCBPUFBzIGRlZmluZWQgZm9yIHRoZSBSSzM1ODggYW5kIHRoZSBS SzM1ODhTIHZhcmlhbnRzLiAgT3IKPj4gbWF5YmUKPj4gZXZlbiBmb3IgdGhlIFJLMzU4Miwgd2hp Y2ggd2UgZG9uJ3Qga25vdyBtdWNoIGFib3V0IHlldC4KPiAKPiBHdWVzcyB3ZSdsbCBkZWFsIHdp dGggdGhhdCBvbmUgb25jZSB3ZSBzdHVtYmxlIHVwb24gYW4gYWN0dWFsIFJLMzU4Mgo+IGJvYXJk IG91dCBpbiB0aGUgd2lsZCBhbmQgaGVhZGluZyB0byB0aGUgbWFpbmxpbmUga2VybmVsIHRyZWUg OikKCk9mIGNvdXJzZSwgdGhhdCB3YXMganVzdCBhbiBleGFtcGxlIGZvciB0aGUgZnV0dXJlIHVz ZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4 LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2No aXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECBB4C27C43 for ; Wed, 29 May 2024 12:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GiLu+EfjNyURlHfAHldAPrFsX6UZP8/s0DCW1gOrViI=; b=slVwMr/hiTqQGq/e57pXKUXCHI sSfmBFT4D/m2+YUw2PkmsvB50VOArP60laTReCCMAPMCbkwHZbGp05YdXzKjz8f7Osa/AxI9uPa56 3IhP5I9HYdFsi0btOMOxT2XAoTtoX5RQufLxUd81EbGm1+juWFTw0UYA+/3KP4cxYPeRbG4vbY6tW oZkBpfaS0o7fJEhEpcNtn2UDmoOan0nYKvmO65rZL82amCZDraSfx8fueP3RCbRAgYi8jVB2w1w6/ azf+dBLf9tbTFjIidq862Chm1GCaDASMrUxGWL0Si7kJdxavpsi08gASS/3+lAzYHRomyFl4J4bKZ QStpxhUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCIKR-000000045O3-1CcQ; Wed, 29 May 2024 12:22:51 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCIKN-000000045Lz-3SqJ; Wed, 29 May 2024 12:22:49 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1716985364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k16WSJ/s5kyBDGJQ4RDBCe5wIP6JXIMvufcMH5cikmk=; b=fMvgdpzO7yFxWjNKSZdXZ4GIYveKWDSgchzK589AIZOWaCyWfYueIzruN/4gpzmXzbr18/ LZeT86TRJxqY08jpugpu+zXDW6UBPA6oAIy3Ii8x7skT3UwPhGSfTPeX6qqRUpBKVGy1qR OqfzfY8N3/SzLTLVyOR+4OcNmcDDimTZdjsfRo8E/w04NXLz4L/XOn6TSt6qXx6mvyURvD S1M9a7Jx20cfnXZRsdkUWVrf7v80IzeOdRZbeFGX9XaAXLNIXkO/4wSlpZ6H75GV4BHT8d Ut70UzEl22e7UAEZVlXPKVzI5x7cSldBWps1zRqiSTMBkac1pu+Mq2Y/6tW+iA== Date: Wed, 29 May 2024 14:22:44 +0200 From: Dragan Simic To: Alexey Charkov Cc: linux-rockchip@lists.infradead.org, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, quentin.schulz@cherry.de, wens@kernel.org, daniel.lezcano@linaro.org, didi.debian@cknow.org, krzysztof.kozlowski+dt@linaro.org, viresh.kumar@linaro.org Subject: Re: [RFC PATCH] arm64: dts: rockchip: Make preparations for per-RK3588-variant OPPs In-Reply-To: References: <673dcf47596e7bc8ba065034e339bb1bbf9cdcb0.1716948159.git.dsimic@manjaro.org> <8f8623e29a479c4108141302e708dc3b@manjaro.org> Message-ID: <166cc4e46f31644a50306625b2ab18a6@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_052248_338085_001265DE X-CRM114-Status: GOOD ( 47.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wNS0yOSAxNDowNCwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4gT24gV2VkLCBNYXkg MjksIDIwMjQgYXQgMjo0NeKAr1BNIERyYWdhbiBTaW1pYyA8ZHNpbWljQG1hbmphcm8ub3JnPiAK PiB3cm90ZToKPj4gT24gMjAyNC0wNS0yOSAxMTo1NywgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4+ ID4gT24gV2VkLCBNYXkgMjksIDIwMjQgYXQgNjoxNOKAr0FNIERyYWdhbiBTaW1pYyA8ZHNpbWlj QG1hbmphcm8ub3JnPgo+PiA+IHdyb3RlOgo+PiA+Pgo+PiA+PiBSZW5hbWUgYW5kIG1vZGlmeSB0 aGUgUkszNTg4IGR0c2kgZmlsZXMgYSBiaXQsIHRvIG1ha2UgcHJlcGFyYXRpb25zCj4+ID4+IGZv cgo+PiA+PiB0aGUgYWJpbGl0eSB0byBzcGVjaWZ5IGRpZmZlcmVudCBDUFUgYW5kIEdQVSBPUFBz IGZvciBlYWNoIG9mIHRoZQo+PiA+PiBzdXBwb3J0ZWQKPj4gPj4gUkszNTg4IFNvQyB2YXJpYW50 cywgaW5jbHVkaW5nIHRoZSBSSzM1ODhKLgo+PiA+Pgo+PiA+PiBBcyBhbHJlYWR5IGRpc2N1c3Nl ZCwgWzFdWzJdWzNdIHNvbWUgb2YgdGhlIGRpZmZlcmVudCBSSzM1ODggU29DCj4+ID4+IHZhcmlh bnRzCj4+ID4+IHJlcXVpcmUgZGlmZmVyZW50IE9QUHMsIGFuZCBpdCBtYWtlcyBtb3JlIHNlbnNl IHRvIGhhdmUgdGhlIE9QUHMKPj4gPj4gYWxyZWFkeQo+PiA+PiBkZWZpbmVkIHdoZW4gYSBib2Fy ZCBkdHMgaW5jbHVkZXMgb25lIG9mIHRoZSBTb0MgZHRzaSBmaWxlcwo+PiA+PiAocmszNTg4LmR0 c2ksCj4+ID4+IHJrMzU4OGouZHRzaSBvciByazM1ODhzLmR0c2kpLCByYXRoZXIgdGhhbiByZXF1 aXJpbmcgdGhlIGJvYXJkIGR0cwo+PiA+PiBmaWxlIHRvCj4+ID4+IGFsc28gaW5jbHVkZSBhIHNl cGFyYXRlIHJrMzU4OCotb3BwLmR0c2kgZmlsZS4gIFRoZSBjaG9pY2Ugb2YgdGhlIFNvQwo+PiA+ PiB2YXJpYW50Cj4+ID4+IGlzIGFscmVhZHkgbWFkZSBieSB0aGUgaW5jbHVzaW9uIG9mIHRoZSBT b0MgZHRzaSBmaWxlLCBhbmQgaXQgZG9lc24ndAo+PiA+PiBtYWtlCj4+ID4+IG11Y2ggc2Vuc2Ug dG8sIGVmZmVjdGl2ZWx5LCBhbGxvdyB0aGUgYm9hcmQgZHRzIGZpbGUgdG8gaW5jbHVkZSBhbmQK Pj4gPj4gdXNlIGFuCj4+ID4+IGluY29tcGF0aWJsZSBzZXQgb2YgT1BQcyBmb3IgdGhlIGFscmVh ZHkgc2VsZWN0ZWQgU29DIHZhcmlhbnQuCj4+ID4KPj4gPiBJbmRlZWQsIGluY2x1ZGluZyBqdXN0 IG9uZSAuZHRzaSBmb3IgdGhlIGNvcnJlY3QgU29DIHZhcmlhbnQgYW5kIG5vdAo+PiA+IGhhdmlu ZyB0byBib3RoZXIgYWJvdXQgd2hhdCBvdGhlciBiaXRzIGFuZCBwaWVjZXMgYXJlIHJlcXVpcmVk IHRvIHVzZQo+PiA+IHRoZSBmdWxsIFNvQyBmdW5jdGlvbmFsaXR5IHNvdW5kcyBncmVhdCEgVGhh bmtzIGZvciBwdXR0aW5nIHRoaXMKPj4gPiB0b2dldGhlciBzbyBwcm9tcHRseSEKPj4gCj4+IFlv dSdyZSB3ZWxjb21lLiA6KQo+PiAKPj4gPiBTb21lIGNvbnNpZGVyYXRpb25zIGJlbG93Lgo+PiA+ Cj4+ID4+IE5vIGludGVuZGVkIGZ1bmN0aW9uYWwgY2hhbmdlcyBhcmUgaW50cm9kdWNlZC4gIChT dGlsbCB0byBiZQo+PiA+PiBhZGRpdGlvbmFsbHkKPj4gPj4gdmVyaWZpZWQgaWYgdGhlIHBhdGNo IG1vdmVzIGZvcndhcmQgZnJvbSB0aGUgUkZDIHN0YXRlLikKPj4gPj4KPj4gPj4gWzFdCj4+ID4+ IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LXJvY2tjaGlwLzY0NmEzM2UwLTVjMWItNDcx Yy04MTgzLTJjMGRmNDBlYTUxYUBjaGVycnkuZGUvCj4+ID4+IFsyXQo+PiA+PiBodHRwczovL2xv cmUua2VybmVsLm9yZy9saW51eC1yb2NrY2hpcC9DQUJqZDRZeGk9KzNna05uSDNCeXNVenpZc2pp LT0teVJPdHpFYzhqTV9nMHJvS0IwLXdAbWFpbC5nbWFpbC5jb20vCj4+ID4+IFszXQo+PiA+PiBo dHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1yb2NrY2hpcC8wMzVhMjc0YmUyNjI1MjgwMTIx NzNkNDYzZTI1YjU1ZkBtYW5qYXJvLm9yZy8KPj4gPj4KPj4gPj4gU2lnbmVkLW9mZi1ieTogRHJh Z2FuIFNpbWljIDxkc2ltaWNAbWFuamFyby5vcmc+Cj4+ID4+IC0tLQo+PiA+PiAgLi4uaW5jdHJs LmR0c2kgPT4gcmszNTg4LWNvbW1vbi1waW5jdHJsLmR0c2l9IHwgICAgMAo+PiA+Cj4+ID4gUmVu YW1pbmcgdGhlIHBpbmN0cmwgaW5jbHVkZXMgc2VlbXMgc3VwZXJmbHVvdXMgLSBtYXliZSBrZWVw IHRoZW0gYXMKPj4gPiB0aGV5IHdlcmUgdG8gbWluaW1pemUgY2h1cm4/Cj4+IAo+PiBCZWxpZXZl IGl0IG9yIG5vdCwgdGhlIHNhbWUgdGhvdWdodHMgY3Jvc3NlZCBteSBtaW5kLiAgSG93ZXZlciwK Pj4gYWZ0ZXIgdGhpbmtpbmcgYSBiaXQgYWJvdXQgaXQsIEkgY29uY2x1ZGVkIHRoYXQgcmVuYW1p bmcgdGhlIHBpbmN0cmwKPj4gLmR0c2kgZmlsZXMgYXMgd2VsbCBtYWtlcyB0aGUgb3ZlcmFsbCBu YW1pbmcgb2YgdGhlIHJld29ya2VkIFJLMzU4OAo+PiAuZHRzaSBmaWxlcyBtb3JlIGNvbnNpc3Rl bnQuCj4+IAo+PiBJdCdzIGFsc28gcmF0aGVyIG5lYXQgdG8gaGF2ZSB0aGUgImNvbW1vbiIgYW5k ICJmdWxsZmF0IiBmaWxlIHBhaXJzCj4+IHRvZ2V0aGVyIGluIHRoZSBhcmNoL2FybTY0L2Jvb3Qv ZHRzL3JvY2tjaGlwIGRpcmVjdG9yeSBsaXN0aW5nLCB3aGVuCj4+IGl0J3Mgc29ydGVkIGJ5IHRo ZSBmaWxlIG5hbWUsIHdoaWNoIGlzIHRoZSBkZWZhdWx0IGluIG1vc3QgKGlmIG5vdAo+PiBhbGwp IGVudmlyb25tZW50cy4KPj4gCj4+ID4+ICAuLi4ve3JrMzU4OHMuZHRzaSA9PiByazM1ODgtY29t bW9uLmR0c2l9ICAgICAgfCAgICAyICstCj4+ID4+ICAuLi5uY3RybC5kdHNpID0+IHJrMzU4OC1m dWxsZmF0LXBpbmN0cmwuZHRzaX0gfCAgICAwCj4+ID4+ICAuLi4ve3JrMzU4OC5kdHNpID0+IHJr MzU4OC1mdWxsZmF0LmR0c2l9ICAgICAgfCAgICA0ICstCj4+ID4KPj4gPiBUbyBtZSwgImZ1bGxm YXQiIGRvZXNuJ3QgbG9vayBzdXBlciBkZXNjcmlwdGl2ZSwgYWxiZWl0IGZ1biA6KQo+PiAKPj4g WWVhaCwgSSByZXNvcnRlZCB0byAiZnVsbGZhdCIgYXMgc29tZSBraW5kIG9mIGEgZnVubnkgb3B0 aW9uLiA6KQo+PiBUaGF0J3MgZm9yIHRoZSAiYmVlZnkiIFNvQyB2YXJpYW50cywgc28gaXQga2lu ZCBvZiBmaXRzIHdlbGwuIDopCj4+IAo+PiA+IEhvdyBhYm91dCB3ZSByZW5hbWUgdGhlIGV4aXN0 aW5nIHJrMzU4OC5kdHNpIGFuZCByazM1ODhzLmR0c2kgdG8KPj4gPiBzb21ldGhpbmcgbGlrZSBy azM1ODgtZGV2aWNlcy5kdHNpIGFuZCByazM1ODhzLWRldmljZXMuZHRzaQo+PiA+IChwcmVzZXJ2 aW5nIHRoZSBpbmhlcml0YW5jZSBiZXR3ZWVuIHRoZW0pLCBhbmQgdGhlbiBJIGFkZAo+PiA+IHJr MzU4OHMtb3BwLmR0c2kgYW5kIHJrMzU4OGotb3BwLmR0c2kgaW4gYSBmb2xsb3ctdXAgcGF0Y2g/ Cj4+IAo+PiBUaGUgdHJvdWJsZSB3aXRoIGluY2x1ZGluZyAiZGV2aWNlcyIgaW50byB0aGUgZmls ZW5hbWVzIGlzLCB3ZWxsLAo+PiB0aGUgZmFjdCB0aGF0IHRob3NlIGZpbGVzIGlzbid0IGFib3V0 IGFueSBkZXZpY2VzLCBidXQgYWJvdXQgdGhlCj4+IFNvQyB2YXJpYW50cy4gIFRodXMsICJkZXZp Y2VzIiBzaW1wbHkgd291bGRuJ3QgZml0IHRoZXJlLgo+IAo+IE15IHRoaW5raW5nIHdhcyBhbG9u ZyB0aGUgbGluZXMgb2YgImhlcmUgaXMgdGhlIGZpbGUgdGhhdCBjb250YWlucyBhbGwKPiBEVCBu b2RlcyBmb3IgYnVpbHQtaW4gX2RldmljZXNfIChhcyBpbiBvbi1jaGlwIElQIGJsb2Nrcykgb24g UkszNTg4IC0KPiB0aHVzIGl0J3MgY2FsbGVkIHJrMzU4OC1kZXZpY2VzLmR0c2kiLCBhbmQgImhl cmUncyB0aGUgZmlsZSB0aGF0Cj4gY29udGFpbnMgb3BlcmF0aW5nIHBhcmFtZXRlcnMgdGhhdCBk aXN0aW5ndWlzaCBSSzM1ODggYW5kIFJLMzU4OHMgZnJvbQo+IFJLMzU4OGogLSBpdCdzIGNhbGxl ZCByazM1ODhzLW9wcC5kdHNpIgoKSG1tLi4uICBJIHNlZSwgYnV0IGEgZGV2aWNlIGlzIHVzdWFs bHkgdGhvdWdoIG9mIGFzIHNvbWUgc3RhbmRhbG9uZQpjb21wdXRlciwgYXQgbGVhc3QgaW4gdGhp cyBjb250ZXh0LiAgU3VyZWx5LCBhbiBTb0MgaXMgYWxzbyBzb21lIGtpbmQKb2YgYSBkZXZpY2Us IGZvciBleGFtcGxlLCBidXQgSSdtIHByZXR0eSBzdXJlIHdlJ2xsIHZlcnkgcmFyZWx5IGNhbGwK YW4gU29DIGEgZGV2aWNlLiAgSXQncyBhbHdheXMgZ29vZCB0byBhZGhlcmUgdG8gdGhlIHVzdWFs IG1lYW5pbmcgb2YKdGhlIHdvcmRzIGluIGEgcGFydGljdWxhciBsaW5nby4KCldoZW4gaXQgY29t ZXMgdG8gcmszNTg4cy1vcHAuZHRzaSwgaXQgd291bGQgYmUgbW9yZSBvZiBhIGZpbGUgdGhhdApj b21wbGV0ZXMgdGhlIHJrMzU4OHMuZHRzaSBieSBhZGRpbmcgdGhlIE9QUHMsIGJ1dCB3ZSBjYW4g aW4gZmFjdAphZGQgdGhlIE9QUHMgZGlyZWN0bHkgaW50byByazM1ODhzLmR0c2ksIGJlY2F1c2Ug aW4gdGhlIG5ldyBsYXlvdXQKcmszNTg4cy5kdHNpIGlzbid0IGEgcGFyZW50IHRvIGFueSBvdGhl ciBmaWxlLgoKPj4gTW9yZW92ZXIsIGluIHRoZSBlbnZpc2lvbmVkIHNjaGVtZSB0aGVyZSBzaG91 bGQgYmUgbm8gc2VwYXJhdGUKPj4gT1BQIC5kdHNpIGZpbGVzOyAgdGhlIE9QUCBkYXRhIHNob3Vs ZCBnbyBkaXJlY3RseSBpbnRvIHRoZSBuZXcKPj4gcmszNTg4LmR0c2ksIHJrMzU4OHMuZHRzaSBh bmQgcmszNTg4ai5kdHNpIGZpbGVzLCB3aGVyZSBpdCBhY3R1YWxseQo+PiBiZWxvbmdzLiAgVGhh dCdzIHdoeSB0aG9zZSAuZHRzaSBmaWxlcyBleGlzdCBhbmQgYXJlIG1vc3RseSBlbXB0eSwKPj4g YXQgbGVhc3QgdGhlIHdheSBJIHNlZSBpdC4gIEknbGwgZ2V0IGJhY2sgdG8gdGhpcyBiZWxvdy4K Pj4gCj4+ID4gVGhlbiB3ZSBrZWVwICJ0aGluIiB2ZXJzaW9ucyBvZiByazM1ODguZHRzaSwgcmsz NTg4cy5kdHNpIGFuZAo+PiA+IHJrMzU4OGouZHRzaSBmb3IgYm9hcmQgZmlsZXMgdG8gaW5jbHVk ZS4gVGhlIG1peC1hbmQtbWF0Y2ggb2YKPj4gPiBkaWZmZXJlbnQgb24tY2hpcCBkZXZpY2VzIGFu ZCBkaWZmZXJlbnQgT1BQcyB0aGVuIGdldHMgdHJhbnNwYXJlbnRseQo+PiA+IHJlcHJlc2VudGVk IHdpdGhpbiB0aG9zZSAidGhpbiIgLmR0c2ksIHNvbWV0aGluZyBsaWtlIHRoaXM6Cj4+ID4KPj4g PiByazM1ODguZHRzaToKPj4gPiAjaW5jbHVkZSAicmszNTg4LWRldmljZXMuZHRzaSIKPj4gPiAj aW5jbHVkZSAicmszNTg4cy1vcHAuZHRzaSIKPj4gPgo+PiA+IHJrMzU4OHMuZHRzaToKPj4gPiAj aW5jbHVkZSAicmszNTg4cy1kZXZpY2VzLmR0c2kiCj4+ID4gI2luY2x1ZGUgInJrMzU4OHMtb3Bw LmR0c2kiCj4+ID4KPj4gPiByazM1ODhqLmR0c2k6Cj4+ID4gI2luY2x1ZGUgInJrMzU4OC1kZXZp Y2VzLmR0c2kiCj4+ID4gI2luY2x1ZGUgInJrMzU4OGotb3BwLmR0c2kiCj4+IAo+PiBTdWNoIGEg bGF5b3V0LCBpbiBnZW5lcmFsLCBoYXMgYWxzbyBjcm9zc2VkIG15IG1pbmQsIGJ1dCBteSBjb25j bHVzaW9uCj4+IHdhcyB0aGF0IGhhdmluZyB0aGUgcGVyLVNvQy12YXJpYW50IE9QUCBkYXRhIHNw ZWNpZmllZCBkaXJlY3RseSBpbiB0aGUKPj4gcmV3b3JrZWQgcmszNTg4LmR0c2ksIHJrMzU4OHMu ZHRzaSBhbmQgcmszNTg4ai5kdHNpIGZpbGVzIGlzIGEgYmV0dGVyCj4+IG9wdGlvbiBpbiB0aGUg bG9uZyB0ZXJtLCBldmVuIGlmIHdlIGVuZCB1cCB0aGF0IHdheSB3aXRoIHJrMzU4OC5kdHNpIAo+ PiBhbmQKPj4gcmszNTg4cy5kdHNpIHJlcGVhdGluZyBtb3N0IChpZiBub3QgYWxsKSBvZiB0aGUg c2FtZSBPUFAgZGF0YS4KPiAKPiBGcm9tIGFsbCB0aGUgaW5mbyB3ZSBoYXZlIGF2YWlsYWJsZSBz byBmYXIsIFJLMzU4OCBhbmQgUkszNTg4cyBzaGFyZQo+IGlkZW50aWNhbCBPUFBzLCBzbyBoYXZp bmcgb25lIGZpbGUgd2l0aCBPUFBzIHRoYXQgYm90aCB2YXJpYW50cyByZWZlcgo+IHRvIHNob3Vs ZCBiZSBtb3JlIG1haW50YWluYWJsZSAoYW5kIGZld2VyIGxpbmVzIG9mIERUIGNvZGUpLgoKSG1t LiAgUGVyaGFwcyB3ZSBjYW4gaGF2ZSByazM1ODgtb3BwLmR0c2kgYXMgYSBzZXBhcmF0ZSBmaWxl IHdpdGggdGhlCk9QUHMgc2hhcmVkIGJldHdlZW4gdGhlIFJLMzU4OCBhbmQgdGhlIFJLMzU4OFMs IHdoaWNoIHdvdWxkIGJlIGluY2x1ZGVkCmZyb20gcmszNTg4LmR0c2kgYW5kIHJrMzU4OHMuZHRz aS4KClRob3VnaCwgdGhlIE9QUHMgZm9yIHRoZSBSSzM1ODhKIHNob3VsZCBnbyBkaXJlY3RseSBp bnRvIHJrMzU4OGouZHRzaTsKaWYgd2UgZXZlciBzcGxpdCB0aGUgT1BQcyBmb3IgdGhlIFJLMzU4 OCBhbmQgdGhlIFJLMzU4OFMsIHRoZSBuZXcgT1BQcwpzaG91bGQgYWxzbyBnbyBkaXJlY3RseSBp bnRvIHJrMzU4OC5kdHNpIGFuZCByazM1ODhzLmR0c2kuCgo+IEFsbCBpbiBhbGwsIGl0IGFwcGVh cnMgdGhhdCBSSzM1ODggYW5kIFJLMzU4OGogaGF2ZSBhbiBpZGVudGljYWwgc2V0Cj4gb2YgYnVp bHQtaW4gZGV2aWNlcywgYnV0IGRpZmZlcmVudCBPUFBzIGR1ZSB0byBSSzM1ODhqIGJlaW5nIHNw ZWMnZAo+IGZvciBpbmR1c3RyaWFsIHVzZSB3aGljaCBhcHBhcmVudGx5IGhhcyBkaWZmZXJlbnQg cmVxdWlyZW1lbnRzLiBBdCB0aGUKPiBzYW1lIHRpbWUsIFJLMzU4OHMgdXNlcyBhbiBpZGVudGlj YWwgc2V0IG9mIE9QUHMgYXMgUkszNTg4IGJ1dCBhCj4gcmVkdWNlZCBzZXQgb2YgYnVpbHQtaW4g ZGV2aWNlcy4gVGhlIGNvbWJpbmF0aW9uIG9mIGluY2x1ZGVzIEkKPiBwcm9wb3NlZCBhYm92ZSBt YWtlcyB0aGlzIGV4cGxpY2l0LgoKQWdhaW4sIGNhbGxpbmcgSVAgYmxvY2tzIGRldmljZXMgaXMs IEFGQUlLLCB2ZXJ5IHVuY29tbW9uLgoKPiBBcyBmb3IgUkszNTg4bSwgaXQgc2VlbXMgdG8gaW5j bHVkZSBhbGwgdGhlIHNhbWUgZGV2aWNlcyBhcyBSSzM1ODggYW5kCj4gUkszNTg4aiwgYnV0IGEg c2xpZ2h0bHkgbW9kaWZpZWQgc2V0IG9mIE9QUHMgY29tcGFyZWQgdG8gUkszNTg4ai4gV2UKPiBk b24ndCBoYXZlIGFueSBib2FyZHMgdXNpbmcgdGhhdCB2YXJpYW50IGluIHRoZSBtYWlubGluZSB0 cmVlIHJpZ2h0Cj4gbm93LCBidXQgaXQgd291bGQgYmUgZWFzeSwgd2hlbiB0aGUgbmVlZCBhcmlz ZXMsIHRvIGFkZCBzb21ldGhpbmcKPiBhbG9uZyB0aGUgbGluZXMgb2Y6Cj4gCj4gcmszNTg4bS5k dHNpOgo+ICNpbmNsdWRlICJyazM1ODgtZGV2aWNlcy5kdHNpIgo+ICNpbmNsdWRlICJyazM1ODht LW9wcC5kdHNpIgo+IAo+IHJrMzU4OG0tb3BwLmR0c2k6Cj4gI2luY2x1ZGUgInJrMzU4OGotb3Bw LmR0c2kiCj4gJmNsdXN0ZXIwX29wcF90YWJsZSB7Cj4gICAgICAgICAvZGVsZXRlLW5vZGUvIG9w cC0xMjk2MDAwMDAwOwo+IH07CgpJIGRvbid0IHRoaW5rIHRoYXQgZGVsZXRpbmcgbm9kZXMgdGhh dCB3YXkgaXMgYSBnb29kIG9wdGlvbi4gIEl0J3MKcmF0aGVyIGVycm9yLXByb25lIGFuZCBoYXJk IHRvIHRyYWNrLCBzbyBpdCB3b3VsZCBiZSBiZXR0ZXIgdG8gaGF2ZQp0aGUgT1BQcyBmb3IgUksz NTg4TSBzcGVjaWZpZWQgZGlyZWN0bHkgKGFuZCBmdWxseSkgaW4gdGhlIGZ1dHVyZQpyazM1ODht LmR0c2kgZmlsZSwganVzdCBsaWtlIGluIHJrMzU4OGouZHRzaS4KCj4+IFRoYXQgd2F5IHdlJ2xs IGhhdmUgbm8gcm9hZGJsb2NrcyBpZiwgYXQgc29tZSBwb2ludCwgd2UgZW5kIHVwIHdpdGgKPj4g aGF2aW5nCj4+IGRpZmZlcmVudCBPUFBzIGRlZmluZWQgZm9yIHRoZSBSSzM1ODggYW5kIHRoZSBS SzM1ODhTIHZhcmlhbnRzLiAgT3IKPj4gbWF5YmUKPj4gZXZlbiBmb3IgdGhlIFJLMzU4Miwgd2hp Y2ggd2UgZG9uJ3Qga25vdyBtdWNoIGFib3V0IHlldC4KPiAKPiBHdWVzcyB3ZSdsbCBkZWFsIHdp dGggdGhhdCBvbmUgb25jZSB3ZSBzdHVtYmxlIHVwb24gYW4gYWN0dWFsIFJLMzU4Mgo+IGJvYXJk IG91dCBpbiB0aGUgd2lsZCBhbmQgaGVhZGluZyB0byB0aGUgbWFpbmxpbmUga2VybmVsIHRyZWUg OikKCk9mIGNvdXJzZSwgdGhhdCB3YXMganVzdCBhbiBleGFtcGxlIGZvciB0aGUgZnV0dXJlIHVz ZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 932BB180A8C; Wed, 29 May 2024 12:22:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716985369; cv=none; b=EmvpyFnwwrvASRMxeCzbO5Pa0iNw7rC1KG+AYrS+zqP59S5ZHFfwvdOOjtCGsd9rlXkxEeWp7ObwtSzPZyF3KPqodDzV4kY0p0qNVqWo/XpD14GW135GaMKEs9AP2zdlRg/iquKSxRP6kXQQ5ovkFtWHXdY67Vg91mWue1jpl1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716985369; c=relaxed/simple; bh=/kdJYs2Cs9TxkYjFaxv6/itc+2e3TIXfCV+AENgyBSE=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=t8yK2jhfdqcxuF/BRQMGiR21h9oOuFKEewm6+GofkWA6uBmcIC4arQCNGnZ6EC8VWiu18sz24Dw8EDJGzd8jehAdrOyeInV9Q/LGEigR8c71cakcTkNNwNGtu6AVsc6CxSD1PpaSUCagYc4O6acV3vOki6W1HuyQVS6anH5QL1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=fMvgdpzO; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="fMvgdpzO" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1716985364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k16WSJ/s5kyBDGJQ4RDBCe5wIP6JXIMvufcMH5cikmk=; b=fMvgdpzO7yFxWjNKSZdXZ4GIYveKWDSgchzK589AIZOWaCyWfYueIzruN/4gpzmXzbr18/ LZeT86TRJxqY08jpugpu+zXDW6UBPA6oAIy3Ii8x7skT3UwPhGSfTPeX6qqRUpBKVGy1qR OqfzfY8N3/SzLTLVyOR+4OcNmcDDimTZdjsfRo8E/w04NXLz4L/XOn6TSt6qXx6mvyURvD S1M9a7Jx20cfnXZRsdkUWVrf7v80IzeOdRZbeFGX9XaAXLNIXkO/4wSlpZ6H75GV4BHT8d Ut70UzEl22e7UAEZVlXPKVzI5x7cSldBWps1zRqiSTMBkac1pu+Mq2Y/6tW+iA== Date: Wed, 29 May 2024 14:22:44 +0200 From: Dragan Simic To: Alexey Charkov Cc: linux-rockchip@lists.infradead.org, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, quentin.schulz@cherry.de, wens@kernel.org, daniel.lezcano@linaro.org, didi.debian@cknow.org, krzysztof.kozlowski+dt@linaro.org, viresh.kumar@linaro.org Subject: Re: [RFC PATCH] arm64: dts: rockchip: Make preparations for per-RK3588-variant OPPs In-Reply-To: References: <673dcf47596e7bc8ba065034e339bb1bbf9cdcb0.1716948159.git.dsimic@manjaro.org> <8f8623e29a479c4108141302e708dc3b@manjaro.org> Message-ID: <166cc4e46f31644a50306625b2ab18a6@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org On 2024-05-29 14:04, Alexey Charkov wrote: > On Wed, May 29, 2024 at 2:45 PM Dragan Simic > wrote: >> On 2024-05-29 11:57, Alexey Charkov wrote: >> > On Wed, May 29, 2024 at 6:14 AM Dragan Simic >> > wrote: >> >> >> >> Rename and modify the RK3588 dtsi files a bit, to make preparations >> >> for >> >> the ability to specify different CPU and GPU OPPs for each of the >> >> supported >> >> RK3588 SoC variants, including the RK3588J. >> >> >> >> As already discussed, [1][2][3] some of the different RK3588 SoC >> >> variants >> >> require different OPPs, and it makes more sense to have the OPPs >> >> already >> >> defined when a board dts includes one of the SoC dtsi files >> >> (rk3588.dtsi, >> >> rk3588j.dtsi or rk3588s.dtsi), rather than requiring the board dts >> >> file to >> >> also include a separate rk3588*-opp.dtsi file. The choice of the SoC >> >> variant >> >> is already made by the inclusion of the SoC dtsi file, and it doesn't >> >> make >> >> much sense to, effectively, allow the board dts file to include and >> >> use an >> >> incompatible set of OPPs for the already selected SoC variant. >> > >> > Indeed, including just one .dtsi for the correct SoC variant and not >> > having to bother about what other bits and pieces are required to use >> > the full SoC functionality sounds great! Thanks for putting this >> > together so promptly! >> >> You're welcome. :) >> >> > Some considerations below. >> > >> >> No intended functional changes are introduced. (Still to be >> >> additionally >> >> verified if the patch moves forward from the RFC state.) >> >> >> >> [1] >> >> https://lore.kernel.org/linux-rockchip/646a33e0-5c1b-471c-8183-2c0df40ea51a@cherry.de/ >> >> [2] >> >> https://lore.kernel.org/linux-rockchip/CABjd4Yxi=+3gkNnH3BysUzzYsji-=-yROtzEc8jM_g0roKB0-w@mail.gmail.com/ >> >> [3] >> >> https://lore.kernel.org/linux-rockchip/035a274be262528012173d463e25b55f@manjaro.org/ >> >> >> >> Signed-off-by: Dragan Simic >> >> --- >> >> ...inctrl.dtsi => rk3588-common-pinctrl.dtsi} | 0 >> > >> > Renaming the pinctrl includes seems superfluous - maybe keep them as >> > they were to minimize churn? >> >> Believe it or not, the same thoughts crossed my mind. However, >> after thinking a bit about it, I concluded that renaming the pinctrl >> .dtsi files as well makes the overall naming of the reworked RK3588 >> .dtsi files more consistent. >> >> It's also rather neat to have the "common" and "fullfat" file pairs >> together in the arch/arm64/boot/dts/rockchip directory listing, when >> it's sorted by the file name, which is the default in most (if not >> all) environments. >> >> >> .../{rk3588s.dtsi => rk3588-common.dtsi} | 2 +- >> >> ...nctrl.dtsi => rk3588-fullfat-pinctrl.dtsi} | 0 >> >> .../{rk3588.dtsi => rk3588-fullfat.dtsi} | 4 +- >> > >> > To me, "fullfat" doesn't look super descriptive, albeit fun :) >> >> Yeah, I resorted to "fullfat" as some kind of a funny option. :) >> That's for the "beefy" SoC variants, so it kind of fits well. :) >> >> > How about we rename the existing rk3588.dtsi and rk3588s.dtsi to >> > something like rk3588-devices.dtsi and rk3588s-devices.dtsi >> > (preserving the inheritance between them), and then I add >> > rk3588s-opp.dtsi and rk3588j-opp.dtsi in a follow-up patch? >> >> The trouble with including "devices" into the filenames is, well, >> the fact that those files isn't about any devices, but about the >> SoC variants. Thus, "devices" simply wouldn't fit there. > > My thinking was along the lines of "here is the file that contains all > DT nodes for built-in _devices_ (as in on-chip IP blocks) on RK3588 - > thus it's called rk3588-devices.dtsi", and "here's the file that > contains operating parameters that distinguish RK3588 and RK3588s from > RK3588j - it's called rk3588s-opp.dtsi" Hmm... I see, but a device is usually though of as some standalone computer, at least in this context. Surely, an SoC is also some kind of a device, for example, but I'm pretty sure we'll very rarely call an SoC a device. It's always good to adhere to the usual meaning of the words in a particular lingo. When it comes to rk3588s-opp.dtsi, it would be more of a file that completes the rk3588s.dtsi by adding the OPPs, but we can in fact add the OPPs directly into rk3588s.dtsi, because in the new layout rk3588s.dtsi isn't a parent to any other file. >> Moreover, in the envisioned scheme there should be no separate >> OPP .dtsi files; the OPP data should go directly into the new >> rk3588.dtsi, rk3588s.dtsi and rk3588j.dtsi files, where it actually >> belongs. That's why those .dtsi files exist and are mostly empty, >> at least the way I see it. I'll get back to this below. >> >> > Then we keep "thin" versions of rk3588.dtsi, rk3588s.dtsi and >> > rk3588j.dtsi for board files to include. The mix-and-match of >> > different on-chip devices and different OPPs then gets transparently >> > represented within those "thin" .dtsi, something like this: >> > >> > rk3588.dtsi: >> > #include "rk3588-devices.dtsi" >> > #include "rk3588s-opp.dtsi" >> > >> > rk3588s.dtsi: >> > #include "rk3588s-devices.dtsi" >> > #include "rk3588s-opp.dtsi" >> > >> > rk3588j.dtsi: >> > #include "rk3588-devices.dtsi" >> > #include "rk3588j-opp.dtsi" >> >> Such a layout, in general, has also crossed my mind, but my conclusion >> was that having the per-SoC-variant OPP data specified directly in the >> reworked rk3588.dtsi, rk3588s.dtsi and rk3588j.dtsi files is a better >> option in the long term, even if we end up that way with rk3588.dtsi >> and >> rk3588s.dtsi repeating most (if not all) of the same OPP data. > > From all the info we have available so far, RK3588 and RK3588s share > identical OPPs, so having one file with OPPs that both variants refer > to should be more maintainable (and fewer lines of DT code). Hmm. Perhaps we can have rk3588-opp.dtsi as a separate file with the OPPs shared between the RK3588 and the RK3588S, which would be included from rk3588.dtsi and rk3588s.dtsi. Though, the OPPs for the RK3588J should go directly into rk3588j.dtsi; if we ever split the OPPs for the RK3588 and the RK3588S, the new OPPs should also go directly into rk3588.dtsi and rk3588s.dtsi. > All in all, it appears that RK3588 and RK3588j have an identical set > of built-in devices, but different OPPs due to RK3588j being spec'd > for industrial use which apparently has different requirements. At the > same time, RK3588s uses an identical set of OPPs as RK3588 but a > reduced set of built-in devices. The combination of includes I > proposed above makes this explicit. Again, calling IP blocks devices is, AFAIK, very uncommon. > As for RK3588m, it seems to include all the same devices as RK3588 and > RK3588j, but a slightly modified set of OPPs compared to RK3588j. We > don't have any boards using that variant in the mainline tree right > now, but it would be easy, when the need arises, to add something > along the lines of: > > rk3588m.dtsi: > #include "rk3588-devices.dtsi" > #include "rk3588m-opp.dtsi" > > rk3588m-opp.dtsi: > #include "rk3588j-opp.dtsi" > &cluster0_opp_table { > /delete-node/ opp-1296000000; > }; I don't think that deleting nodes that way is a good option. It's rather error-prone and hard to track, so it would be better to have the OPPs for RK3588M specified directly (and fully) in the future rk3588m.dtsi file, just like in rk3588j.dtsi. >> That way we'll have no roadblocks if, at some point, we end up with >> having >> different OPPs defined for the RK3588 and the RK3588S variants. Or >> maybe >> even for the RK3582, which we don't know much about yet. > > Guess we'll deal with that one once we stumble upon an actual RK3582 > board out in the wild and heading to the mainline kernel tree :) Of course, that was just an example for the future use.