All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+bluetooth@kernel.org
To: Chen Zhongjin <chenzhongjin@huawei.com>
Cc: linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, marcel@holtmann.org,
	johan.hedberg@gmail.com, luiz.dentz@gmail.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com
Subject: Re: [PATCH] Bluetooth: Fix not cleanup led when bt_init fails
Date: Fri, 02 Dec 2022 21:25:40 +0000	[thread overview]
Message-ID: <167001634035.19139.3332943937893587311.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221129092556.116222-1-chenzhongjin@huawei.com>

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 29 Nov 2022 17:25:56 +0800 you wrote:
> bt_init() calls bt_leds_init() to register led, but if it fails later,
> bt_leds_cleanup() is not called to unregister it.
> 
> This can cause panic if the argument "bluetooth-power" in text is freed
> and then another led_trigger_register() tries to access it:
> 
> BUG: unable to handle page fault for address: ffffffffc06d3bc0
> RIP: 0010:strcmp+0xc/0x30
>   Call Trace:
>     <TASK>
>     led_trigger_register+0x10d/0x4f0
>     led_trigger_register_simple+0x7d/0x100
>     bt_init+0x39/0xf7 [bluetooth]
>     do_one_initcall+0xd0/0x4e0
> 
> [...]

Here is the summary with links:
  - Bluetooth: Fix not cleanup led when bt_init fails
    https://git.kernel.org/bluetooth/bluetooth-next/c/63d70ae785a9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2022-12-02 21:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29  9:25 [PATCH] Bluetooth: Fix not cleanup led when bt_init fails Chen Zhongjin
2022-11-29  9:55 ` bluez.test.bot
2022-12-02 21:25 ` patchwork-bot+bluetooth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167001634035.19139.3332943937893587311.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+bluetooth@kernel.org \
    --cc=chenzhongjin@huawei.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johan.hedberg@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.