From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: Future Direction for rte_eth_stats_get() Date: Fri, 22 Jan 2016 15:48:08 +0100 Message-ID: <1670837.tJHuUIkoht@xps13> References: <1A27633A6DA49C4A92FCD5D4312DBF536B09F7A4@IRSMSX106.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "David Harton (dharton)" Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 6E2948EA1 for ; Fri, 22 Jan 2016 15:49:09 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id n5so135845666wmn.0 for ; Fri, 22 Jan 2016 06:49:09 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" + Harry 2016-01-22 14:40, David Harton: > Hi Maryam, > > I'm not dictating they be re-added (although adding would be nice) but more important I'm trying to express an application view point rather than a driver view point. > > I completely understand how a driver wants to be able to advertise all the stats they want to advertise to help them debug their issues (i.e. xstats). Yet, I'm very interested in DPDK providing a driver agnostic method of advertising well-defined stats. xstats are driver agnostic and have a well-defined naming scheme. > For example, what if there was a kind of "stats registry" composed of ID and name. It would work similar to xtats except instead of advertising strings only the "get" API would return ID/count pairs. If the application wishes to use the DPDK provided string they can call another API to get the stat string via the ID. These IDs would be well-defined clearly explaining what the count represent. This way the strings for counts will be uniform across drivers and also make it clear to the users what the counts truly represent and the application could obtain stats from any driver in a driver agnostic manner. I don't understand how adding another indirection (an ID matching a string) would help? I have the feeling you want a list of possible statistics, right? PS: please avoid top posting