From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:55888 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755592AbeDZKqf (ORCPT ); Thu, 26 Apr 2018 06:46:35 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: rcar-du: of: Include header to define prototypes Date: Thu, 26 Apr 2018 13:46:50 +0300 Message-ID: <1671050.mdHx6Eelbf@avalon> In-Reply-To: <20180424153942.2526-1-kieran.bingham+renesas@ideasonboard.com> References: <20180424153942.2526-1-kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, Thank you for the patch. On Tuesday, 24 April 2018 18:39:42 EEST Kieran Bingham wrote: > The symbol 'rcar_du_of_init' is defined by the rcar_du_of module header, > but it is not included by the C implementation. > > Include the header to correctly define the function prototypes. > > Fixes the following warning: > > linux/drivers/gpu/drm/rcar-du/rcar_du_of.c:319:13: > warning: symbol 'rcar_du_of_init' was not declared. Should it be static? > CC drivers/gpu/drm/rcar-du/rcar_du_of.o > > Fixes: 81c0e3dd8292 ("drm: rcar-du: Fix legacy DT to create LVDS encoder > nodes") Signed-off-by: Kieran Bingham > Reviewed-by: Laurent Pinchart and applied to my tree. > --- > drivers/gpu/drm/rcar-du/rcar_du_of.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_of.c > b/drivers/gpu/drm/rcar-du/rcar_du_of.c index 68a0b82cb17e..afef69669bb4 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_of.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_of.c > @@ -18,6 +18,7 @@ > > #include "rcar_du_crtc.h" > #include "rcar_du_drv.h" > +#include "rcar_du_of.h" > > /* > --------------------------------------------------------------------------- > -- * Generic Overlay Handling -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: rcar-du: of: Include header to define prototypes Date: Thu, 26 Apr 2018 13:46:50 +0300 Message-ID: <1671050.mdHx6Eelbf@avalon> References: <20180424153942.2526-1-kieran.bingham+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id E66576E6DC for ; Thu, 26 Apr 2018 10:46:35 +0000 (UTC) In-Reply-To: <20180424153942.2526-1-kieran.bingham+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5LCAyNCBBcHJp bCAyMDE4IDE4OjM5OjQyIEVFU1QgS2llcmFuIEJpbmdoYW0gd3JvdGU6Cj4gVGhlIHN5bWJvbCAn cmNhcl9kdV9vZl9pbml0JyBpcyBkZWZpbmVkIGJ5IHRoZSByY2FyX2R1X29mIG1vZHVsZSBoZWFk ZXIsCj4gYnV0IGl0IGlzIG5vdCBpbmNsdWRlZCBieSB0aGUgQyBpbXBsZW1lbnRhdGlvbi4KPiAK PiBJbmNsdWRlIHRoZSBoZWFkZXIgdG8gY29ycmVjdGx5IGRlZmluZSB0aGUgZnVuY3Rpb24gcHJv dG90eXBlcy4KPiAKPiBGaXhlcyB0aGUgZm9sbG93aW5nIHdhcm5pbmc6Cj4gCj4gbGludXgvZHJp dmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9vZi5jOjMxOToxMzoKPiAgICB3YXJuaW5nOiBz eW1ib2wgJ3JjYXJfZHVfb2ZfaW5pdCcgd2FzIG5vdCBkZWNsYXJlZC4gU2hvdWxkIGl0IGJlIHN0 YXRpYz8KPiAgICAgQ0MgICAgICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29mLm8K PiAKPiBGaXhlczogODFjMGUzZGQ4MjkyICgiZHJtOiByY2FyLWR1OiBGaXggbGVnYWN5IERUIHRv IGNyZWF0ZSBMVkRTIGVuY29kZXIKPiBub2RlcyIpIFNpZ25lZC1vZmYtYnk6IEtpZXJhbiBCaW5n aGFtCj4gPGtpZXJhbi5iaW5naGFtK3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KClJldmlld2Vk LWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+ CgphbmQgYXBwbGllZCB0byBteSB0cmVlLgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JjYXIt ZHUvcmNhcl9kdV9vZi5jIHwgMSArCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29mLmMKPiBi L2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfb2YuYyBpbmRleCA2OGEwYjgyY2IxN2Uu LmFmZWY2OTY2OWJiNAo+IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3Jj YXJfZHVfb2YuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfb2YuYwo+ IEBAIC0xOCw2ICsxOCw3IEBACj4gCj4gICNpbmNsdWRlICJyY2FyX2R1X2NydGMuaCIKPiAgI2lu Y2x1ZGUgInJjYXJfZHVfZHJ2LmgiCj4gKyNpbmNsdWRlICJyY2FyX2R1X29mLmgiCj4gCj4gIC8q Cj4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gLS0gKiBHZW5lcmljIE92ZXJsYXkgSGFuZGxpbmcKCgot LSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==