From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] drm/rockchip: vop: fix window origin calculation Date: Tue, 10 Nov 2015 12:42:21 +0100 Message-ID: <1671071.tld3k90Oeo@phil> References: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Yao Cc: Russell King , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org QW0gRGllbnN0YWcsIDEwLiBOb3ZlbWJlciAyMDE1LCAxNzo1OToxMCBzY2hyaWViIE1hcmsgWWFv Ogo+IEZyb206IERvbWluaWsgQmVociA8ZGJlaHJAY2hyb21pdW0ub3JnPgo+IAo+IFZPUF9XSU54 X0RTUF9TVCBkb2VzIG5vdCByZXF1aXJlIHN1YnRyYWN0aW5nIDEgZnJvbSB0aGUgdmFsdWVzIHdy aXR0ZW4gdG8KPiBpdC4gSXQgYWN0dWFsbHkgY2F1c2VzIHRoZSBzY3JlZW4gdG8gYmUgc2hpZnRl ZCBieSBvbmUgcGl4ZWwuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFyayBZYW8gPG1hcmsueWFvQHJv Y2stY2hpcHMuY29tPgoKZnVubnkgSSBuZXZlciBub3RpY2VkIHRoYXQgc2hpZnQsIGJ1dCBub3cg dGhhdCB5b3UgbWVudGlvbiBpdCwgSSBzZWUgaXQgdG9vCm9uIG15IENocm9tZWJvb2sgYW5kIHRo ZSBwYXRjaCBmaXhlcyB0aGlzLiBJJ3ZlIGFsc28gbG9va2VkIHVwIHRoZQptYXRjaGluZyBkYXRh IGluIHRoZSBUUk0sIHNvCgpSZXZpZXdlZC1ieTogSGVpa28gU3R1ZWJuZXIgPGhlaWtvQHNudGVj aC5kZT4KVGVzdGVkLWJ5OiBIZWlrbyBTdHVlYm5lciA8aGVpa29Ac250ZWNoLmRlPgoKCkhlaWtv Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Tue, 10 Nov 2015 12:42:21 +0100 Subject: [PATCH] drm/rockchip: vop: fix window origin calculation In-Reply-To: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> References: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> Message-ID: <1671071.tld3k90Oeo@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao: > From: Dominik Behr > > VOP_WINx_DSP_ST does not require subtracting 1 from the values written to > it. It actually causes the screen to be shifted by one pixel. > > Signed-off-by: Mark Yao funny I never noticed that shift, but now that you mention it, I see it too on my Chromebook and the patch fixes this. I've also looked up the matching data in the TRM, so Reviewed-by: Heiko Stuebner Tested-by: Heiko Stuebner Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751601AbbKJLmv (ORCPT ); Tue, 10 Nov 2015 06:42:51 -0500 Received: from gloria.sntech.de ([95.129.55.99]:37859 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750906AbbKJLmu (ORCPT ); Tue, 10 Nov 2015 06:42:50 -0500 From: Heiko Stuebner To: Mark Yao Cc: David Airlie , Russell King , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Dominik Behr Subject: Re: [PATCH] drm/rockchip: vop: fix window origin calculation Date: Tue, 10 Nov 2015 12:42:21 +0100 Message-ID: <1671071.tld3k90Oeo@phil> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.13; x86_64; ; ) In-Reply-To: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> References: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao: > From: Dominik Behr > > VOP_WINx_DSP_ST does not require subtracting 1 from the values written to > it. It actually causes the screen to be shifted by one pixel. > > Signed-off-by: Mark Yao funny I never noticed that shift, but now that you mention it, I see it too on my Chromebook and the patch fixes this. I've also looked up the matching data in the TRM, so Reviewed-by: Heiko Stuebner Tested-by: Heiko Stuebner Heiko