From: patchwork-bot+netdevbpf@kernel.org
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
dsahern@gmail.com, chenjunxin1@huawei.com, petrm@nvidia.com,
mlxsw@nvidia.com
Subject: Re: [PATCH iproute2] dcb: Do not leave ACKs in socket receive buffer
Date: Thu, 29 Dec 2022 16:50:15 +0000 [thread overview]
Message-ID: <167233261544.30800.10653820168692161796.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221227110318.2899056-1-idosch@nvidia.com>
Hello:
This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:
On Tue, 27 Dec 2022 13:03:18 +0200 you wrote:
> Originally, the dcb utility only stopped receiving messages from a
> socket when it found the attribute it was looking for. Cited commit
> changed that, so that the utility will also stop when seeing an ACK
> (NLMSG_ERROR message), by setting the NLM_F_ACK flag on requests.
>
> This is problematic because it means a successful request will leave an
> ACK in the socket receive buffer, causing the next request to bail
> before reading its response.
>
> [...]
Here is the summary with links:
- [iproute2] dcb: Do not leave ACKs in socket receive buffer
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=d0e02f35af33
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-12-29 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 11:03 [PATCH iproute2] dcb: Do not leave ACKs in socket receive buffer Ido Schimmel
2022-12-29 16:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167233261544.30800.10653820168692161796.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=chenjunxin1@huawei.com \
--cc=dsahern@gmail.com \
--cc=idosch@nvidia.com \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.