From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:33586 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1727026AbeHKB1Z (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 10 Aug 2018 21:27:25 -0400
From: David Howells <dhowells@redhat.com>
In-Reply-To: <20180810220027.2735-2-avagin@openvz.org>
References: <20180810220027.2735-2-avagin@openvz.org> <20180810220027.2735-1-avagin@openvz.org>
To: Andrei Vagin <avagin@openvz.org>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
        Andrei Vagin <avagin@gmail.com>
Subject: Re: [PATCH dhowells/mount-api 2/2] selftests: implement a test for a new mount API
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <16723.1533941730.1@warthog.procyon.org.uk>
Date: Fri, 10 Aug 2018 23:55:30 +0100
Message-ID: <16724.1533941730@warthog.procyon.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Andrei Vagin <avagin@openvz.org> wrote:

> +static const char dev[] = "s test_fsopen_123";

Did you mean to prefix that with "s "?

> +	if (sys_fsconfig(fsfd, FSCONFIG_SET_STRING, "source", dev, 0) < 0)
> +		return pr_err("fsconfig_set_string sets source = %s", dev);

Note that it's not necessary to provide a source for /proc since it will just
ignore it.

Anyway, thanks for doing this!

David