Re: [Buildroot] [PATCH] package/wilc-driver: fix build failure up to Linux 6.1

From: Kris Bahnsen via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/wilc-driver: fix build failure up to Linux 6.1
Date: Mon, 02 Jan 2023 14:28:55 -0800	[thread overview]
Message-ID: <1672698535.3896.5.camel@embeddedTS.com> (raw)
In-Reply-To: <CB65BA13-5218-4C00-86E0-CB128E71F322@benettiengineering.com>

All,

I accidentally replied out of the thread and I wanted to follow up
here just to make sure it got organized in the right place. See my
previous message here:
https://lists.buildroot.org/pipermail/buildroot/2023-January/659164.html

On Thu, 2022-12-29 at 23:04 +0100, Giulio Benetti wrote:
> Hi Thomas,
> 
> > Il giorno 29 dic 2022, alle ore 09:58, Thomas Petazzoni <thomas.petazzoni@bootlin.com> ha scritto:
> > 
> > On Wed, 28 Dec 2022 21:53:23 +0100
> > Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> > 
> > > Add patches pending upstream[0] to handle various data types and api
> > > changes up to Linux 6.1.
> > > 
> > > [0]: https://github.com/embeddedTS/wilc3000-external-module/pull/2
> > > 
> > > Fixes:
> > > http://autobuild.buildroot.net/results/6aa7475a21a6060e9fce3552f73e6e7100a8b2aa
> > > 
> > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > > ---
> > > ...missing-prandom_u32-with-Linux-6.1.0.patch |  34 +++
> > > ...fix-build-failure-on-remove-callback.patch |  44 ++++
> > > ...uild-failure-with-Linux-5.19-and-6.1.patch |  98 ++++++++
> > > ...on_parameters-Linux-6.1-build-failur.patch | 216 ++++++++++++++++++
> > > 4 files changed, 392 insertions(+)
> > > create mode 100644 package/wilc-driver/0001-cfg80211.c-fix-missing-prandom_u32-with-Linux-6.1.0.patch
> > > create mode 100644 package/wilc-driver/0002-spi.c-fix-build-failure-on-remove-callback.patch
> > > create mode 100644 package/wilc-driver/0003-cfg80211.c-fix-build-failure-with-Linux-5.19-and-6.1.patch
> > > create mode 100644 package/wilc-driver/0004-Fix-struct-station_parameters-Linux-6.1-build-failur.patch
> > 
> > Applied to master, thanks. However, it is worth mentioning that the
> > real "upstream" for this driver is the linux4sam Linux tree at
> > https://github.com/linux4sam/linux-at91.
> 
> Ah, yes
> 
> > They are currently based on
> > 5.15, but I suppose they will rebase soon on 6.1,
> 
> I think so too
> 
> > so they might be
> > interested in your fixes.
> 
> How can I point my fixes? Do you think it’s enough to open an Issue in linux-at91 GitHub?
> 
> > I don't know if/when the out-of-tree variant
> > of the WILC driver at
> > https://github.com/embeddedTS/wilc3000-external-module gets synced from
> > the linux4sam tree.
> 
> I’ve compared the two drivers and they are pretty the same, not completely but very close excluding the various #ifdef’s.
> I don’t either know how that repo is handled but I can monitor it.

The external is currently a release tag (or a few) behind. The latest
changes in the linux4sam kernel tree remove a lot of the #ifdefs as you
noted which ends up preventing it from compiling against older kernels.

We've tested the external tree against 4.9, 5.10, and 5.15 with success.

-Kris

> 
> Best regards
> Giulio
> 
> > 
> > Best regards,
> > 
> > Thomas
> > -- 
> > Thomas Petazzoni, CTO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot