From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEE9F25E447 for ; Wed, 9 Apr 2025 11:57:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744199824; cv=none; b=SJ0r2U4gUXIX2JdFEgmrQjErCAQ4a8VjDh/GuSA3fLeJWTNsbdQWkiQLkjUDWv9m2vV6I7dQT8LaZevK65B1yksO9TEM4a6PSsoh9DqVHvoGB8CPwYL1spLXS2Jhg037Mb9YVefhlHuF0NZhz6GDlx+d+Nd5s6PFQRYs7CrJjCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744199824; c=relaxed/simple; bh=bYsI9fKny4SxKbP5giJ46oTfBA030R5OcsLlxdPQ3rc=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=l251DVhJlQam+BBLC1Rn01MFNZ5y+rxPcRSh9A/TxCeQ18YauMr2ETsJDGd5wBn89JQOL4aEdOyf/da36iMEAAsTiSPB3t0X34tZu6UfYauF86rfJAVU+ni6QaqXr5wLLj21/fWJSE2rxIeBwZHCFNL7uaWCiYJGt1B+j9Vmgq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cEQ/C4K7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cEQ/C4K7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744199821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9NW6RqANC34MSybPlsfK/Ojrrpi57Btk5nqfiDMR41o=; b=cEQ/C4K75LplDH0TI5d6WlfgTRDYcOsMXuKrZqAsTiAzdhzSBolNssRtyinwJQl7m+pu9I Z+Wdl9q7pqaNsS3W5VYFLwAbm3NY3qrK5bAWPdvbSHKyXlNjWM4pT22CYv6VnbtJLMl1A/ vo3wJJ6/SoreiyXkiLBxFJqIcuJCvIQ= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-DD6Y0lk6PsChPzmI_5p8DQ-1; Wed, 09 Apr 2025 07:56:57 -0400 X-MC-Unique: DD6Y0lk6PsChPzmI_5p8DQ-1 X-Mimecast-MFC-AGG-ID: DD6Y0lk6PsChPzmI_5p8DQ_1744199816 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4E9BE195609E; Wed, 9 Apr 2025 11:56:56 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.40]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7B71A180B488; Wed, 9 Apr 2025 11:56:54 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1BEAB585-4A65-475C-85CC-332C98859546@fb.com> References: <1BEAB585-4A65-475C-85CC-332C98859546@fb.com> <20250407184730.3568147-1-song@kernel.org> <1478622.1744097510@warthog.procyon.org.uk> <05f5b9f694ca9b1573ea8e1801098b65@manguebit.com> To: Song Liu Cc: dhowells@redhat.com, Paulo Alcantara , Song Liu , "netfs@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , Kernel Team Subject: Re: [PATCH] netfs: Let netfs depends on PROC_FS Precedence: bulk X-Mailing-List: netfs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1672920.1744199813.1@warthog.procyon.org.uk> Date: Wed, 09 Apr 2025 12:56:53 +0100 Message-ID: <1672921.1744199813@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Song Liu wrote: > Thanks for the review. I guess we will need the following changes, You need a little bit more. The error handling in the init function also needs #ifdef'ing too lest the compiler warn about unused goto labels. > probably in two separate patches? Hmmm... yes. I'm suddenly uncertain about the order modules are inited. It might actually need to be fs_initcall(). David