All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: GPIO request failure with PCF pinmux
Date: Tue, 02 Oct 2012 12:24:57 +0000	[thread overview]
Message-ID: <1674410.rS86A9UHuy@avalon> (raw)
In-Reply-To: <6045802.ynsOILKLIK@avalon>

Hi Paul,

On Tuesday 18 September 2012 16:22:38 Paul Mundt wrote:
> On Fri, Sep 14, 2012 at 10:36:34PM +0200, Laurent Pinchart wrote:
> > And while I'm at it, trying to set the pin to the PWM function doesn't
> > seem to work anymore on v3.6. It looks like the pin stays configured as a
> > GPIO. How am I supposed to configure pinmuxing from the driver ?
> > Documentation/pinctrl.txt doesn't help much, and the code isn't easy to
> > understand. There's probably no registered mapping (whatever a mapping
> > is), are they supposed to come from DT ?
> 
> For the moment requesting as a function as before should be fine,
> although it's possible that your config-as-gpio reconfig-as-function flow
> has tripped up some of the logic. Both were tested independently, but as
> you can tell I've overlooked the reuse of the same pin by the same driver
> in different ways case.
> 
> And yes, you've hit on the next phase of the pfc rework. At present we
> have a GPIO shim that enables function requests via the GPIO API as
> before, but it's not the way we want to go forward and remains there only
> for backwards compatability.
> 
> More work needs to be done both in the drivers and the board/platform to
> make use of pinctrl mappings. I have some work in progress for sh-sci,
> but ran out of time to get it merged for this merge window.

What's the status of that work ? I'll have to implement pinctrl support for 
the H1 series, and having sample code would be helpful. Are there still core 
pieces missing ?

> The DT support is something else that has to be worked out. I personally
> have no interest in supporting DT, as I view the entire endeavour as nothing
> but a solution in search of a problem. If someone wants DT support for this
> they're welcome to hack something up, though. I won't oppose DT changes
> going in, regardless of whether they're ultimately a waste of time or not.

-- 
Regards,

Laurent Pinchart


      parent reply	other threads:[~2012-10-02 12:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14 20:11 GPIO request failure with PCF pinmux Laurent Pinchart
2012-09-14 20:36 ` Laurent Pinchart
2012-09-18  7:12 ` Paul Mundt
2012-09-18  7:22 ` Paul Mundt
2012-09-19 15:19 ` Laurent Pinchart
2012-09-19 15:33 ` Paul Mundt
2012-10-02 12:24 ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1674410.rS86A9UHuy@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.