From: Thomas Monjalon <thomas@monjalon.net>
To: "Kundapura, Ganapati" <ganapati.kundapura@intel.com>,
Ray Kinsella <mdr@ashroe.eu>,
David Marchand <david.marchand@redhat.com>,
Jerin Jacob <jerinjacobk@gmail.com>
Cc: dpdk-dev <dev@dpdk.org>,
"Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] eventdev/rx-adapter: add telemetry callbacks
Date: Tue, 12 Oct 2021 11:10:27 +0200 [thread overview]
Message-ID: <1674729.iRVOSB7e9I@thomas> (raw)
In-Reply-To: <CALBAE1ME1jUQzfsSd+4wTG5qoiwCYssBypnbiWuN8Zdz_BAipQ@mail.gmail.com>
12/10/2021 10:47, Jerin Jacob:
> On Tue, Oct 12, 2021 at 2:05 PM Kundapura, Ganapati
> <ganapati.kundapura@intel.com> wrote:
> > From: Jerin Jacob <jerinjacobk@gmail.com>
> > > > --- a/lib/eventdev/rte_event_eth_rx_adapter.h
> > > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.h
> > > > @@ -216,6 +216,10 @@ struct rte_event_eth_rx_adapter_stats {
> > > > /**< Eventdev enqueue count */
> > > > uint64_t rx_enq_retry;
> > > > /**< Eventdev enqueue retry count */
> > > > + uint64_t rx_event_buf_count;
> > > > + /**< Rx event buffered count */
> > > > + uint64_t rx_event_buf_size;
> > >
> > >
> > > Isn't ABI breakage? CI did not warn this. Isn't this a public structure?
> > Please confirm if moving the above two members to end of the structure overcomes ABI breakage?
>
>
> + @Ray Kinsella @Thomas Monjalon @David Marchand
>
> It will still break the ABI. IMO, Since it is an ABI breaking release
> it is OK. If there are no other objections, Please move the variable
> to end
> of the structure and update release notes for ABI changes.
Why moving since it breaks ABI anyway?
I think you can keep as is.
next prev parent reply other threads:[~2021-10-12 9:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 12:57 [dpdk-dev] [PATCH v1] eventdev/rx-adapter: add telemetry callbacks Ganapati Kundapura
2021-10-07 13:46 ` [dpdk-dev] [PATCH v2] " Ganapati Kundapura
2021-10-07 16:02 ` [dpdk-dev] [EXT] " Gowrishankar Muthukrishnan
2021-10-12 10:25 ` [dpdk-dev] [PATCH v3] eventdev/rx_adapter: " Ganapati Kundapura
2021-10-12 13:09 ` Jayatheerthan, Jay
2021-10-12 14:05 ` Naga Harish K, S V
2021-10-12 16:13 ` Kundapura, Ganapati
2021-10-13 6:48 ` Naga Harish K, S V
2021-10-13 8:15 ` Kundapura, Ganapati
2021-10-13 7:57 ` [dpdk-dev] [PATCH v4] " Ganapati Kundapura
2021-10-13 12:09 ` Naga Harish K, S V
2021-10-14 8:25 ` Jerin Jacob
2021-10-11 16:14 ` [dpdk-dev] [PATCH v1] eventdev/rx-adapter: " Jerin Jacob
2021-10-12 8:35 ` Kundapura, Ganapati
2021-10-12 8:47 ` Jerin Jacob
2021-10-12 9:10 ` Thomas Monjalon [this message]
2021-10-12 9:26 ` Jerin Jacob
2021-10-12 10:05 ` Kinsella, Ray
2021-10-12 10:29 ` Kundapura, Ganapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1674729.iRVOSB7e9I@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ganapati.kundapura@intel.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=mdr@ashroe.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.