Re: [PATCH] drm/i915/dp_mst: Fix getting display pointer in intel_dp_mst_compute_min_hblank()

["Almahallawy, Khaled" <khaled.almahallawy@intel.com>]

Thank You for the fix.


Tested-by: Khaled Almahallawy <khaled.almahallawy@intel.com>
Reviewed-by: Khaled Almahallawy <khaled.almahallawy@intel.com>

On Thu, 2025-02-06 at 01:28 +0200, Imre Deak wrote:
> The MST intel_connector::encoder pointer is NULL if the connector
> hasn't
> been enabled before, so it can't be used to retrieve the display
> pointer. Use instead the connector pointer directly, which also
> simplifies things.
> 
> Fixes: a5ebe00c2ace ("drm/i915/dp: Guarantee a minimum HBlank time")
> Reported-by: Khaled Almahallawy <khaled.almahallawy@intel.com>
> Cc: Arun R Murthy <arun.r.murthy@intel.com>
> Cc: Suraj Kandpal <suraj.kandpal@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index f58d56a1ea03a..1d43c2574e616 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -213,8 +213,7 @@ static void
> intel_dp_mst_compute_min_hblank(struct intel_crtc_state *crtc_state,
>  					    struct intel_connector
> *connector,
>  					    int bpp_x16)
>  {
> -	struct intel_encoder *encoder = connector->encoder;
> -	struct intel_display *display = to_intel_display(encoder);
> +	struct intel_display *display = to_intel_display(connector);
>  	const struct drm_display_mode *adjusted_mode =
>  					&crtc_state-
> >hw.adjusted_mode;
>  	int symbol_size = intel_dp_is_uhbr(crtc_state) ? 32 : 8;