All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: dhowells@redhat.com, slava@dubeyko.com,
	Alex Markuze <amarkuze@redhat.com>, Xiubo Li <xiubli@redhat.com>,
	Ilya Dryomov <idryomov@gmail.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>,
	ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, Slava.Dubeyko@ibm.com
Subject: Re: Does ceph_fill_inode() mishandle I_NEW?
Date: Thu, 13 Mar 2025 23:37:35 +0000	[thread overview]
Message-ID: <1675539.1741909055@warthog.procyon.org.uk> (raw)
In-Reply-To: <756af030a5085152f923e41b84746930b464af5d.camel@kernel.org>

Jeff Layton <jlayton@kernel.org> wrote:

> I don't think that can happen. An I_NEW inode hasn't been properly
> hashed yet, so nothing should be able to find it until
> unlock_new_inode() is called.

That's not where the issue lies.  I'm talking about *after* I_NEW has been
cleared.

Imagine you have a file that has hard links in several directories.  Can
simultaneous lookup on a number of those hard links result in you going
through ceph_fill_inode() a number of times in parallel?

David


      reply	other threads:[~2025-03-13 23:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13 10:17 Does ceph_fill_inode() mishandle I_NEW? David Howells
2025-03-13 19:14 ` slava
2025-03-13 20:47   ` David Howells
2025-03-13 21:46     ` Viacheslav Dubeyko
2025-03-13 23:47       ` David Howells
2025-03-13 22:47     ` Jeff Layton
2025-03-13 23:37       ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1675539.1741909055@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=Slava.Dubeyko@ibm.com \
    --cc=amarkuze@redhat.com \
    --cc=brauner@kernel.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=slava@dubeyko.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xiubli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.