From: <gregkh@linuxfoundation.org>
To: dmitry.baryshkov@linaro.org,gregkh@linuxfoundation.org,johan+linaro@kernel.org,patches@lists.linux.dev,swboyd@chromium.org,vkoul@kernel.org
Cc: <stable-commits@vger.kernel.org>
Subject: Patch "phy: qcom-qmp-combo: fix runtime suspend" has been added to the 5.15-stable tree
Date: Tue, 07 Feb 2023 12:10:30 +0100 [thread overview]
Message-ID: <1675768230154218@kroah.com> (raw)
In-Reply-To: <20230203222616.2935268-6-swboyd@chromium.org>
This is a note to let you know that I've just added the patch titled
phy: qcom-qmp-combo: fix runtime suspend
to the 5.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
phy-qcom-qmp-combo-fix-runtime-suspend.patch
and it can be found in the queue-5.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
From stable-owner@vger.kernel.org Fri Feb 3 23:27:28 2023
From: Stephen Boyd <swboyd@chromium.org>
Date: Fri, 3 Feb 2023 14:26:16 -0800
Subject: phy: qcom-qmp-combo: fix runtime suspend
To: stable@vger.kernel.org
Cc: Johan Hovold <johan+linaro@kernel.org>, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Vinod Koul <vkoul@kernel.org>
Message-ID: <20230203222616.2935268-6-swboyd@chromium.org>
From: Johan Hovold <johan+linaro@kernel.org>
commit c7b98de745cffdceefc077ad5cf9cda032ef8959 upstream.
Drop the confused runtime-suspend type check which effectively broke
runtime PM if the DP child node happens to be parsed before the USB
child node during probe (e.g. due to order of child nodes in the
devicetree).
Instead use the new driver data USB PHY pointer to access the USB
configuration and resources.
Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20221114081346.5116-6-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
[swboyd@chromium.org: Backport to pre-split driver. Note that the
condition is kept so that ufs and pcie don't do anything as before]
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -4985,7 +4985,7 @@ static void qcom_qmp_phy_disable_autonom
static int __maybe_unused qcom_qmp_phy_runtime_suspend(struct device *dev)
{
struct qcom_qmp *qmp = dev_get_drvdata(dev);
- struct qmp_phy *qphy = qmp->phys[0];
+ struct qmp_phy *qphy = qmp->usb_phy;
const struct qmp_phy_cfg *cfg = qphy->cfg;
dev_vdbg(dev, "Suspending QMP phy, mode:%d\n", qphy->mode);
@@ -5010,7 +5010,7 @@ static int __maybe_unused qcom_qmp_phy_r
static int __maybe_unused qcom_qmp_phy_runtime_resume(struct device *dev)
{
struct qcom_qmp *qmp = dev_get_drvdata(dev);
- struct qmp_phy *qphy = qmp->phys[0];
+ struct qmp_phy *qphy = qmp->usb_phy;
const struct qmp_phy_cfg *cfg = qphy->cfg;
int ret = 0;
Patches currently in stable-queue which might be from stable-owner@vger.kernel.org are
queue-5.15/phy-qcom-qmp-combo-fix-broken-power-on.patch
queue-5.15/phy-qcom-qmp-combo-fix-runtime-suspend.patch
queue-5.15/phy-qcom-qmp-combo-disable-runtime-pm-on-unbind.patch
queue-5.15/phy-qcom-qmp-usb-fix-memleak-on-probe-deferral.patch
queue-5.15/phy-qcom-qmp-combo-fix-memleak-on-probe-deferral.patch
next prev parent reply other threads:[~2023-02-07 11:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 22:26 [PATCH 5.15.y v3 0/5] phy: qcom-qmp-combo: Backport some stable fixes Stephen Boyd
2023-02-03 22:26 ` [PATCH 5.15.y v3 1/5] phy: qcom-qmp-combo: disable runtime PM on unbind Stephen Boyd
2023-02-07 11:10 ` Patch "phy: qcom-qmp-combo: disable runtime PM on unbind" has been added to the 5.15-stable tree gregkh
2023-02-03 22:26 ` [PATCH 5.15.y v3 2/5] phy: qcom-qmp-combo: fix memleak on probe deferral Stephen Boyd
2023-02-07 11:10 ` Patch "phy: qcom-qmp-combo: fix memleak on probe deferral" has been added to the 5.15-stable tree gregkh
2023-02-03 22:26 ` [PATCH 5.15.y v3 3/5] phy: qcom-qmp-usb: fix memleak on probe deferral Stephen Boyd
2023-02-07 11:10 ` Patch "phy: qcom-qmp-usb: fix memleak on probe deferral" has been added to the 5.15-stable tree gregkh
2023-02-03 22:26 ` [PATCH 5.15.y v3 4/5] phy: qcom-qmp-combo: fix broken power on Stephen Boyd
2023-02-07 11:10 ` Patch "phy: qcom-qmp-combo: fix broken power on" has been added to the 5.15-stable tree gregkh
2023-02-03 22:26 ` [PATCH 5.15.y v3 5/5] phy: qcom-qmp-combo: fix runtime suspend Stephen Boyd
2023-02-07 11:10 ` gregkh [this message]
2023-02-07 11:10 ` [PATCH 5.15.y v3 0/5] phy: qcom-qmp-combo: Backport some stable fixes Greg KH
[not found] <20221225150913.691403-1-sashal@kernel.org>
2022-12-27 9:14 ` Patch "phy: qcom-qmp-combo: fix runtime suspend" has been added to the 5.15-stable tree Johan Hovold
2022-12-27 13:04 ` Sasha Levin
2022-12-27 13:24 ` Johan Hovold
2022-12-27 20:26 ` Sasha Levin
2022-12-28 11:06 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1675768230154218@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=patches@lists.linux.dev \
--cc=stable-commits@vger.kernel.org \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.