Re: [PATCH] i2c: rk3x: fix interrupt handling issue

["Heiko Stübner" <heiko@sntech.de>]

Am Freitag, 8. August 2014, 17:41:40 schrieb Addy Ke:
> If slave holds scl, I2C_IPD[7] will be set 1 by controller
> for debugging. Driver must ignore it.
> 
> [    5.752391] rk3x-i2c ff160000.i2c: unexpected irq in WRITE: 0x80
> [    5.939027] rk3x-i2c ff160000.i2c: timeout, ipd: 0x80, state: 4
> 
> Signed-off-by: Addy Ke <addy.ke@rock-chips.com>

I checked the manuals, bits [31:7] are marked as reserved in all of them, so

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/i2c/busses/i2c-rk3x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 9e3084c..eab49e6 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -399,7 +399,7 @@ static irqreturn_t rk3x_i2c_irq(int irqno, void *dev_id)
> }
> 
>  	/* is there anything left to handle? */
> -	if (unlikely(ipd == 0))
> +	if (unlikely((ipd & REG_INT_ALL) == 0))
>  		goto out;
> 
>  	switch (i2c->state) {