All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Olof Johansson <olof@lixom.net>,
	Leela Krishna Amudala <l.krishna@samsung.com>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	Wim Van Sebroeck <wim@iguana.be>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Tomasz Figa <t.figa@samsung.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"cpgs ." <cpgs@samsung.com>, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH V11 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files
Date: Thu, 05 Dec 2013 19:59:15 +0100	[thread overview]
Message-ID: <1676404.arUWsvfauz@flatron> (raw)
In-Reply-To: <CAD=FV=UcqaG9Dw_rd-bdTAmDwdW-_yCO6HpaEr1G07AW4TWm0w@mail.gmail.com>

On Thursday 05 of December 2013 10:35:20 Doug Anderson wrote:
> Tomasz,
> 
> On Thu, Dec 5, 2013 at 10:30 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> >> I'd vote for using "pmu-system-registers".  We end up using the
> >> "syscon" subsystem but really we're describing pmu registers.
> >>
> >> I'd even say that you don't need to formally specify the "name" in the
> >> bindings (though I'm not up with all the latest device tree
> >> requirements).  ...still you'd want to use "pmu-system-registers" in
> >> the DTS changes.
> >
> > Well, since the name should specify the class of device, I would say that
> > pmu-system-registers is too specific. If we want to change this, I'd say
> > we should go with system-controller.
> 
> ...but the "compatible" is "samsung,exynos5250-pmu", "syscon", right?
> That means that the class of the device is "exynos5250-pmu", right?

Nope. "samsung,exynos5250-pmu" is the specific device (or hardware
programming interface) this device is compatible with.

With class I mean the generic kind of device, such as system-controller,
i2c, pinctrl, display, etc., as specified by sections 2.2.1 and 2.2.2 of
ePAPR.

Anyway, node names are just a matter of coding style, as they don't have
any semantical meaning in most cases (such as this one).

> It is also compatible with the generic "syscon" class of devices.

It is also compatible with the generic "syscon" programming interface,
which represents a set of loosely related registers that control various
aspects of other IP blocks.

Best regards,
Tomasz

  reply	other threads:[~2013-12-05 18:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-28  4:34 [PATCH V11 0/3] Add watchdog DT nodes and use syscon regmap interface to configure pmu registers Leela Krishna Amudala
2013-11-28  4:34 ` [PATCH V11 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files Leela Krishna Amudala
2013-12-02 18:50   ` Olof Johansson
2013-12-02 19:49     ` Tomasz Figa
2013-12-05 18:26       ` Doug Anderson
2013-12-05 18:30         ` Tomasz Figa
2013-12-05 18:35           ` Doug Anderson
2013-12-05 18:59             ` Tomasz Figa [this message]
2013-12-05 19:02               ` Doug Anderson
2013-11-28  4:34 ` [PATCH V11 2/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register Leela Krishna Amudala
     [not found]   ` <1385613243-3559-3-git-send-email-l.krishna-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-12-02 17:32     ` Doug Anderson
2013-12-02 17:32       ` Doug Anderson
2013-12-05 18:27       ` Doug Anderson
2013-11-28  4:34 ` [PATCH V11 3/3] ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420 Leela Krishna Amudala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1676404.arUWsvfauz@flatron \
    --to=tomasz.figa@gmail.com \
    --cc=cpgs@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=kgene.kim@samsung.com \
    --cc=l.krishna@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=olof@lixom.net \
    --cc=t.figa@samsung.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.