All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] sunxi: Add clock support for TV encoder
Date: Fri, 12 May 2017 18:55:56 +0200	[thread overview]
Message-ID: <1677130.BCmeezuOta@jernej-laptop> (raw)
In-Reply-To: <20170512154717.qq554lkkphlxvrw3@flea.home>

Hi Maxime,

Dne petek, 12. maj 2017 ob 17:47:17 CEST je Maxime Ripard napisal(a):
> Hi Jernej,
> 
> On Wed, May 10, 2017 at 06:46:29PM +0200, Jernej Skrabec wrote:
> > This patch adds support for TV encoder clocks which will be used later.
> > 
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > ---
> > 
> >  arch/arm/include/asm/arch-sunxi/clock_sun6i.h | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/include/asm/arch-sunxi/clock_sun6i.h
> > b/arch/arm/include/asm/arch-sunxi/clock_sun6i.h index
> > a44ea77576..dc011cc964 100644
> > --- a/arch/arm/include/asm/arch-sunxi/clock_sun6i.h
> > +++ b/arch/arm/include/asm/arch-sunxi/clock_sun6i.h
> > @@ -83,7 +83,8 @@ struct sunxi_ccm_reg {
> > 
> >  	u32 lcd0_ch0_clk_cfg;	/* 0x118 LCD0 CH0 module clock */
> >  	u32 lcd1_ch0_clk_cfg;	/* 0x11c LCD1 CH0 module clock */
> >  
> >  #endif
> > 
> > -	u32 reserved14[3];
> > +	u32 tve_clk_cfg;	/* 0x120 TVE module clock */
> > +	u32 reserved14[2];
> 
> Maybe we should protect that with a comment, or an ifdef, that this is
> only for the H3-generation SoCs?

I vote for extending the comment, like: 
/* 0x120 H3/H5 TVE module clock */

Would that be ok?

Best regards,
Jernej

  reply	other threads:[~2017-05-12 16:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10 16:46 [U-Boot] [PATCH 0/3] sunxi: video: Add support for TV (composite) output on H3/H5 Jernej Skrabec
2017-05-10 16:46 ` [U-Boot] [PATCH 1/3] sunxi: video: Split out TVE code Jernej Skrabec
2017-05-15  3:03   ` Simon Glass
2017-05-15 19:08   ` Anatolij Gustschin
2017-05-10 16:46 ` [U-Boot] [PATCH 2/3] sunxi: Add clock support for TV encoder Jernej Skrabec
2017-05-12 15:47   ` Maxime Ripard
2017-05-12 16:55     ` Jernej Škrabec [this message]
2017-05-12 20:27       ` Maxime Ripard
2017-05-15 19:25   ` Anatolij Gustschin
2017-05-10 16:46 ` [U-Boot] [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver Jernej Skrabec
2017-05-12 16:06   ` Maxime Ripard
2017-05-13 15:02     ` [U-Boot] [linux-sunxi] " icenowy at aosc.io
2017-05-13 15:14       ` Chen-Yu Tsai
2017-05-15  6:31         ` Maxime Ripard
2017-05-15 20:10           ` Jernej Škrabec
2017-05-15  3:03     ` [U-Boot] " Simon Glass
2017-05-15  6:11       ` Maxime Ripard
2017-05-15 19:47         ` Jernej Škrabec
2017-05-15 20:00           ` Anatolij Gustschin
2017-05-15 20:05         ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1677130.BCmeezuOta@jernej-laptop \
    --to=jernej.skrabec@siol.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.