From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aib29ajc249.phx1.oracleemaildelivery.com (aib29ajc249.phx1.oracleemaildelivery.com [192.29.103.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65720C61DA4 for ; Mon, 6 Mar 2023 13:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=oss-phx-1109; d=oss.oracle.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=0obn0K6BnKbSlyvzJyhLdMVZBYPPCFbo+VCvDJ6l4fg=; b=STtF+CswX+Oh6r2Imap9C7LgJmIlkQ8YS9Y13wslZH0xm6yDb292WI+QXHZkWtAW1yxfpEyh6N9u NBafuMw3HZucXvFaA57VB2VDAkIncbXc4fIGfQa/s9ilwOtUo9pxtsIZpQ248URJWW+4weChA34p QU7Zmc6UCIMEkw4WC1arWCh15BvYjHjQfG8oblL0i6xRAdD/jWwM1VR+p2MWocXLdfYUvuEq02q9 byP7Kwc/iJ0IvkKZhm9L4/dWB3ZGpLTy7UiZLUoD2/EszCUyHIxzEZf95fwKLLNupQn3fedbSVKB NJnJJHTdBLGa1Id8GHqwVgNWyoSktAqA/i5PQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=prod-phx-20191217; d=phx1.rp.oracleemaildelivery.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=0obn0K6BnKbSlyvzJyhLdMVZBYPPCFbo+VCvDJ6l4fg=; b=XC55MaIpV941Xovsdx5s0zVIKFCe4YXBocrSrCCXL9on9uZ50cUltZbPlZoT43EuudPzt60bEAup b2yWDPpjqIQ715guA+lQVbirHOhG+IvJ3SHgENz0lRITrfUKKUGJeupPcqUxode3C+Itdy+hdmJ9 sj1HqpZSccpWAYjzK5/oEWrmZg+ZF2Ucmj+90kmPkvB6yrKY4CG38o49txsPe0RTB18ehIGZEiHU NHgVOrnhuZx3pyp39hMKJPi7O8LqKCmWtIeUmv/5NpRiXBFKh+6ULzkYprmpKhCXxbOhw633xDCV +bhjefAzSLYNNhIikNHCKmQlq13mp4yS+NdTXw== Received: by omta-ad2-fd1-202-us-phoenix-1.omtaad2.vcndpphx.oraclevcn.com (Oracle Communications Messaging Server 8.1.0.1.20230214 64bit (built Feb 14 2023)) with ESMTPS id <0RR30033RQBAPOD0@omta-ad2-fd1-202-us-phoenix-1.omtaad2.vcndpphx.oraclevcn.com> for ocfs2-devel@archiver.kernel.org; Mon, 06 Mar 2023 13:47:34 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678110441; bh=QwkR7VDI/0MU2m2PbFcrJjHwfPsO1xqNhkAS/0MWskY=; h=Subject:To:Cc:From:Date:From; b=AepYgbzv+iTFmKwJfbDDtxHGZv7u9buaONXjv6nt0vKvpSLfZK4OPlMJJrG++CgWV g5Z3yOShhsfvZLMZwQHyH7KJqjO9Hctb0atjKN0cwz0jMcyeB8RYt6fevvMejeW/vW RTwQ9w+3CK6JZmmy+K5U89pxUaHoFkqoOhdkbp9E= To: akpm@linux-foundation.org, gechangwei@live.cn, ghe@suse.com, gregkh@linuxfoundation.org, heming.zhao@suse.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, junxiao.bi@oracle.com, mark@fasheh.com, ocfs2-devel@oss.oracle.com, piaojun@huawei.com Date: Mon, 06 Mar 2023 14:44:12 +0100 Message-id: <167811025216774@kroah.com> MIME-version: 1.0 X-Source-IP: 139.178.84.217 X-Proofpoint-Virus-Version: vendor=nai engine=6500 definitions=10641 signatures=596816 X-Proofpoint-Spam-Details: rule=tap_notspam policy=tap score=0 bulkscore=0 clxscore=256 phishscore=0 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 priorityscore=95 spamscore=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303060122 Cc: stable-commits@vger.kernel.org Subject: [Ocfs2-devel] Patch "ocfs2: fix defrag path triggering jbd2 ASSERT" has been added to the 5.10-stable tree X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: gregkh--- via Ocfs2-devel Reply-to: gregkh@linuxfoundation.org Content-type: text/plain; charset="us-ascii" Content-transfer-encoding: 7bit Errors-to: ocfs2-devel-bounces@oss.oracle.com X-stable: commit X-Patchwork-Hint: ignore X-ServerName: dfw.source.kernel.org X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 ip4:72.55.140.81 ip4:52.25.139.140 ip4:139.178.84.217 ip6:2604:1380:4641:c500::1 ip4:145.40.68.75 ip6:2604:1380:4601:e00::1 ip4:145.40.73.55 ip6:2604:1380:40e1:4800::1 include:_spf.google.com include:amazonses.com include:_spf.salesforce.com -all X-Spam: Clean X-Proofpoint-GUID: c6ZUL-MYNqaFVQ_1ZEg2JBFlqdi3HmAF X-Proofpoint-ORIG-GUID: c6ZUL-MYNqaFVQ_1ZEg2JBFlqdi3HmAF Reporting-Meta: AAFPz0rjsEw8C1toOnqm6tmFRLd8WQ6M5LAzRQWG3qJ0SZeoDlhny5aljdeB/S6T EGNP4v8Z/Znnc8fVODsj+hP3RRCgNc2gZDouh8aRyjbST/D8+VyFu1T758/YeL5Q krNgdy0gdyn045RXRKgwZQ0gCN8RQ+5lNtz5ppxq/cLJTXmZgU+gn7zbUI5710ur yYFZxXhvaedyPD6cBShNuRzRYc+7VBWNTT4+C0ML1QwBpAJt5xAJIK92aK8JQeUI rQjDy5R8JcZc2sErSGINkggL1OeiGtxIQZM09lIP1BrnR0J7RvPgOvx5e5DFzjBi FEQ9741MEhnTbTKjAsYhCVmIIG7yg5O1c91qBRU5RTMrMlbpjz6Tzb90ma7uKw5P 09BqEdOUgMThSTr+tCyu7KnlPKXi1CFG8eCArFwBeP9LUZbTlLUTJqEeQhHG1CD9 IokyOC/TqpnNH3lG6lSbvod0/1UAZac6Hc8tXJCeRNSIhhZjqHC5Fp4s5KRFV221 8U5xtYFp+k2zyKXmgnv9Ke4GcD5Wi/rJrV6XQPJQzy2N This is a note to let you know that I've just added the patch titled ocfs2: fix defrag path triggering jbd2 ASSERT to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ocfs2-fix-defrag-path-triggering-jbd2-assert.patch and it can be found in the queue-5.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From 60eed1e3d45045623e46944ebc7c42c30a4350f0 Mon Sep 17 00:00:00 2001 From: Heming Zhao via Ocfs2-devel Date: Fri, 17 Feb 2023 08:37:17 +0800 Subject: ocfs2: fix defrag path triggering jbd2 ASSERT From: Heming Zhao via Ocfs2-devel commit 60eed1e3d45045623e46944ebc7c42c30a4350f0 upstream. code path: ocfs2_ioctl_move_extents ocfs2_move_extents ocfs2_defrag_extent __ocfs2_move_extent + ocfs2_journal_access_di + ocfs2_split_extent //sub-paths call jbd2_journal_restart + ocfs2_journal_dirty //crash by jbs2 ASSERT crash stacks: PID: 11297 TASK: ffff974a676dcd00 CPU: 67 COMMAND: "defragfs.ocfs2" #0 [ffffb25d8dad3900] machine_kexec at ffffffff8386fe01 #1 [ffffb25d8dad3958] __crash_kexec at ffffffff8395959d #2 [ffffb25d8dad3a20] crash_kexec at ffffffff8395a45d #3 [ffffb25d8dad3a38] oops_end at ffffffff83836d3f #4 [ffffb25d8dad3a58] do_trap at ffffffff83833205 #5 [ffffb25d8dad3aa0] do_invalid_op at ffffffff83833aa6 #6 [ffffb25d8dad3ac0] invalid_op at ffffffff84200d18 [exception RIP: jbd2_journal_dirty_metadata+0x2ba] RIP: ffffffffc09ca54a RSP: ffffb25d8dad3b70 RFLAGS: 00010207 RAX: 0000000000000000 RBX: ffff9706eedc5248 RCX: 0000000000000000 RDX: 0000000000000001 RSI: ffff97337029ea28 RDI: ffff9706eedc5250 RBP: ffff9703c3520200 R8: 000000000f46b0b2 R9: 0000000000000000 R10: 0000000000000001 R11: 00000001000000fe R12: ffff97337029ea28 R13: 0000000000000000 R14: ffff9703de59bf60 R15: ffff9706eedc5250 ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018 #7 [ffffb25d8dad3ba8] ocfs2_journal_dirty at ffffffffc137fb95 [ocfs2] #8 [ffffb25d8dad3be8] __ocfs2_move_extent at ffffffffc139a950 [ocfs2] #9 [ffffb25d8dad3c80] ocfs2_defrag_extent at ffffffffc139b2d2 [ocfs2] Analysis This bug has the same root cause of 'commit 7f27ec978b0e ("ocfs2: call ocfs2_journal_access_di() before ocfs2_journal_dirty() in ocfs2_write_end_nolock()")'. For this bug, jbd2_journal_restart() is called by ocfs2_split_extent() during defragmenting. How to fix For ocfs2_split_extent() can handle journal operations totally by itself. Caller doesn't need to call journal access/dirty pair, and caller only needs to call journal start/stop pair. The fix method is to remove journal access/dirty from __ocfs2_move_extent(). The discussion for this patch: https://oss.oracle.com/pipermail/ocfs2-devel/2023-February/000647.html Link: https://lkml.kernel.org/r/20230217003717.32469-1-heming.zhao@suse.com Signed-off-by: Heming Zhao Reviewed-by: Joseph Qi Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Gang He Cc: Jun Piao Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- fs/ocfs2/move_extents.c | 10 ---------- 1 file changed, 10 deletions(-) --- a/fs/ocfs2/move_extents.c +++ b/fs/ocfs2/move_extents.c @@ -107,14 +107,6 @@ static int __ocfs2_move_extent(handle_t */ replace_rec.e_flags = ext_flags & ~OCFS2_EXT_REFCOUNTED; - ret = ocfs2_journal_access_di(handle, INODE_CACHE(inode), - context->et.et_root_bh, - OCFS2_JOURNAL_ACCESS_WRITE); - if (ret) { - mlog_errno(ret); - goto out; - } - ret = ocfs2_split_extent(handle, &context->et, path, index, &replace_rec, context->meta_ac, &context->dealloc); @@ -123,8 +115,6 @@ static int __ocfs2_move_extent(handle_t goto out; } - ocfs2_journal_dirty(handle, context->et.et_root_bh); - context->new_phys_cpos = new_p_cpos; /* Patches currently in stable-queue which might be from ocfs2-devel@oss.oracle.com are queue-5.10/ocfs2-fix-non-auto-defrag-path-not-working-issue.patch queue-5.10/ocfs2-fix-defrag-path-triggering-jbd2-assert.patch _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel