From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: igb PMD should set the default tx wthresh correctly. Date: Fri, 17 Jul 2015 10:15:12 +0200 Message-ID: <1679490.KK3tNg9jEu@xps13> References: <20150716101650.45c0e25a@urahara> <6A0DE07E22DDAD4C9103DF62FEBC0909CFAAE6@shsmsx102.ccr.corp.intel.com> <20150716194920.3710f25e@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Stephen Hemminger , "Lu, Wenzhuo" Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 455706942 for ; Fri, 17 Jul 2015 10:16:24 +0200 (CEST) Received: by wibud3 with SMTP id ud3so33291639wib.1 for ; Fri, 17 Jul 2015 01:16:24 -0700 (PDT) In-Reply-To: <20150716194920.3710f25e@urahara> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-16 19:49, Stephen Hemminger: > On Fri, 17 Jul 2015 00:52:09 +0000 > "Lu, Wenzhuo" wrote: > > > Hi Stephen, > > I don't think there's a conflict. The message just reminder us that we can adjust the values to achieve better performance. > > I saw ixgbe and i40e also use 0 as the same default value. To my opinion, it's good to keep the same behavior. > > Thanks. > > In my opnion, no application should have to make special case setup > for each device type. Having to have a table that lists all the parameters > for each device name is not supportable or scaleable. > > The DPDK started out as "lets do benchmarks fast" but as a production > toolkit it needs to stop having this kind of thing. > > The message shows up to the end-user, who thinks it is a driver bug. > The "us" is now real customers not DPDK developers. +1 to have better default values and less scary messages.