From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com,
thomas@monjalon.net, stephen@networkplumber.org,
mb@smartsharesystems.com,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH v2 4/7] net/ice: replace rte atomics with GCC builtin atomics
Date: Thu, 23 Mar 2023 15:34:38 -0700 [thread overview]
Message-ID: <1679610881-25997-5-git-send-email-roretzla@linux.microsoft.com> (raw)
In-Reply-To: <1679610881-25997-1-git-send-email-roretzla@linux.microsoft.com>
Replace the use of rte_atomic.h types and functions, instead use GCC
supplied C++11 memory model builtins.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
drivers/net/ice/ice_dcf.c | 1 -
drivers/net/ice/ice_dcf_ethdev.c | 1 -
drivers/net/ice/ice_ethdev.c | 12 ++++++++----
3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c
index 1c3d22a..80d2cbd 100644
--- a/drivers/net/ice/ice_dcf.c
+++ b/drivers/net/ice/ice_dcf.c
@@ -14,7 +14,6 @@
#include <rte_common.h>
#include <rte_pci.h>
-#include <rte_atomic.h>
#include <rte_eal.h>
#include <rte_ether.h>
#include <ethdev_driver.h>
diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c
index dcbf2af..13ff245 100644
--- a/drivers/net/ice/ice_dcf_ethdev.c
+++ b/drivers/net/ice/ice_dcf_ethdev.c
@@ -11,7 +11,6 @@
#include <rte_interrupts.h>
#include <rte_debug.h>
#include <rte_pci.h>
-#include <rte_atomic.h>
#include <rte_eal.h>
#include <rte_ether.h>
#include <ethdev_pci.h>
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 9a88cf9..5608f6a 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3927,8 +3927,10 @@ static int ice_init_rss(struct ice_pf *pf)
struct rte_eth_link *dst = link;
struct rte_eth_link *src = &dev->data->dev_link;
- if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
- *(uint64_t *)src) == 0)
+ // NOTE: review for potential ordering optimization
+ if (!__atomic_compare_exchange_n((uint64_t *)dst,
+ (uint64_t *)dst, *(uint64_t *)src, 0,
+ __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST))
return -1;
return 0;
@@ -3941,8 +3943,10 @@ static int ice_init_rss(struct ice_pf *pf)
struct rte_eth_link *dst = &dev->data->dev_link;
struct rte_eth_link *src = link;
- if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
- *(uint64_t *)src) == 0)
+ // NOTE: review for potential ordering optimization
+ if (!__atomic_compare_exchange_n((uint64_t *)dst,
+ (uint64_t *)dst, *(uint64_t *)src, 0,
+ __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST))
return -1;
return 0;
--
1.8.3.1
next prev parent reply other threads:[~2023-03-23 22:35 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 20:19 [PATCH 0/7] replace rte atomics with GCC builtin atomics Tyler Retzlaff
2023-03-17 20:19 ` [PATCH 1/7] ring: " Tyler Retzlaff
2023-03-17 20:36 ` Tyler Retzlaff
2023-03-17 20:19 ` [PATCH 2/7] stack: " Tyler Retzlaff
2023-03-17 20:19 ` [PATCH 3/7] dma/idxd: " Tyler Retzlaff
2023-03-17 20:19 ` [PATCH 4/7] net/ice: " Tyler Retzlaff
2023-03-17 20:41 ` Tyler Retzlaff
2023-03-17 20:19 ` [PATCH 5/7] net/ixgbe: " Tyler Retzlaff
2023-03-17 20:19 ` [PATCH 6/7] net/null: " Tyler Retzlaff
2023-03-17 20:44 ` Tyler Retzlaff
2023-03-17 20:19 ` [PATCH 7/7] net/ring: " Tyler Retzlaff
2023-03-17 21:42 ` [PATCH 0/7] " Stephen Hemminger
2023-03-17 21:49 ` Tyler Retzlaff
2023-03-22 11:28 ` Morten Brørup
2023-03-22 14:21 ` Tyler Retzlaff
2023-03-22 14:58 ` Morten Brørup
2023-03-22 15:29 ` Tyler Retzlaff
2023-03-22 16:13 ` Morten Brørup
2023-03-22 16:40 ` Honnappa Nagarahalli
2023-03-22 17:07 ` Morten Brørup
2023-03-22 17:38 ` Honnappa Nagarahalli
2023-03-22 18:06 ` Tyler Retzlaff
2023-05-02 3:37 ` Tyler Retzlaff
2023-05-02 4:31 ` Honnappa Nagarahalli
2023-03-23 22:34 ` [PATCH v2 " Tyler Retzlaff
2023-03-23 22:34 ` [PATCH v2 1/7] ring: " Tyler Retzlaff
2023-03-23 22:34 ` [PATCH v2 2/7] stack: " Tyler Retzlaff
2023-03-23 22:34 ` [PATCH v2 3/7] dma/idxd: " Tyler Retzlaff
2023-03-23 22:34 ` Tyler Retzlaff [this message]
2023-03-23 22:34 ` [PATCH v2 5/7] net/ixgbe: " Tyler Retzlaff
2023-03-23 22:34 ` [PATCH v2 6/7] net/null: " Tyler Retzlaff
2023-03-23 22:34 ` [PATCH v2 7/7] net/ring: " Tyler Retzlaff
2023-03-24 7:07 ` [PATCH v2 0/7] " Morten Brørup
2023-03-23 22:53 ` [PATCH v3 " Tyler Retzlaff
2023-03-23 22:53 ` [PATCH v3 1/7] ring: " Tyler Retzlaff
2023-03-23 22:53 ` [PATCH v3 2/7] stack: " Tyler Retzlaff
2023-05-24 20:08 ` David Marchand
2023-03-23 22:53 ` [PATCH v3 3/7] dma/idxd: " Tyler Retzlaff
2023-05-24 20:09 ` David Marchand
2023-05-25 8:41 ` Bruce Richardson
2023-05-25 13:59 ` Morten Brørup
2023-05-25 12:57 ` Kevin Laatz
2023-03-23 22:53 ` [PATCH v3 4/7] net/ice: " Tyler Retzlaff
2023-05-24 20:10 ` David Marchand
2023-03-23 22:53 ` [PATCH v3 5/7] net/ixgbe: " Tyler Retzlaff
2023-05-24 20:11 ` David Marchand
2023-03-23 22:53 ` [PATCH v3 6/7] net/null: " Tyler Retzlaff
2023-05-24 20:13 ` David Marchand
2023-03-23 22:53 ` [PATCH v3 7/7] net/ring: " Tyler Retzlaff
2023-05-24 20:12 ` David Marchand
2023-05-25 8:44 ` Bruce Richardson
2023-03-24 7:09 ` [PATCH v3 0/7] " Morten Brørup
2023-03-24 19:22 ` Tyler Retzlaff
2023-05-24 12:40 ` David Marchand
2023-05-24 15:47 ` Tyler Retzlaff
2023-05-24 20:06 ` David Marchand
2023-05-24 22:50 ` Tyler Retzlaff
2023-05-24 22:56 ` Honnappa Nagarahalli
2023-05-25 0:02 ` Tyler Retzlaff
2023-05-25 7:50 ` Morten Brørup
2023-06-02 19:45 ` [PATCH v4 0/6] " Tyler Retzlaff
2023-06-02 19:45 ` [PATCH v4 1/6] stack: " Tyler Retzlaff
2023-06-02 19:45 ` [PATCH v4 2/6] dma/idxd: " Tyler Retzlaff
2023-06-02 19:45 ` [PATCH v4 3/6] net/ice: " Tyler Retzlaff
2023-06-02 19:45 ` [PATCH v4 4/6] net/ixgbe: " Tyler Retzlaff
2023-06-02 19:45 ` [PATCH v4 5/6] net/null: " Tyler Retzlaff
2023-06-02 19:45 ` [PATCH v4 6/6] net/ring: " Tyler Retzlaff
2023-06-05 8:27 ` Olivier Matz
2023-06-06 21:45 ` [PATCH v5 0/6] " Tyler Retzlaff
2023-06-06 21:45 ` [PATCH v5 1/6] stack: " Tyler Retzlaff
2023-06-06 21:45 ` [PATCH v5 2/6] dma/idxd: " Tyler Retzlaff
2023-06-06 21:45 ` [PATCH v5 3/6] net/ice: " Tyler Retzlaff
2023-06-06 21:45 ` [PATCH v5 4/6] net/ixgbe: " Tyler Retzlaff
2023-06-06 21:45 ` [PATCH v5 5/6] net/null: " Tyler Retzlaff
2023-06-06 21:45 ` [PATCH v5 6/6] net/ring: " Tyler Retzlaff
2023-06-09 15:01 ` [PATCH v5 0/6] " David Marchand
2023-06-09 15:13 ` Tyler Retzlaff
2023-06-22 19:59 ` Patrick Robb
2023-06-23 8:53 ` David Marchand
2023-06-23 21:37 ` Tyler Retzlaff
2023-06-28 14:01 ` Patrick Robb
2023-06-28 14:49 ` David Marchand
2023-06-23 21:35 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1679610881-25997-5-git-send-email-roretzla@linux.microsoft.com \
--to=roretzla@linux.microsoft.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.