From: Marek Lindner <mareklindner@neomailbox.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 5/5] batman-adv: Prevent duplicated tvlv handler
Date: Thu, 06 Sep 2018 20:05:33 +0800 [thread overview]
Message-ID: <1682247.b6jU6xIGrp@rousseau> (raw)
In-Reply-To: <20180812190445.28013-6-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
On Monday, 13 August 2018 03:04:45 HKT Sven Eckelmann wrote:
> The function batadv_tvlv_handler_register is responsible for adding new
> tvlv_handler to the handler_list. It first checks whether the entry
> already is in the list or not. If it is, then the creation of a new entry
> is aborted.
>
> But the lock for the list is only held when the list is really modified.
> This could lead to duplicated entries because another context could create
> an entry with the same key between the check and the list manipulation.
>
> The check and the manipulation of the list must therefore be in the same
> locked code section.
>
> Fixes: 0b6aa0d43767 ("batman-adv: tvlv - basic infrastructure")
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
Acked-by: Marek Lindner <mareklindner@neomailbox.ch>
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
prev parent reply other threads:[~2018-09-06 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-12 19:04 [B.A.T.M.A.N.] [PATCH 0/5] batman-adv: Missing list checks for *list_add* Sven Eckelmann
2018-08-12 19:04 ` [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: Prevent duplicated gateway_node entry Sven Eckelmann
2018-09-06 11:41 ` Marek Lindner
2018-08-12 19:04 ` [B.A.T.M.A.N.] [PATCH 2/5] batman-adv: Prevent duplicated nc_node entry Sven Eckelmann
2018-09-06 11:45 ` Marek Lindner
2018-08-12 19:04 ` [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: Prevent duplicated softif_vlan entry Sven Eckelmann
2018-09-06 12:00 ` Marek Lindner
2018-08-12 19:04 ` [B.A.T.M.A.N.] [PATCH 4/5] batman-adv: Prevent duplicated global TT entry Sven Eckelmann
2018-09-06 12:03 ` Marek Lindner
2018-08-12 19:04 ` [B.A.T.M.A.N.] [PATCH 5/5] batman-adv: Prevent duplicated tvlv handler Sven Eckelmann
2018-09-06 12:05 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1682247.b6jU6xIGrp@rousseau \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.