All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH-maintv2] batman-adv: replace WARN with rate limited output on non-existing VLAN
Date: Tue, 17 May 2016 17:12:33 +0800	[thread overview]
Message-ID: <16831453.6LvDVGI860@voltaire> (raw)
In-Reply-To: <1463071923-27298-1-git-send-email-sw@simonwunderlich.de>

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

On Thursday, May 12, 2016 18:52:03 Simon Wunderlich wrote:
> If a VLAN tagged frame is received and the corresponding VLAN is not
> configured on the soft interface, it will splat a WARN on every packet
> received. This is a quite annoying behaviour for some scenarios, e.g. if
> bat0 is bridged with eth0, and there are arbitrary VLAN tagged frames
> from Ethernet coming in without having any VLAN configuration on bat0.
> 
> The code should probably create vlan objects on the fly and
> transparently transport these VLAN-tagged Ethernet frames, but until
> this is done, at least the WARN splat should be replaced by a rate
> limited output.
> 
> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
> ---
> Changes to PATCH-maint:
>  * added newline to output
> ---
>  net/batman-adv/translation-table.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied in revision 0479211.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-05-17  9:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12 16:52 [B.A.T.M.A.N.] [PATCH-maintv2] batman-adv: replace WARN with rate limited output on non-existing VLAN Simon Wunderlich
2016-05-17  9:12 ` Marek Lindner [this message]
2016-05-20 10:05 ` [B.A.T.M.A.N.] Antwort: " Andreas Pape
2016-05-20 10:34   ` Simon Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16831453.6LvDVGI860@voltaire \
    --to=mareklindner@neomailbox.ch \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.