From: David Howells <dhowells@cambridge.redhat.com>
To: Andreas Franck <afranck@gmx.de>
Cc: David Howells <dhowells@cambridge.redhat.com>,
torvalds@transmeta.com, andrewm@uow.edu.au, bcrl@redhat.com,
alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2nd try: i386 rw_semaphores fix
Date: Wed, 11 Apr 2001 15:43:48 +0100 [thread overview]
Message-ID: <16847.987000228@warthog.cambridge.redhat.com> (raw)
In-Reply-To: Your message of "Wed, 11 Apr 2001 16:32:25 +0200." <1098.986999545@www17.gmx.net>
I've been discussing it with some other kernel and GCC people, and they think
that only "memory" is required.
> What are the reasons against mentioning sem->count directly as a "=m"
> reference? This makes the whole thing less fragile and no more dependent
> on the memory layout of the structure.
Apart from the risk of breaking it, you mean? Well, "=m" seems to reserve an
extra register to hold a second copy of the semaphore address, probably since
it thinks EAX might get clobbered.
Also, as a minor point, it probably ought to be "+m" not "=m".
David
next prev parent reply other threads:[~2001-04-11 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3AD45EC5.81EB82AD@akustik.rwth-aachen.de>
2001-04-11 14:17 ` [PATCH] 2nd try: i386 rw_semaphores fix David Howells
2001-04-11 14:32 ` Andreas Franck
2001-04-11 14:43 ` David Howells [this message]
2001-04-11 15:00 ` Andreas Franck
2001-04-11 15:14 ` Bernd Schmidt
2001-04-11 18:27 ` Linus Torvalds
2001-04-12 8:38 ` Jamie Lokier
2001-04-10 19:42 [PATCH] " Linus Torvalds
2001-04-11 12:57 ` [PATCH] 2nd try: " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16847.987000228@warthog.cambridge.redhat.com \
--to=dhowells@cambridge.redhat.com \
--cc=afranck@gmx.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andrewm@uow.edu.au \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.