diff for duplicates of <1686227.ptHs0ZEO6U@townsend> diff --git a/a/1.txt b/N1/1.txt index fa33223..beeea1d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -18,7 +18,7 @@ I guess currently it wont make any practical difference as we only ever have 2 NPUs, but in future they may get divided into more logical NPUs. Would it be possible to store a back-pointer somewhere so we can avoid the lookup? -> + if (hose = npu->hose) +> + if (hose == npu->hose) > + return npu; > > - return &nphb->npu; @@ -65,7 +65,8 @@ possible to store a back-pointer somewhere so we can avoid the lookup? > + struct npu *npu; > + int ret; > -> - phb->npu.nmmu_flush > - of_property_read_bool(phb->hose->dn, "ibm,nmmu-flush"); +> - phb->npu.nmmu_flush = +> - of_property_read_bool(phb->hose->dn, "ibm,nmmu-flush"); > + npu = kzalloc(sizeof(*npu), GFP_KERNEL); > + if (!npu) > + return -ENOMEM; diff --git a/a/content_digest b/N1/content_digest index 6ed2762..02825f5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020181113082823.2440-7-aik@ozlabs.ru\0" "From\0Alistair Popple <alistair@popple.id.au>\0" "Subject\0Re: [PATCH kernel v3 06/22] powerpc/powernv: Detach npu struct from pnv_phb\0" - "Date\0Wed, 14 Nov 2018 04:28:36 +0000\0" + "Date\0Wed, 14 Nov 2018 15:28:36 +1100\0" "To\0Alexey Kardashevskiy <aik@ozlabs.ru>\0" "Cc\0Jose Ricardo Ziviani <joserz@linux.ibm.com>" Sam Bobroff <sbobroff@linux.ibm.com> @@ -37,7 +37,7 @@ "NPUs, but in future they may get divided into more logical NPUs. Would it be \n" "possible to store a back-pointer somewhere so we can avoid the lookup?\n" "\n" - "> +\t\tif (hose = npu->hose)\n" + "> +\t\tif (hose == npu->hose)\n" "> +\t\t\treturn npu;\n" "> \n" "> -\treturn &nphb->npu;\n" @@ -84,7 +84,8 @@ "> +\tstruct npu *npu;\n" "> +\tint ret;\n" "> \n" - "> -\tphb->npu.nmmu_flush > -\t\tof_property_read_bool(phb->hose->dn, \"ibm,nmmu-flush\");\n" + "> -\tphb->npu.nmmu_flush =\n" + "> -\t\tof_property_read_bool(phb->hose->dn, \"ibm,nmmu-flush\");\n" "> +\tnpu = kzalloc(sizeof(*npu), GFP_KERNEL);\n" "> +\tif (!npu)\n" "> +\t\treturn -ENOMEM;\n" @@ -139,4 +140,4 @@ "> +\treturn ret;\n" > } -86657267f389ef4dcc72bc7524796a666d60fcc97d2c5688d204e20de43f0ab0 +3be6c750a30cbbe19311b2c51f2d0a5d18d3b118d5e3c84208dc58101c0e9c2a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.