From: patchwork-bot+netdevbpf@kernel.org
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzkaller@googlegroups.com, stephen@networkplumber.org,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH net] sch_netem: acquire qdisc lock in netem_change()
Date: Thu, 22 Jun 2023 09:20:20 +0000 [thread overview]
Message-ID: <168742562084.21100.5779776053254524891.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230620184425.1179809-1-edumazet@google.com>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 20 Jun 2023 18:44:25 +0000 you wrote:
> syzbot managed to trigger a divide error [1] in netem.
>
> It could happen if q->rate changes while netem_enqueue()
> is running, since q->rate is read twice.
>
> It turns out netem_change() always lacked proper synchronization.
>
> [...]
Here is the summary with links:
- [net] sch_netem: acquire qdisc lock in netem_change()
https://git.kernel.org/netdev/net/c/2174a08db80d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2023-06-22 9:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 18:44 [PATCH net] sch_netem: acquire qdisc lock in netem_change() Eric Dumazet
2023-06-21 11:21 ` Jamal Hadi Salim
2023-06-21 14:51 ` Simon Horman
2023-06-22 9:20 ` patchwork-bot+netdevbpf [this message]
2023-06-22 16:31 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168742562084.21100.5779776053254524891.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
--cc=syzkaller@googlegroups.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.