From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC14FEB64DA for ; Sat, 24 Jun 2023 22:50:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Date: Message-Id:From:Subject:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VrMEaY1d9Fzid4tkRXWF0TF78Ya73FJlU3KNst1Gqrs=; b=j3OD0Gvx6hAEHQ 9ra1EjyjRdgmbE8NdaG/hcs3TrM74fpIx2lTl9F4PPLUxBWky7JwSSO9K0llDnJWRvLP6lRlqlZh/ 2ntRI1xblfydZNaT5jQMl9F7dN+Fz20UncVSN2MAEbhCPYmSriYDzy2XGXVrjPjRfNkzwW/9kv7lH 6BDzFRxEoF6VirrxMXRAzBF9scF19W6VgvBS7M0pVBwS9FEK3bYx3ktQ2MAG07t2SLQHyGcn+ZbgG qRw6+OsHkGwk5Ir89O5BVmH543rSB0RfvrfeipJkgB6WLoyBNkV63V79VMiLWdmqifYrfXNN/wyMM rKuOgeVN16LfnSYX30iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qDC5L-006m5J-19; Sat, 24 Jun 2023 22:50:27 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qDC5I-006m4P-1P for linux-arm-kernel@lists.infradead.org; Sat, 24 Jun 2023 22:50:25 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 873DB60AEA; Sat, 24 Jun 2023 22:50:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id C74B6C433CA; Sat, 24 Jun 2023 22:50:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687647019; bh=2Y09zlKyxywwYAR9+6Vy7iCEpg2/BpmZwNMcFlJpIqM=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=aPobRqeu61zPyQKu//ZTY+7Eby3yN9TuR4lov35E1LA8NbXrXMf0jm1OlsOHNSFIJ SQ/Qm7u667JuMVnraKnT/iz0s1dGUauJTI9f45Q0CHwOJtISDlvOc1DFxYpcSyDEs3 qmd8R+bk3e01DuUgcS/8aL/+XIL68DhnaHGFjcUTAeoPcLse917Tu/+GV2xu+HErDJ NwvAPFLXU9A6Mc83p/tBKysiGQr3lu49LZuI7bG9MBJ2ZwWObBCszkhYXmJO9bWDvg rPcDkhJtho3IsH1er8IU1OoExuiWwxxr1JkZId6/iSR2AP5GBVpszC0VM/EojWsyO0 bjmM2zoHoWDww== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id AB256C395F1; Sat, 24 Jun 2023 22:50:19 +0000 (UTC) MIME-Version: 1.0 Subject: Re: [PATCH v4 1/1] net: axienet: Move reset before 64-bit DMA detection From: patchwork-bot+netdevbpf@kernel.org Message-Id: <168764701969.4822.7421047378744146603.git-patchwork-notify@kernel.org> Date: Sat, 24 Jun 2023 22:50:19 +0000 References: <20230622192245.116864-1-fido_max@inbox.ru> In-Reply-To: <20230622192245.116864-1-fido_max@inbox.ru> To: Maxim Kochetkov Cc: netdev@vger.kernel.org, robert.hancock@calian.com, radhey.shyam.pandey@amd.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, michal.simek@amd.com, andre.przywara@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230624_155024_522170_44604311 X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Thu, 22 Jun 2023 22:22:45 +0300 you wrote: > 64-bit DMA detection will fail if axienet was started before (by boot > loader, boot ROM, etc). In this state axienet will not start properly. > XAXIDMA_TX_CDESC_OFFSET + 4 register (MM2S_CURDESC_MSB) is used to detect > 64-bit DMA capability here. But datasheet says: When DMACR.RS is 1 > (axienet is in enabled state), CURDESC_PTR becomes Read Only (RO) and > is used to fetch the first descriptor. So iowrite32()/ioread32() trick > to this register to detect 64-bit DMA will not work. > So move axienet reset before 64-bit DMA detection. > > [...] Here is the summary with links: - [v4,1/1] net: axienet: Move reset before 64-bit DMA detection https://git.kernel.org/netdev/net/c/f1bc9fc4a06d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A196EB64DA for ; Sat, 24 Jun 2023 22:50:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbjFXWu2 (ORCPT ); Sat, 24 Jun 2023 18:50:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjFXWu0 (ORCPT ); Sat, 24 Jun 2023 18:50:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E15A51715 for ; Sat, 24 Jun 2023 15:50:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 741B960AE3 for ; Sat, 24 Jun 2023 22:50:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id C74B6C433CA; Sat, 24 Jun 2023 22:50:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687647019; bh=2Y09zlKyxywwYAR9+6Vy7iCEpg2/BpmZwNMcFlJpIqM=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=aPobRqeu61zPyQKu//ZTY+7Eby3yN9TuR4lov35E1LA8NbXrXMf0jm1OlsOHNSFIJ SQ/Qm7u667JuMVnraKnT/iz0s1dGUauJTI9f45Q0CHwOJtISDlvOc1DFxYpcSyDEs3 qmd8R+bk3e01DuUgcS/8aL/+XIL68DhnaHGFjcUTAeoPcLse917Tu/+GV2xu+HErDJ NwvAPFLXU9A6Mc83p/tBKysiGQr3lu49LZuI7bG9MBJ2ZwWObBCszkhYXmJO9bWDvg rPcDkhJtho3IsH1er8IU1OoExuiWwxxr1JkZId6/iSR2AP5GBVpszC0VM/EojWsyO0 bjmM2zoHoWDww== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id AB256C395F1; Sat, 24 Jun 2023 22:50:19 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v4 1/1] net: axienet: Move reset before 64-bit DMA detection From: patchwork-bot+netdevbpf@kernel.org Message-Id: <168764701969.4822.7421047378744146603.git-patchwork-notify@kernel.org> Date: Sat, 24 Jun 2023 22:50:19 +0000 References: <20230622192245.116864-1-fido_max@inbox.ru> In-Reply-To: <20230622192245.116864-1-fido_max@inbox.ru> To: Maxim Kochetkov Cc: netdev@vger.kernel.org, robert.hancock@calian.com, radhey.shyam.pandey@amd.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, michal.simek@amd.com, andre.przywara@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Thu, 22 Jun 2023 22:22:45 +0300 you wrote: > 64-bit DMA detection will fail if axienet was started before (by boot > loader, boot ROM, etc). In this state axienet will not start properly. > XAXIDMA_TX_CDESC_OFFSET + 4 register (MM2S_CURDESC_MSB) is used to detect > 64-bit DMA capability here. But datasheet says: When DMACR.RS is 1 > (axienet is in enabled state), CURDESC_PTR becomes Read Only (RO) and > is used to fetch the first descriptor. So iowrite32()/ioread32() trick > to this register to detect 64-bit DMA will not work. > So move axienet reset before 64-bit DMA detection. > > [...] Here is the summary with links: - [v4,1/1] net: axienet: Move reset before 64-bit DMA detection https://git.kernel.org/netdev/net/c/f1bc9fc4a06d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html