From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F0AEB64D9 for ; Thu, 29 Jun 2023 10:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232406AbjF2KDl (ORCPT ); Thu, 29 Jun 2023 06:03:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232456AbjF2KBk (ORCPT ); Thu, 29 Jun 2023 06:01:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 761B73582; Thu, 29 Jun 2023 03:00:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1369D6150C; Thu, 29 Jun 2023 10:00:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 5E0E1C433C9; Thu, 29 Jun 2023 10:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688032821; bh=6BSYODeXAvBc1bYzqyJYg+UUhE64/mpp9Tu40F5CwoU=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=oDHVOrr/5JM70o8y0DmxBWIVGGiaWWXfzS94TATG7gX18UJiEXtcnfnbjgS14itYd RjDupaiQALNLc4zEyV9ElOhba0fYXYHoDfJ8tZlsfgOg1DJaaeZZK48ThBknPuQxOc /7gEQdxojynYXj5ZWNDMbsuGzHRw6KBoX5a+8Wna1pZuuPXLPuKXxMndlqBCyoRav7 mGuQVJGE6lMiPKEWQdF9qjiHgVRjXoivbJ/ASo3o5t76qKE40VFbLNBe5mw9QHMw4u 5oN9H5Ihhy4pdzSmD/s49gZuNXWuInDrpEWATZHph7ul1/wK8ZNnhRUc3KEzn2s27h gp9+ZfzIrhcnA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 40A04C395D8; Thu, 29 Jun 2023 10:00:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] sctp: fix potential deadlock on &net->sctp.addr_wq_lock From: patchwork-bot+netdevbpf@kernel.org Message-Id: <168803282125.4865.3870530612120862542.git-patchwork-notify@kernel.org> Date: Thu, 29 Jun 2023 10:00:21 +0000 References: <20230627120340.19432-1-dg573847474@gmail.com> In-Reply-To: <20230627120340.19432-1-dg573847474@gmail.com> To: Chengfeng Ye Cc: marcelo.leitner@gmail.com, lucien.xin@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sctp@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Tue, 27 Jun 2023 12:03:40 +0000 you wrote: > As &net->sctp.addr_wq_lock is also acquired by the timer > sctp_addr_wq_timeout_handler() in protocal.c, the same lock acquisition > at sctp_auto_asconf_init() seems should disable irq since it is called > from sctp_accept() under process context. > > Possible deadlock scenario: > sctp_accept() > -> sctp_sock_migrate() > -> sctp_auto_asconf_init() > -> spin_lock(&net->sctp.addr_wq_lock) > > -> sctp_addr_wq_timeout_handler() > -> spin_lock_bh(&net->sctp.addr_wq_lock); (deadlock here) > > [...] Here is the summary with links: - sctp: fix potential deadlock on &net->sctp.addr_wq_lock https://git.kernel.org/netdev/net/c/6feb37b3b06e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html