Re: [PATCH] pci: limit default numa node to used devices

[Thomas Monjalon <thomas@monjalon.net>]

The title and the text below should explain that you move
the warning log from scan to probe, thanks to a temporary
negative value.

21/07/2017 12:11, Sergio Gonzalez Monroy:
> Commit 8a04cb612589 ("pci: set default numa node for broken systems")
> added logic to default to NUMA node 0 when sysfs numa_node information
> was wrong or not available.
> 
> Unfortunately there are many devices with wrong NUMA node information
> that DPDK does not care about but still show warnings for them.
> 
> Instead, only check for invalid NUMA node information for devices
> managed by the DPDK.
> 
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
[...]
> -	if (eal_parse_sysfs_value(filename, &tmp) == 0 &&
> -		tmp < RTE_MAX_NUMA_NODES)
> +	if (eal_parse_sysfs_value(filename, &tmp) == 0)
>  		dev->device.numa_node = tmp;

Why are you removing the check of the value?
Are you going to accept invalid high values?
This check was introduced on purpose by this commit:
	http://dpdk.org/commit/8a04cb6125