From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org, "Kinsella, Ray" <mdr@ashroe.eu>
Cc: david.marchand@redhat.com, bruce.richardson@intel.com,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: adjust verbosity of ABI check
Date: Tue, 08 Dec 2020 16:32:40 +0100 [thread overview]
Message-ID: <1689676.9eEyGTFzmW@thomas> (raw)
In-Reply-To: <477b7775-0a3e-080b-3158-bc8fbae95c81@ashroe.eu>
08/12/2020 16:22, Kinsella, Ray:
>
> On 07/12/2020 17:32, Thomas Monjalon wrote:
> > The scripts gen-abi.sh and check-abi.sh are updated
> > to print error messages to stderr so they are likely never ignored.
> >
> > When called from test-meson-builds.sh, the standard messages on stdout
> > can be more quiet depending on the verbosity settings.
> > The beginning of the ABI check is announced in verbose mode.
> > The commands are printed in very verbose mode.
> > The check result details are available in verbose mode.
>
> So there is a bit of a disconnect here - you change gen-abi/check-abi to
> correctly direct errors to sterr.
>
> You then however provide a method to ignore them in test_meson_build.sh.
> I thinking giving people a way of ignoring the indicated lines below,
> is a bad plan.
>
> No problem with the changes to check-abi/gen-abi - but I think the changes
> to test_meson_build.sh are a bad idea.
No the errors are not ignored.
Only stdout (report details) is redirected.
> > $srcdir/devtools/check-abi.sh $abirefdir/$targetdir \
> > - $(readlink -f $builds_dir/$targetdir/install)
> > + $(readlink -f $builds_dir/$targetdir/install) >&$verbose
next prev parent reply other threads:[~2020-12-08 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 17:32 [dpdk-dev] [PATCH 1/1] devtools: adjust verbosity of ABI check Thomas Monjalon
2020-12-08 15:22 ` Kinsella, Ray
2020-12-08 15:32 ` Thomas Monjalon [this message]
2020-12-08 15:31 ` David Marchand
2020-12-17 9:05 ` [dpdk-dev] [PATCH v2 " Thomas Monjalon
2021-01-13 9:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1689676.9eEyGTFzmW@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.