All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv4] batctl: Use netlink to replace some of debugfs
Date: Mon, 09 May 2016 18:28:29 +0200	[thread overview]
Message-ID: <1689798.ZJlLjAlgFP@bentobox> (raw)
In-Reply-To: <1462372207-28322-1-git-send-email-andrew@lunn.ch>

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

On Wednesday 04 May 2016 16:30:07 Andrew Lunn wrote:
> +       [BATADV_ATTR_THROUGHPUT]        = { .type = NLA_FLAG },

Why is throughput a flag when you access it with 

    throughput_kbits = nla_get_u32(attrs[BATADV_ATTR_THROUGHPUT]);

Most likely just a copy+paste error and it should be NLA_U32.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-05-09 16:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04 14:30 [B.A.T.M.A.N.] [PATCHv4] batctl: Use netlink to replace some of debugfs Andrew Lunn
2016-05-09 13:33 ` Sven Eckelmann
2016-05-09 14:23   ` Andrew Lunn
2016-05-09 16:28 ` Sven Eckelmann [this message]
2016-05-09 16:51   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1689798.ZJlLjAlgFP@bentobox \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.