From: Christian Lamparter <chunkeey@googlemail.com>
To: Florian Westphal <fw@strlen.de>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH next] drivers: wireless: carl9170: shrink carl9170_tx_info
Date: Sat, 14 Mar 2015 12:51:57 +0100 [thread overview]
Message-ID: <1689955.Ikz24aORLX@debian64> (raw)
In-Reply-To: <1426261045-22373-1-git-send-email-fw@strlen.de>
On Friday, March 13, 2015 04:37:25 PM Florian Westphal wrote:
> its embededded inside rate_driver_data of the ieee80211_tx_info struct,
> which in turn is stored in skb->cb[].
>
> In order to shrink cb, we need to shrink ieee80211_tx_info which means
> to downsize all users first.
>
> Alternatively, one might be able to remove kref but
> its less intrusive/simpler to use u32 for timeout handling.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
u32 jiffies... that's a lot of pointing (well not so much) and really
ugly casting (a lot). I guess it would be easier to just use a "per-queue"
timeout watchdog like almost everybody else. This way, the driver will
be ready for the next skb->cb shrink as well.
carl9170_tx_ampdu_timeout can be completely removed.
Regards,
Christian
next prev parent reply other threads:[~2015-03-14 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 15:37 [PATCH next] drivers: wireless: carl9170: shrink carl9170_tx_info Florian Westphal
2015-03-14 11:51 ` Christian Lamparter [this message]
2015-03-14 17:55 ` Florian Westphal
2015-03-14 17:55 ` Florian Westphal
2015-03-15 17:17 ` Christian Lamparter
2015-03-15 17:17 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1689955.Ikz24aORLX@debian64 \
--to=chunkeey@googlemail.com \
--cc=fw@strlen.de \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.