From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FB49C0015E for ; Thu, 27 Jul 2023 08:20:27 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id D109679083 for ; Thu, 27 Jul 2023 08:20:26 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id AE30B9866CF for ; Thu, 27 Jul 2023 08:20:26 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 974F89866C5; Thu, 27 Jul 2023 08:20:26 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id E5D409866C6 for ; Thu, 27 Jul 2023 08:19:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R221e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VoK11FV_1690445991; Message-ID: <1690445274.7622454-1-xuanzhuo@linux.alibaba.com> Date: Thu, 27 Jul 2023 16:07:54 +0800 From: Xuan Zhuo To: Jason Wang Cc: "Zhu, Lingshan" , "virtio-comment@lists.oasis-open.org" , "Michael S. Tsirkin" , Parav Pandit , Washizu Yui References: <1687243466.51691-1-xuanzhuo@linux.alibaba.com> <1688104464.531018-1-xuanzhuo@linux.alibaba.com> <1688111214.8488657-2-xuanzhuo@linux.alibaba.com> <1688111784.0426908-3-xuanzhuo@linux.alibaba.com> <7ab5978d-c503-c279-a42e-bcdbf40184d4@intel.com> <1688116457.7400494-4-xuanzhuo@linux.alibaba.com> <259c7b04-58df-8085-755f-a36993556a89@intel.com> <2e176f24-293b-5be0-2928-e8ce0300e75a@intel.com> <1690425015.0990853-1-xuanzhuo@linux.alibaba.com> <52fa9d57-c21a-0235-b8bb-614e88e25f17@intel.com> <1690438140.7109714-2-xuanzhuo@linux.alibaba.com> <3f3b3a17-8199-8830-af22-94686feac956@intel.com> <1690438807.4627175-3-xuanzhuo@linux.alibaba.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [virtio-comment] About the plan of Admin Queue On Thu, 27 Jul 2023 16:03:56 +0800, Jason Wang wrote: > On Thu, Jul 27, 2023 at 2:23=E2=80=AFPM Xuan Zhuo wrote: > > > > On Thu, 27 Jul 2023 14:17:53 +0800, "Zhu, Lingshan" wrote: > > > > > > > > > On 7/27/2023 2:09 PM, Xuan Zhuo wrote: > > > > On Thu, 27 Jul 2023 11:56:32 +0800, "Zhu, Lingshan" wrote: > > > >> > > > >> On 7/27/2023 10:30 AM, Xuan Zhuo wrote: > > > >>> On Mon, 3 Jul 2023 12:29:32 +0800, "Zhu, Lingshan" wrote: > > > >>>> On 6/30/2023 7:35 PM, Parav Pandit wrote: > > > >>>>>> From: virtio-comment@lists.oasis-open.org > > >>>>>> open.org> On Behalf Of Zhu, Lingshan > > > >>>>>> Sent: Friday, June 30, 2023 6:33 AM > > > >>>>>> > > > >>>>>>>>> Can we let the DPU notify the driver to create a new device= r from the > > > >>>>>> backend? > > > >>>>> Yes, why not. > > > >>>>> > > > >>>>>>>>> The key point is who want to create a new device. > > > >>>>>>>> DPU can come with a certain number of pre-created ADIs, just= make > > > >>>>>>>> sure the orchestration SW is aware of their device IDs. > > > >>>>>>>> > > > >>>>> Cloud often need these devices to be created dynamically, many = a time after the host OS is booted. > > > >>>>> To be more generic, those devices to be created and connected t= o the host regardless of the life cycle of the host. > > > >>>>> Xuan partly explained it. > > > >>>>> > > > >>>>>>>> If you want the DPU randomly create ADIs and notify the driv= er, I > > > >>>>>>>> think we need interrupt, e.g., re-use config interrupt. But = why DPU > > > >>>>>>>> wants to create and hot plug in a device to a guest? > > > >>>>>>>> Shall the host handle that or DPU pre-create then expose to = baremteal > > > >>>>>>>> machines? > > > >>>>>>> In your scenario, the supervisor is on the os, which controls= the DPU > > > >>>>>>> to create new devices. > > > >>>>>>> > > > >>>>>>> In the cloud scenario, the vendor manager is in the DPU, and = the > > > >>>>>>> entire host is for users. Of course, there are situations whe= re the > > > >>>>>>> vendor manager are in the HOST. But for bare metal machines, = the host > > > >>>>>>> belongs to the customer, the vendor manager is only in the DP= U. > > > >>>>>>> > > > >>>>>>> So when the customers buy a new nic for the host, the vendor = manager > > > >>>>>>> will plug a device to the host from the DPU. > > > >>>>>> I understand once a customer orders a new NIC, you wants to pr= esent the NIC > > > >>>>>> to the host. > > > >>>>>> However you only owns the DPU and the customer owns the host, = that means > > > >>>>>> this creation and hot plug must be transparent to the host and= there may not be > > > >>>>>> a host driver help handling an interrupt/probe. > > > >>>>>> > > > >>>>> That is ok. when driver is loaded, it would query about its chi= ld devices and probe it, if we strictly want to follow SIOV model. > > > >>>>> > > > >>>>>> However this is not PCI which has a tree/switch and can enumer= ate devices to > > > >>>>>> the host by spanning the device across the PCI hierarchy. > > > >>>>>> > > > >>>>> Those enumeration is triggered by the parent PCI device and pci= bridge and switch will also discover it. > > > >>>>> > > > >>>>>> To address an ADI, there is only a device_id. > > > >>>>>> > > > >>>>> SIOV device must have a unique identifier at PCI bus level for = sure. > > > >>>>> I cannot speak more about it in this forum due to other logisti= cs issue. > > > >>>>> But assume that there is PCI level unique identifier for SIOV d= evice that switches on the path will learn about. > > > >>>>> > > > >>>>>> So, do you mind share how your DPU offload the device model? W= hat kind of > > > >>>>>> device your DPU provide to the host? Lets see whether DPU can = mediate this by > > > >>>>>> its own? > > > >>>>>> > > > >>>>> It is a virtio nic, blk and other virtio devices for us. > > > >>>>> A DPU hotplugs a device, host side either gets interrupt or lat= er gets to know about it when explicitly queries. > > > >>>>> There is no mediation per say here, it is just a dpu based SIOV= device like a regular PF. > > > >>>>> > > > >>>>> For non virtio DPU device, I implemented them in Linux for dpus= 2 years ago. > > > >>>>> You might find a Linux reference model useful at [1]. > > > >>>>> A usage model already exists in one OS and in use for non virti= o devices. > > > >>>>> This certainly works without SIOV unique PCI device identifiers= , because DPU (non-host) managed SIOV device spec still does not exist. > > > >>>>> > > > >>>>> For virtio, I think we should wait for this piece to be defined= and leverage that, instead of virtio tc creating its own. > > > >>>>> > > > >>>>> [1] https://github.com/Mellanox/scalablefunctions/wiki > > > >>>> well I see SF facing the similar challenge, I can add a command = for the > > > >>>> driver to query all existing SIOV ADIs of a device, > > > >>>> and the device return ADIs id and status. Looks good? and work f= or you > > > >>>> @Xuan? > > > >>> Could I have your plan for this? > > > >>> > > > >>> If you do not mind, I'd like to add a command to query VF's info.= Such > > > >>> as mac, ip, etc. > > > >> I think the query commands for SIOV is a little more complex, e.g., > > > >> need to report device type and its scale(e.g., features, mq). > > > >> There can be thousands of SIOV ADIs and we don't want output flood. > > > >> > > > >> We have discussed implementation a config interrupt to report new > > > >> created / deleted > > > >> ADIs on the DPU side, therefore there must be a cap contains relat= ed > > > >> information, > > > >> my rough approach of the process is: > > > >> 1) a cap contains the total number of existing ADIs and the max de= v id > > > >> 2) driver queries detailed information of a certain ADI or a bunch= of > > > >> ADIs in a [dev_id....dev_id2] range. > > > > Yes, Admin Queue can obtain the info of the specific one or more de= vices. > > > > > > > >> I am not sure whether a NIC stores its IP > > > > > > > > IP is the other topic. I want the Admin Queue manage the switch. > > > > So the switch know about the IP of every device, and the > > > > Admin Queue will has the ability to config the IP of the device ins= ide the > > > > switch. > > > DPU onboard switch? OVS? Does it beyond virtio spec? > > > > YES. > > Adding Washizu. > > We can have a switch/dpa defined in the networking device for sure. Yes, I think we should introduce that for the sr-iov. Or for other. I would like to know who is doing this? Another question, @Jason are you referring to a new device type or a new virtio-net feature. > > > > > For SIOV, I think this is MUST. > > A learning bridge would be fine as a starter. It's better not to > couple new scalable capability with any device specific features. > > > Maybe you have one simple implementation. > > But you have to solve the IP steering. So admin queue should has the ab= ility > > to config the IP steering. > > I think not. Those L2/LN tables/filters are networking specific. Let us assume that there is a switch/bridge firstly. The VFs may be passed to different VMs. I also think this is the networking specific. But I want to config the ip for every vf from the pf. Because the user of the vf may be unreliab= le. We need a manager to config the ip for every vf. > Control virtqueue is better than admin virtqueue here. by cq? What case? Thanks. > > Thanks > > > > > Thanks. > > > > > > > > > > > > > > Thanks. > > > > > > > > > > > >> Thanks > > > >>> Thanks. > > > >>> > > > >>> > > > >>> > > > >>>> Thanks > > > >>>> > > > >>> This publicly archived list offers a means to provide input to the > > > >>> OASIS Virtual I/O Device (VIRTIO) TC. > > > >>> > > > >>> In order to verify user consent to the Feedback License terms and > > > >>> to minimize spam in the list archive, subscription is required > > > >>> before posting. > > > >>> > > > >>> Subscribe: virtio-comment-subscribe@lists.oasis-open.org > > > >>> Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > > > >>> List help: virtio-comment-help@lists.oasis-open.org > > > >>> List archive: https://lists.oasis-open.org/archives/virtio-commen= t/ > > > >>> Feedback License: https://www.oasis-open.org/who/ipr/feedback_lic= ense.pdf > > > >>> List Guidelines: https://www.oasis-open.org/policies-guidelines/m= ailing-lists > > > >>> Committee: https://www.oasis-open.org/committees/virtio/ > > > >>> Join OASIS: https://www.oasis-open.org/join/ > > > >>> > > > > > > > > > This publicly archived list offers a means to provide input to the > > > OASIS Virtual I/O Device (VIRTIO) TC. > > > > > > In order to verify user consent to the Feedback License terms and > > > to minimize spam in the list archive, subscription is required > > > before posting. > > > > > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org > > > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > > > List help: virtio-comment-help@lists.oasis-open.org > > > List archive: https://lists.oasis-open.org/archives/virtio-comment/ > > > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license= .pdf > > > List Guidelines: https://www.oasis-open.org/policies-guidelines/maili= ng-lists > > > Committee: https://www.oasis-open.org/committees/virtio/ > > > Join OASIS: https://www.oasis-open.org/join/ > > > > > > > This publicly archived list offers a means to provide input to the > > OASIS Virtual I/O Device (VIRTIO) TC. > > > > In order to verify user consent to the Feedback License terms and > > to minimize spam in the list archive, subscription is required > > before posting. > > > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org > > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > > List help: virtio-comment-help@lists.oasis-open.org > > List archive: https://lists.oasis-open.org/archives/virtio-comment/ > > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.p= df > > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing= -lists > > Committee: https://www.oasis-open.org/committees/virtio/ > > Join OASIS: https://www.oasis-open.org/join/ > > > This publicly archived list offers a means to provide input to the=0D OASIS Virtual I/O Device (VIRTIO) TC.=0D =0D In order to verify user consent to the Feedback License terms and=0D to minimize spam in the list archive, subscription is required=0D before posting.=0D =0D Subscribe: virtio-comment-subscribe@lists.oasis-open.org=0D Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org=0D List help: virtio-comment-help@lists.oasis-open.org=0D List archive: https://lists.oasis-open.org/archives/virtio-comment/=0D Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf=0D List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists=0D Committee: https://www.oasis-open.org/committees/virtio/=0D Join OASIS: https://www.oasis-open.org/join/