All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: YiFei Zhu <zhuyifei@google.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
	sdf@google.com, martin.lau@linux.dev, andrii@kernel.org,
	houtao@huaweicloud.com, yonghong.song@linux.dev
Subject: Re: [PATCH v3 bpf-next] bpf/memalloc: Non-atomically allocate freelist during prefill
Date: Fri, 28 Jul 2023 16:50:21 +0000	[thread overview]
Message-ID: <169056302111.15046.9436134761640107327.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230728043359.3324347-1-zhuyifei@google.com>

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Fri, 28 Jul 2023 04:33:59 +0000 you wrote:
> In internal testing of test_maps, we sometimes observed failures like:
>   test_maps: test_maps.c:173: void test_hashmap_percpu(unsigned int, void *):
>     Assertion `bpf_map_update_elem(fd, &key, value, BPF_ANY) == 0' failed.
> where the errno is ENOMEM. After some troubleshooting and enabling
> the warnings, we saw:
>   [   91.304708] percpu: allocation failed, size=8 align=8 atomic=1, atomic alloc failed, no space left
>   [   91.304716] CPU: 51 PID: 24145 Comm: test_maps Kdump: loaded Tainted: G                 N 6.1.38-smp-DEV #7
>   [   91.304719] Hardware name: Google Astoria/astoria, BIOS 0.20230627.0-0 06/27/2023
>   [   91.304721] Call Trace:
>   [   91.304724]  <TASK>
>   [   91.304730]  [<ffffffffa7ef83b9>] dump_stack_lvl+0x59/0x88
>   [   91.304737]  [<ffffffffa7ef83f8>] dump_stack+0x10/0x18
>   [   91.304738]  [<ffffffffa75caa0c>] pcpu_alloc+0x6fc/0x870
>   [   91.304741]  [<ffffffffa75ca302>] __alloc_percpu_gfp+0x12/0x20
>   [   91.304743]  [<ffffffffa756785e>] alloc_bulk+0xde/0x1e0
>   [   91.304746]  [<ffffffffa7566c02>] bpf_mem_alloc_init+0xd2/0x2f0
>   [   91.304747]  [<ffffffffa7547c69>] htab_map_alloc+0x479/0x650
>   [   91.304750]  [<ffffffffa751d6e0>] map_create+0x140/0x2e0
>   [   91.304752]  [<ffffffffa751d413>] __sys_bpf+0x5a3/0x6c0
>   [   91.304753]  [<ffffffffa751c3ec>] __x64_sys_bpf+0x1c/0x30
>   [   91.304754]  [<ffffffffa7ef847a>] do_syscall_64+0x5a/0x80
>   [   91.304756]  [<ffffffffa800009b>] entry_SYSCALL_64_after_hwframe+0x63/0xcd
> 
> [...]

Here is the summary with links:
  - [v3,bpf-next] bpf/memalloc: Non-atomically allocate freelist during prefill
    https://git.kernel.org/bpf/bpf-next/c/d1a02358d48d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2023-07-28 16:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-28  4:33 [PATCH v3 bpf-next] bpf/memalloc: Non-atomically allocate freelist during prefill YiFei Zhu
2023-07-28  4:53 ` Yonghong Song
2023-07-28  6:16 ` Hou Tao
2023-07-28 16:50 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169056302111.15046.9436134761640107327.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=houtao@huaweicloud.com \
    --cc=martin.lau@linux.dev \
    --cc=sdf@google.com \
    --cc=yonghong.song@linux.dev \
    --cc=zhuyifei@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.