From: patchwork-bot+netdevbpf@kernel.org
To: Alexandra Winter <wintera@linux.ibm.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, hca@linux.ibm.com,
wenjia@linux.ibm.com
Subject: Re: [PATCH net] s390/qeth: Don't call dev_close/dev_open (DOWN/UP)
Date: Wed, 02 Aug 2023 09:20:21 +0000 [thread overview]
Message-ID: <169096802115.5600.7801745258990045314.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230801080016.744474-1-wintera@linux.ibm.com>
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Tue, 1 Aug 2023 10:00:16 +0200 you wrote:
> dev_close() and dev_open() are issued to change the interface state to DOWN
> or UP (dev->flags IFF_UP). When the netdev is set DOWN it loses e.g its
> Ipv6 addresses and routes. We don't want this in cases of device recovery
> (triggered by hardware or software) or when the qeth device is set
> offline.
>
> Setting a qeth device offline or online and device recovery actions call
> netif_device_detach() and/or netif_device_attach(). That will reset or
> set the LOWER_UP indication i.e. change the dev->state Bit
> __LINK_STATE_PRESENT. That is enough to e.g. cause bond failovers, and
> still preserves the interface settings that are handled by the network
> stack.
>
> [...]
Here is the summary with links:
- [net] s390/qeth: Don't call dev_close/dev_open (DOWN/UP)
https://git.kernel.org/netdev/net/c/1cfef80d4c2b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-08-02 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 8:00 [PATCH net] s390/qeth: Don't call dev_close/dev_open (DOWN/UP) Alexandra Winter
2023-08-02 9:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169096802115.5600.7801745258990045314.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hca@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.