From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH] eal/windows: resolve conversion and truncation warnings
Date: Wed, 2 Aug 2023 13:48:22 -0700 [thread overview]
Message-ID: <1691009302-32551-1-git-send-email-roretzla@linux.microsoft.com> (raw)
* Initialize const int NS_PER_SEC with an integer literal instead of
double thereby avoiding implicit conversion from double to int.
* Cast the result of the expression assigned to timspec.tv_nsec to long.
Windows builds generate integer truncation warning for this assignment
since the result of the expression was 8 bytes (LONGLONG) but
on Windows targets is 4 bytes. The value produced for the expression
should safely fit in the long.
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
lib/eal/windows/include/rte_os_shim.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h
index eda8113..19b12e9 100644
--- a/lib/eal/windows/include/rte_os_shim.h
+++ b/lib/eal/windows/include/rte_os_shim.h
@@ -87,7 +87,7 @@
static inline int
rte_clock_gettime(clockid_t clock_id, struct timespec *tp)
{
- const int NS_PER_SEC = 1E9;
+ const int NS_PER_SEC = 1000000000;
LARGE_INTEGER pf, pc;
LONGLONG nsec;
@@ -102,7 +102,7 @@
nsec = pc.QuadPart * NS_PER_SEC / pf.QuadPart;
tp->tv_sec = nsec / NS_PER_SEC;
- tp->tv_nsec = nsec - tp->tv_sec * NS_PER_SEC;
+ tp->tv_nsec = (long)(nsec - tp->tv_sec * NS_PER_SEC);
return 0;
default:
return -1;
--
1.8.3.1
next reply other threads:[~2023-08-02 20:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 20:48 Tyler Retzlaff [this message]
2023-08-02 22:29 ` [PATCH] eal/windows: resolve conversion and truncation warnings Dmitry Kozlyuk
2023-08-02 22:41 ` Tyler Retzlaff
2023-08-02 23:44 ` Dmitry Kozlyuk
2023-08-03 0:30 ` Tyler Retzlaff
2024-03-07 18:34 ` [PATCH v2] " Tyler Retzlaff
2024-03-07 20:53 ` Bruce Richardson
2024-03-07 20:57 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1691009302-32551-1-git-send-email-roretzla@linux.microsoft.com \
--to=roretzla@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.