All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: edumazet@google.com, davem@davemloft.net, dsahern@kernel.org,
	kuba@kernel.org, pabeni@redhat.com, apetlund@simula.no,
	netdev@vger.kernel.org, kernelxing@tencent.com
Subject: Re: [PATCH v2 net] net: fix the RTO timer retransmitting skb every 1ms if linear option is enabled
Date: Tue, 15 Aug 2023 19:30:21 +0000	[thread overview]
Message-ID: <169212782187.7072.16617221851171968021.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230811023747.12065-1-kerneljasonxing@gmail.com>

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri, 11 Aug 2023 10:37:47 +0800 you wrote:
> From: Jason Xing <kernelxing@tencent.com>
> 
> In the real workload, I encountered an issue which could cause the RTO
> timer to retransmit the skb per 1ms with linear option enabled. The amount
> of lost-retransmitted skbs can go up to 1000+ instantly.
> 
> The root cause is that if the icsk_rto happens to be zero in the 6th round
> (which is the TCP_THIN_LINEAR_RETRIES value), then it will always be zero
> due to the changed calculation method in tcp_retransmit_timer() as follows:
> 
> [...]

Here is the summary with links:
  - [v2,net] net: fix the RTO timer retransmitting skb every 1ms if linear option is enabled
    https://git.kernel.org/netdev/net/c/e4dd0d3a2f64

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2023-08-15 19:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11  2:37 [PATCH v2 net] net: fix the RTO timer retransmitting skb every 1ms if linear option is enabled Jason Xing
2023-08-15  2:08 ` Jason Xing
2023-08-15  2:24   ` Jakub Kicinski
2023-08-15  3:02     ` Jason Xing
2023-08-15  6:59 ` Eric Dumazet
2023-08-15 19:30 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169212782187.7072.16617221851171968021.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=apetlund@simula.no \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kerneljasonxing@gmail.com \
    --cc=kernelxing@tencent.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.