From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Florent Revest <revest@chromium.org>
Cc: linux-trace-kernel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
bpf <bpf@vger.kernel.org>, Sven Schnelle <svens@linux.ibm.com>,
Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Alan Maguire <alan.maguire@oracle.com>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH v4 0/9] bpf: fprobe: rethook: Use ftrace_regs instead of pt_regs
Date: Thu, 24 Aug 2023 00:15:28 +0900 [thread overview]
Message-ID: <169280372795.282662.9784422934484459769.stgit@devnote2> (raw)
Hi,
Here is the 4th version of the series to use ftrace_regs instead of pt_regs
in fprobe.
The previous version is here;
https://lore.kernel.org/all/169181859570.505132.10136520092011157898.stgit@devnote2/
This version fixes the issues pointed in the previous series; fix document
description, keep CONFIG_FPROBE dependency for multi-kprobe, add
static_assert check for ftrace_regs size, reorder the ftrace_partial_regs()
patch for perf fprobe event support, introduce per-cpu pt_regs stack for
perf fprobe event and add Florent's Ack (Thanks!). Also this adds a new
documentation patch to clarify that the $argN and $retval is best effort.
- Document fix for the current fprobe callback prototype
- Simply replace pt_regs in fprobe_entry_handler with ftrace_regs.
- Expose ftrace_regs even if CONFIG_FUNCTION_TRACER=n.
- Introduce ftrace_partial_regs(). (This changes ARM64 which needs a custom
implementation)
- Replace pt_regs in rethook and fprobe_exit_handler with ftrace_regs. This
introduce a new HAVE_PT_REGS_TO_FTRACE_REGS_CAST which means ftrace_regs is
just a wrapper of pt_regs (except for arm64, other architectures do this)
- Update fprobe-events to use ftrace_regs natively.
- Update bpf multi-kprobe handler use ftrace_partial_regs().
- Update document for new fprobe callbacks.
- Add notes for the $argN and $retval.
This series can be applied against the probes/core branch on linux-trace tree.
This series can also be found below branch.
https://git.kernel.org/pub/scm/linux/kernel/git/mhiramat/linux.git/log/?h=topic/fprobe-ftrace-regs
Thank you,
---
Masami Hiramatsu (Google) (9):
Documentation: probes: Add a new ret_ip callback parameter
fprobe: Use fprobe_regs in fprobe entry handler
tracing: Expose ftrace_regs regardless of CONFIG_FUNCTION_TRACER
fprobe: rethook: Use ftrace_regs in fprobe exit handler and rethook
ftrace: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs
tracing/fprobe: Enable fprobe events with CONFIG_DYNAMIC_FTRACE_WITH_ARGS
bpf: Enable kprobe_multi feature if CONFIG_FPROBE is enabled
Documentations: probes: Update fprobe document to use ftrace_regs
Documentation: tracing: Add a note about argument and retval access
Documentation/trace/fprobe.rst | 18 +++--
Documentation/trace/fprobetrace.rst | 8 ++
Documentation/trace/kprobetrace.rst | 8 ++
arch/Kconfig | 1
arch/arm64/include/asm/ftrace.h | 11 +++
arch/loongarch/Kconfig | 1
arch/s390/Kconfig | 1
arch/s390/include/asm/ftrace.h | 4 +
arch/x86/Kconfig | 1
arch/x86/kernel/rethook.c | 13 ++-
include/linux/fprobe.h | 4 +
include/linux/ftrace.h | 89 ++++++++++++++++++------
include/linux/rethook.h | 11 ++-
kernel/kprobes.c | 10 ++-
kernel/trace/Kconfig | 9 ++
kernel/trace/bpf_trace.c | 14 ++--
kernel/trace/fprobe.c | 10 +--
kernel/trace/rethook.c | 16 ++--
kernel/trace/trace_fprobe.c | 131 ++++++++++++++++++++++++++---------
kernel/trace/trace_probe_tmpl.h | 2 -
lib/test_fprobe.c | 10 +--
samples/fprobe/fprobe_example.c | 4 +
22 files changed, 267 insertions(+), 109 deletions(-)
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next reply other threads:[~2023-08-23 15:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 15:15 Masami Hiramatsu (Google) [this message]
2023-08-23 15:15 ` [PATCH v4 1/9] Documentation: probes: Add a new ret_ip callback parameter Masami Hiramatsu (Google)
2023-08-25 16:11 ` Florent Revest
2023-08-23 15:15 ` [PATCH v4 2/9] fprobe: Use fprobe_regs in fprobe entry handler Masami Hiramatsu (Google)
2023-08-25 16:11 ` Florent Revest
2023-08-23 15:16 ` [PATCH v4 3/9] tracing: Expose ftrace_regs regardless of CONFIG_FUNCTION_TRACER Masami Hiramatsu (Google)
2023-08-23 15:16 ` [PATCH v4 4/9] fprobe: rethook: Use ftrace_regs in fprobe exit handler and rethook Masami Hiramatsu (Google)
2023-08-25 16:12 ` Florent Revest
2023-09-04 13:40 ` Masami Hiramatsu
2023-09-05 7:17 ` Sven Schnelle
2023-09-05 13:36 ` Masami Hiramatsu
2023-09-05 16:30 ` Steven Rostedt
2023-09-06 0:06 ` Masami Hiramatsu
2023-09-06 6:49 ` Sven Schnelle
2023-09-09 14:24 ` Masami Hiramatsu
2023-09-11 7:55 ` Sven Schnelle
2023-09-11 14:15 ` Masami Hiramatsu
2023-08-23 15:16 ` [PATCH v4 5/9] ftrace: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs Masami Hiramatsu (Google)
2023-08-25 21:49 ` Andrii Nakryiko
2023-08-26 1:56 ` Masami Hiramatsu
2023-09-05 19:50 ` Andrii Nakryiko
2023-09-06 0:28 ` Masami Hiramatsu
2023-09-08 22:56 ` Andrii Nakryiko
2023-08-23 15:16 ` [PATCH v4 6/9] tracing/fprobe: Enable fprobe events with CONFIG_DYNAMIC_FTRACE_WITH_ARGS Masami Hiramatsu (Google)
2023-08-25 16:12 ` Florent Revest
2023-08-26 3:38 ` Masami Hiramatsu
2023-08-30 7:20 ` Masami Hiramatsu
2023-08-23 15:16 ` [PATCH v4 7/9] bpf: Enable kprobe_multi feature if CONFIG_FPROBE is enabled Masami Hiramatsu (Google)
2023-08-23 15:16 ` [PATCH v4 8/9] Documentations: probes: Update fprobe document to use ftrace_regs Masami Hiramatsu (Google)
2023-08-23 15:17 ` [PATCH v4 9/9] Documentation: tracing: Add a note about argument and retval access Masami Hiramatsu (Google)
2023-08-25 16:12 ` Florent Revest
2023-08-25 16:11 ` [PATCH v4 0/9] bpf: fprobe: rethook: Use ftrace_regs instead of pt_regs Florent Revest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169280372795.282662.9784422934484459769.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=peterz@infradead.org \
--cc=revest@chromium.org \
--cc=rostedt@goodmis.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.