From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 1/6] net: changed arp_hdr struct declaration Date: Fri, 20 Feb 2015 15:30:36 +0100 Message-ID: <1694402.UUemy3W7BY@xps13> References: <1423840570-6452-1-git-send-email-michalx.k.jastrzebski@intel.com> <1424366779-14256-1-git-send-email-michalx.k.jastrzebski@intel.com> <1424366779-14256-2-git-send-email-michalx.k.jastrzebski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Michal Jastrzebski Return-path: In-Reply-To: <1424366779-14256-2-git-send-email-michalx.k.jastrzebski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-02-19 18:26, Michal Jastrzebski: > From: Maciej Gajdzica > > Changed MAC address type from uint8_t[6] to struct ether_addr and IP > address type from uint8_t[4] to uint32_t. Also removed union from > arp_hdr struct. Updated test-pmd to match new arp_hdr version. > > Signed-off-by: Maciej Gajdzica Why? "Changed A to B" is not a sufficient explanation.