From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Jerin Jacob <jerinjacobk@gmail.com>
Subject: Re: [PATCH v2] build: fix warnings when running external commands
Date: Wed, 02 Feb 2022 15:44:49 +0100 [thread overview]
Message-ID: <1694573.X513TT2pbd@thomas> (raw)
In-Reply-To: <CALBAE1PzySnTLfYHuaz1ooCROQN0oofGUBSkNJOMZQLVSKh11w@mail.gmail.com>
24/01/2022 15:08, Jerin Jacob:
> On Thu, Jan 20, 2022 at 11:37 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > Meson 0.61.1 is giving warnings that the calls to run_command do not
> > always explicitly specify if the result is to be checked or not, i.e.
> > there is a missing "check" parameter. This is because the default
> > behaviour without the parameter is due to change in the future.
> >
> > We can fix these warnings by explicitly adding into each call whether
> > the result should be checked by meson or not. This patch therefore
> > adds in "check: false" to each run_command call where the result is
> > being checked by the DPDK meson.build code afterwards, and adds in
> > "check: true" to any calls where the result is currently unchecked.
> >
> > Bugzilla-id: 921
> >
> > Reported-by: Jerin Jacob <jerinjacobk@gmail.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Tested-by: Jerin Jacob <jerinj@marvell.com>
Applied, thanks.
prev parent reply other threads:[~2022-02-02 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <http://patches.dpdk.org/project/dpdk/patch/20220120174159.654464-1-bruce.richardson@intel.com/>
2022-01-20 18:06 ` [PATCH v2] build: fix warnings when running external commands Bruce Richardson
2022-01-24 14:08 ` Jerin Jacob
2022-02-02 14:44 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1694573.X513TT2pbd@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.