From: David Howells <dhowells@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: dhowells@redhat.com, Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Neil Horman <nhorman@tuxdriver.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 1/2] umh && creds: convert call_usermodehelper_keys() to use subprocess_info->init()
Date: Fri, 26 Feb 2010 18:00:38 +0000 [thread overview]
Message-ID: <16951.1267207238@redhat.com> (raw)
In-Reply-To: <20100225181500.GA18008@redhat.com>
Oleg Nesterov <oleg@redhat.com> wrote:
> + /*
> + * This is called in context of freshly forked kthread before
> + * kernel_execve(), we can just change our ->session_keyring.
> + */
Ummmm.... What gives you that idea?
You may be sharing init_cred...
You need to create, modify and commit a new set of creds.
David
next prev parent reply other threads:[~2010-02-26 18:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 18:15 [PATCH -mm 1/2] umh && creds: convert call_usermodehelper_keys() to use subprocess_info->init() Oleg Nesterov
2010-02-26 18:00 ` David Howells [this message]
2010-02-26 18:23 ` Oleg Nesterov
2010-02-26 18:41 ` David Howells
2010-02-26 18:52 ` Oleg Nesterov
2010-02-26 20:03 ` [PATCH v2 -mm 0/2] umh && creds: kill sub_info->cred Oleg Nesterov
2010-02-26 20:03 ` [PATCH v2 -mm 1/2] umh && creds: convert call_usermodehelper_keys() to use subprocess_info->init() Oleg Nesterov
2010-02-26 20:28 ` Neil Horman
2010-02-26 20:42 ` David Howells
2010-02-26 20:53 ` Oleg Nesterov
2010-02-26 23:24 ` David Howells
2010-03-05 22:52 ` Oleg Nesterov
2010-03-05 23:09 ` [PATCH,RESEND " Oleg Nesterov
2010-03-08 13:19 ` David Howells
2010-03-08 17:44 ` Neil Horman
2010-03-05 23:10 ` [PATCH,RESEND -mm 2/2] umh && creds: kill subprocess_info->cred logic Oleg Nesterov
2010-03-08 13:19 ` David Howells
2010-03-08 17:47 ` Neil Horman
2010-02-26 20:04 ` [PATCH v2 " Oleg Nesterov
2010-02-26 20:29 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16951.1267207238@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.