From: Thomas Monjalon <thomas@monjalon.net>
To: Amr Mokhtar <amr.mokhtar@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [PATCH v2] bbdev: fix exported dynamic log type
Date: Tue, 06 Feb 2018 18:50:34 +0100 [thread overview]
Message-ID: <1695986.x6khAz695a@xps> (raw)
In-Reply-To: <1517923770-45640-1-git-send-email-amr.mokhtar@intel.com>
06/02/2018 14:29, Amr Mokhtar:
> This patch fixes shared library compilation due to undefined
> reference to an exported variable 'bbdev_logtype'.
>
> v2:
> * In this fix,
> * - The logtype has become static and owned individually by each
> * component.
> * - Helper logging macros are removed from bbdev lib header files
> * and replaced with macros defined by each driver at its ease.
> * - 'bbdev_logtype' removed from .map
>
> v1:
> * This patch fixes shared library compilation due to undefined
> * reference to an exported variable 'bbdev_logtype'.
> * In this fix, the logtype is converted to static in the bbdev lib,
> * in bbdev null pmd and turbo sw pmd.
>
>
> Fixes: 4935e1e9f76e ("bbdev: introduce wireless base band device lib")
> Fixes: b8cfe2c9aed2 ("bb/turbo_sw: add software turbo driver")
> Fixes: 7dc2b1589440 ("bb/null: add null base band device driver")
> Cc: thomas@monjalon.net
>
> Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-02-06 17:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 22:27 [PATCH] bb/null: fix exported dynamic log type Amr Mokhtar
2018-02-06 0:41 ` Thomas Monjalon
2018-02-06 13:29 ` [PATCH v2] bbdev: " Amr Mokhtar
2018-02-06 17:50 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1695986.x6khAz695a@xps \
--to=thomas@monjalon.net \
--cc=amr.mokhtar@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.