From: David Woodhouse <dwmw2@infradead.org>
To: Pavel Rabel <pavel@web.sajt.cz>
Cc: ajapted@netspace.net.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mdacon.c cleanup
Date: Tue, 12 Dec 2000 09:15:11 +0000 [thread overview]
Message-ID: <16970.976612511@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.21.0012102205190.11977-100000@web.sajt.cz>
In-Reply-To: <Pine.LNX.4.21.0012102205190.11977-100000@web.sajt.cz>
pavel@web.sajt.cz said:
> Both MODULE_PARM and __init are removed by precompiler when not
> compiler as module, so no need for ifdefs. 2.4.0-test12pre8
-#ifdef MODULE_PARM
MODULE_PARM(mda_first_vc, "1-255i");
MODULE_PARM(mda_last_vc, "1-255i");
-#endif
That was #ifdef MODULE_PARM not #ifdef MODULE. Probably there for
compatibility with older kernels. Although I'm not sure it's even required
in 2.2.
And you seem to have forgotten to Cc the maintainer.
--
dwmw2
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-12-12 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-10 21:09 [PATCH] mdacon.c cleanup Pavel Rabel
2000-12-12 9:15 ` David Woodhouse [this message]
2000-12-12 22:34 ` Pavel Rabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16970.976612511@redhat.com \
--to=dwmw2@infradead.org \
--cc=ajapted@netspace.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@web.sajt.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.