From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4] eal: restrict cores auto detection
Date: Thu, 08 Dec 2016 19:19:41 +0100
Message-ID: <1697449.uzq8KWsvfF@xps13>
References: <1472693507-11369-1-git-send-email-jianfeng.tan@intel.com>
 <1480700936-8450-1-git-send-email-jianfeng.tan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, david.marchand@6wind.com, pmatilai@redhat.com,
 bruce.richardson@intel.com
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wj0-f176.google.com (mail-wj0-f176.google.com
 [209.85.210.176]) by dpdk.org (Postfix) with ESMTP id 4DF212A66
 for <dev@dpdk.org>; Thu,  8 Dec 2016 19:19:43 +0100 (CET)
Received: by mail-wj0-f176.google.com with SMTP id tk12so100105746wjb.3
 for <dev@dpdk.org>; Thu, 08 Dec 2016 10:19:43 -0800 (PST)
In-Reply-To: <1480700936-8450-1-git-send-email-jianfeng.tan@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-12-02 17:48, Jianfeng Tan:
> This patch uses pthread_getaffinity_np() to narrow down used
> cores when none of below options is specified:
>   * coremask (-c)
>   * corelist (-l)
>   * and coremap (--lcores)
> 
> The purpose of this patch is to leave out these core related options
> when DPDK applications are deployed under container env, so that
> users do not need decide the core related parameters when developing
> applications. Instead, when applications are deployed in containers,
> use cpu-set to constrain which cores can be used inside this container
> instance. And DPDK application inside containers just rely on this
> auto detect mechanism to start polling threads.
> 
> Note: previously, some users are using isolated CPUs, which could
> be excluded by default. Please add commands like taskset to use
> those cores.
> 
> Test example:
> $ taskset 0xc0000 ./examples/helloworld/build/helloworld -m 1024

Bruce, what do you think of this version?
It requires taskset only if -c, -l and --lcores are not used.

>  static int master_lcore_parsed;
>  static int mem_parsed;
> +static int core_specified;

I think it's better to keep the word "parsed" as others.