All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com,
	Bruce Richardson <bruce.richardson@intel.com>,
	Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH v2 2/2] eal: disable standard c atomics support check for MSVC
Date: Tue, 17 Oct 2023 06:49:23 -0700	[thread overview]
Message-ID: <1697550563-17532-3-git-send-email-roretzla@linux.microsoft.com> (raw)
In-Reply-To: <1697550563-17532-1-git-send-email-roretzla@linux.microsoft.com>

MSVC will define __STDC_NO_ATOMICS__ until versions of the compiler that
support atomics is released. Currently we use the Preview version of the
compiler so skip the test of __STDC_NO_ATOMICS__ avoiding failure.

This is a temporary change until the required compiler is released
publicly but allows us to establish the MSVC CI pipeline.

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 lib/eal/include/rte_stdatomic.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/eal/include/rte_stdatomic.h b/lib/eal/include/rte_stdatomic.h
index 8579e2d..7a081cb 100644
--- a/lib/eal/include/rte_stdatomic.h
+++ b/lib/eal/include/rte_stdatomic.h
@@ -12,9 +12,11 @@
 #endif
 
 #ifdef RTE_ENABLE_STDATOMIC
+#ifndef _MSC_VER
 #ifdef __STDC_NO_ATOMICS__
 #error enable_stdatomic=true but atomics not supported by toolchain
 #endif
+#endif
 
 #include <stdatomic.h>
 
-- 
1.8.3.1


  parent reply	other threads:[~2023-10-17 13:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 13:13 [PATCH 0/2] make dpdk buildable with latest msvc Tyler Retzlaff
2023-10-17 13:13 ` [PATCH 1/2] build: temporarily disable MSVC warnings Tyler Retzlaff
2023-10-17 13:31   ` Bruce Richardson
2023-10-17 13:13 ` [PATCH 2/2] eal: temporarily disable standard c atomics support for MSVC Tyler Retzlaff
2023-10-17 13:49 ` [PATCH v2 0/2] make dpdk buildable with latest msvc Tyler Retzlaff
2023-10-17 13:49   ` [PATCH v2 1/2] build: temporarily disable MSVC warnings Tyler Retzlaff
2023-10-17 13:49   ` Tyler Retzlaff [this message]
2023-10-31 18:39   ` [PATCH v2 0/2] make dpdk buildable with latest msvc David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1697550563-17532-3-git-send-email-roretzla@linux.microsoft.com \
    --to=roretzla@linux.microsoft.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.