Re: [PATCH 1/2] Fix CPU and memory parameters on IBM POWER8

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-03-25 09:48, David Marchand:
> On Fri, Mar 25, 2016 at 9:11 AM, Chao Zhu <chaozhu@linux.vnet.ibm.com> wrote:
> > This patch fixes the max logic number and memory channel number settings
> > on IBM POWER8 platform.
> > 1. The max number of logic cores of a POWER8 processor is 96. Normally,
> >    there are two sockets on a server. So the max number of logic cores
> >    are 192. So this parch set CONFIG_RTE_MAX_LCORE to 256.
> 
> This is a power8 configuration item, this should go to power8 config
> file, not common_base.
> 
> > 2. Currently, the max number of memory channels are hardcoded to 4. However,
> >    on a POWER8 machine, the max number of memory channels are 8. To fix this,
> >    CONFIG_RTE_MAX_NCHANNELS is added to do the configuration.
> 
> I don't see any reason why we would need a max value for force_nchannel.
> We should just get rid of this check, this is an obscure parameter for
> most people, so people playing with it know what they are doing
> (hopefully ?).
> 
> On the other hand, if power8 has some specifics about it, maybe we
> should introduce some default value in a arch eal header for other
> dpdk components to use (like in mempool).
> Thoughts ?

Chao? We are running out of time for 16.04.