From: patchwork-bot+netdevbpf@kernel.org
To: Fred Chen <fred.chenchen03@gmail.com>
Cc: edumazet@google.com, davem@davemloft.net, netdev@vger.kernel.org,
yangpc@wangsu.com, ycheng@google.com, ncardwell@google.com
Subject: Re: [PATCH v1] tcp: fix wrong RTO timeout when received SACK reneging
Date: Sun, 22 Oct 2023 10:50:24 +0000 [thread overview]
Message-ID: <169797182427.5465.8249918922922941092.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <1697847587-6850-1-git-send-email-fred.chenchen03@gmail.com>
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Sat, 21 Oct 2023 08:19:47 +0800 you wrote:
> This commit fix wrong RTO timeout when received SACK reneging.
>
> When an ACK arrived pointing to a SACK reneging, tcp_check_sack_reneging()
> will rearm the RTO timer for min(1/2*srtt, 10ms) into to the future.
>
> But since the commit 62d9f1a6945b ("tcp: fix TLP timer not set when
> CA_STATE changes from DISORDER to OPEN") merged, the tcp_set_xmit_timer()
> is moved after tcp_fastretrans_alert()(which do the SACK reneging check),
> so the RTO timeout will be overwrited by tcp_set_xmit_timer() with
> icsk_rto instead of 1/2*srtt.
>
> [...]
Here is the summary with links:
- [v1] tcp: fix wrong RTO timeout when received SACK reneging
https://git.kernel.org/netdev/net/c/d2a0fc372aca
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-10-22 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 0:19 [PATCH v1] tcp: fix wrong RTO timeout when received SACK reneging Fred Chen
2023-10-21 23:57 ` Neal Cardwell
2023-10-22 10:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169797182427.5465.8249918922922941092.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fred.chenchen03@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=yangpc@wangsu.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.