From: patchwork-bot+netdevbpf@kernel.org
To: =?utf-8?q?Moritz_Wanzenb=C3=B6ck_=3Cmoritz=2Ewanzenboeck=40linbit=2Ecom=3E?=@ci.codeaurora.org
Cc: netdev@vger.kernel.org, kernel-tls-handshake@lists.linux.dev,
chuck.lever@oracle.com
Subject: Re: [PATCH] net/handshake: fix file ref count in handshake_nl_accept_doit()
Date: Mon, 23 Oct 2023 17:30:23 +0000 [thread overview]
Message-ID: <169808222318.2880.6790391903176852910.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20231019125847.276443-1-moritz.wanzenboeck@linbit.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 19 Oct 2023 14:58:47 +0200 you wrote:
> If req->hr_proto->hp_accept() fail, we call fput() twice:
> Once in the error path, but also a second time because sock->file
> is at that point already associated with the file descriptor. Once
> the task exits, as it would probably do after receiving an error
> reading from netlink, the fd is closed, calling fput() a second time.
>
> To fix, we move installing the file after the error path for the
> hp_accept() call. In the case of errors we simply put the unused fd.
> In case of success we can use fd_install() to link the sock->file
> to the reserved fd.
>
> [...]
Here is the summary with links:
- net/handshake: fix file ref count in handshake_nl_accept_doit()
https://git.kernel.org/netdev/net/c/7798b59409c3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-10-23 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 12:58 [PATCH] net/handshake: fix file ref count in handshake_nl_accept_doit() Moritz Wanzenböck
2023-10-19 13:06 ` Hannes Reinecke
2023-10-19 13:36 ` Moritz Wanzenböck
2023-10-21 18:01 ` Chuck Lever
2023-10-23 17:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169808222318.2880.6790391903176852910.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc==?utf-8?q?Moritz_Wanzenb=C3=B6ck_=3Cmoritz=2Ewanzenboeck=40linbit=2Ecom=3E?=@ci.codeaurora.org \
--cc=chuck.lever@oracle.com \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.