From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pSdFW-0007Op-0G for mharc-grub-devel@gnu.org; Thu, 16 Feb 2023 07:20:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSdFM-0007OH-OB for grub-devel@gnu.org; Thu, 16 Feb 2023 07:20:20 -0500 Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSdFJ-0003Iz-Ul for grub-devel@gnu.org; Thu, 16 Feb 2023 07:20:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1676550005; i=scdbackup@gmx.net; bh=uNA+PqzsYkfiKm/2GZYavYCvnhu8Nte1q6SopwZSno4=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=ExHkDmEbMpJnJp8/XlyipxmExS3cNo+ws/LDVGNVMx6lT1ULngXzLIJ37DTkjhK92 2UmkUNj5yUGTzOg0nYyMgtdhZ1elgwCr0s1lV9ESkSKvday1lpgSTfzKFA3iXPIS9Z dW4ZsK8+pRAJovCor8uMuYCZfLW3pC7TwzSh7fm32vGtS4GbQuNRsQjm3b99sKNg7w ADr25X2d6HIkz+hvnMjzPiud2weF8Mlp01FjaYcR82NsdQr7b1R6+yr2CCXjCXCOoU kt2wDaem5Wv3s+Byxov+nwdvWETLyZrZBqeCRyIWlXIG5f9SbAknGhecQsUGxuwoOG hA3YnMUYAougA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from scdbackup.webframe.org ([84.179.243.254]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MiaY9-1owZXe2UHH-00fnG2; Thu, 16 Feb 2023 13:20:05 +0100 Date: Thu, 16 Feb 2023 13:20:30 +0100 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: [PATCH v3] tests: Add pathological iso9660 filesystem tests Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: daniel.kiper@oracle.com,development@efficientek.com References: <20230216070437.2142161-1-development@efficientek.com> In-Reply-To: <20230216070437.2142161-1-development@efficientek.com> Message-Id: <16986390804658560051@scdbackup.webframe.org> X-Provags-ID: V03:K1:YFvuhOU4K4qKE930sdze5PEquIH6BawgpjwFNajKb4uPVZLvF1C sXPAhPP+7AT3naTiEtUgMhG2M0JJHQ/MmozNAdIyoYOSYg6aXOTOn4pirq938yWEIDWTEYK tP7W6PQ0CN0jZdlpzZDj9aDiYuU0i3x3fBL7g6P5yctEq0X1Z+hhgk1T+kkBOkrgeBwkuxY VuT3JDLq3NPZiu2e7WpSg== UI-OutboundReport: notjunk:1;M01:P0:Lu+UF6XLNTw=;uoo+A4jZpQZgZ6pVOITUcM1KBsr 2EysSxuu05HkOKDoTemowwZkrwctYn+8TuM4v8/hg3wiRiIt2GsHIldsxJcjNKDbyRArCuuDJ QXbqSz/YF9YdcqTiCc6wccBiKni2YnwfUN97CwPEwAmFk3j5GDwh/HXTd4rvJOW3w9Dj9gRqL LKvXAIYo3PtVrePsDmYDwxZqOYGvw4tNgZmzDg2K7cFXmGGN7PMIfDVK4Qx8ZfSjeF2fitz2L j56+g/jKGjEQ6liFgViwujNPtoStlL33Agay+Y3tQozg1OE86s/O3PPlpg53qRp/qEZx2DUEO coCwkyb8uOsbsF+1OI9IOb2dTXePfwCXEpGOBOi7x8be14KYbekW3gzZZ6a+yZf0hYvtul5/e QYidKlkKslNKZFLKByblM4ouBDWyUtqdqiSqOQFOk7lmtIXZn4i5VrqOtimuZREj21oq/cV8f XTUbXnTR4BwDMdywjFzKaYOLZqWRM4rV0HG9cUJbviDjoI4kiVHuGZLtqWifXVh71hBKa3W7X 7XEg2Ns4fSHHjK/Cws1X8SyO6Y+UwcE43ttgsa3HzmIkSWBoa2LsP/WAb5sK86Rg9UGHHadPT 86htcTFEG4eXNmHOdMbVTp28NnI3OnVD1ZHMlCCuSww1Vv2sbAYZpYhMFa7zUILl0ZuX+ahSR tm4dqw8gtgRSXnAuRV4qFPOh8FMN90pKHLhGGspcNx5R4KMCbDR0c0oblflm91MVC6ou9ZBmE tjgLqo6E2awSDQ7klAsd54zEiy7h8X/Py4py0DWz3uA0p75AzkSYCGx//pP28WDrPF8G7xc/z 5faRvf7KPrPm26/bl4eRxFbDq68U+1WOUbeWXYRMvW87RwNhVgJjuJgFddXfXKW0W1n/ut9pb lgffN8B+jXb8qsBRJGnOLcuMm99nBLgkRqrQerD9MU4oZrNli5NAyEB2uC1IB7Ray+SiYgGWy iwk0IBhSUcShiH98lsONGKbQ8DU= Received-SPF: pass client-ip=212.227.15.18; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2023 12:20:26 -0000 Hi, On Thu, 16 Feb 2023 01:04:37 -0600, Glenn Washburn wrote: > These are not added to grub-fs-tester because they are not generated and > none of the filesystem tests are run on these isos. The test is to run t= he > command "ls /" on the iso, and a failure is determined if the command > times out, has non-zero return value or has any output. > > Signed-off-by: Glenn Washburn > --- > Interdiff against v2: > diff --git a/tests/iso9660_test.in b/tests/iso9660_test.in > index 0ec28bd066..44bc08c6df 100644 > --- a/tests/iso9660_test.in > +++ b/tests/iso9660_test.in > @@ -14,12 +14,17 @@ fi > "@builddir@/grub-fs-tester" rockridge_1999 > "@builddir@/grub-fs-tester" rockridge_joliet_1999 > > +echo "Testing for proper recognition of CE loops ... " > for fs in iso9660_ce_loop iso9660_ce_loop2; do > tempdir=3D`mktemp -d "${TMPDIR:-/tmp}/${0##*/}.$(date '+%Y%m%d%H%M%= S%N').${fs}.XXX"` || > { echo "Failed to make temporary directory"; exit 99; } > - gunzip <"$srcdir"/tests/${fs}.iso.gz >"${tempdir}/${fs}.iso" > + gunzip <"$srcdir"/tests/${fs}.iso.gz >"${tempdir}/${fs}.iso" || exi= t 99 > output=3D$(LC_ALL=3DC timeout -s KILL "60" \ > "@builddir@/grub-fstest" "${tempdir}/${fs}.iso" ls / ) || ret=3D$= ? > rm -rf "$tempdir" > - test "${ret:-0}" -eq 0 -a -z "$output" > + if [ "${ret:-0}" -ne 0 -o -n "$output" ]; then > + echo "FAIL ($fs)" > + exit 1 > + fi > done > +echo "PASS" > > tests/iso9660_ce_loop.iso.gz | Bin 0 -> 897 bytes > tests/iso9660_ce_loop2.iso.gz | Bin 0 -> 904 bytes > tests/iso9660_test.in | 17 ++++++++++++++++- > 3 files changed, 16 insertions(+), 1 deletion(-) > create mode 100644 tests/iso9660_ce_loop.iso.gz > create mode 100644 tests/iso9660_ce_loop2.iso.gz > > diff --git a/tests/iso9660_ce_loop.iso.gz b/tests/iso9660_ce_loop.iso.gz > new file mode 100644 > index 0000000000000000000000000000000000000000..9c53c569b8e5c2441273d49f= 4c8e13e4b3303c24 > GIT binary patch > literal 897 > zcmb2|=3D3ofBusfN7`Rxt=3D{M#uq3<N2(O2EDtVk > zV!mF;l$o*IlVjfrJNEhM(>tw&wEQkz$h$g?`Kr;{^NWwz@Be?_yzkL zBMZ*vjOI-%PkDY@P!aue*Zzaq4`m;3TYuF0MM=3D}%&};V&Ru zcYbM}Jd5?~Z?n_>ZnR$cYS&()@00TO-|oL;;k(=3DOmM{C=3DiVM zRp+eIuf%xF7tgP@mEZA=3D`Q1@Zn;v%0TmFwNc1#i6|FFnSBBxq3=3DX&U$oWoNsY > z#_wqSvIkrf>qL%wO1MZ*@eTFc#D4Vlsq24hKSos?-|;s4BcIjWg#4*n%M0S}#LK*6 > zd8sv(ZLaGJmh*?A=3DiX*Ncy8C zc_w=3DNw?7?zT(xV}=3D5vy!;+LKuy&ZR+ecj)N>Ovv@$BvV}UAExUOFfdmV~!x(?Ksxk > zrK0w?3sn8izx&T{;OocR$I{=3DVee?YBJpSODC#ye%Zd);Fuhnh6m|Lc2+~eEk&)ZsW > z`{Zcdjp)!o > zZ z_J6@^rIx?#B>5)i{M*p+O6$Mgs?&?vT|@kyyUw*gv+V89HS3;*#`TJ;_n%t4sB_li > zn`>4*zqn%6;>fF0)Gw}(5fA*lW2X4z6`E=3D{OX8lL&523z6?}TNWZu)yFIMDy$|$R` > z(3{=3Dvx;N*}nXWxDQ!CB%S7%-cIbIr9vUpqjBd4QfC${Yl+-Wg)+hh&($iEg zu2=3Dlj^TiF$Y|9O9; > z{>Z9lzF+YF?B9bQs^+9VK7Z(e&Ca*$l^EU!?x^|p?Y})kjQVNo`YdodlHa_%`u03V > Tj6@S-|DS2eE8$QE1||jom5H3- > > literal 0 > HcmV?d00001 > > diff --git a/tests/iso9660_ce_loop2.iso.gz b/tests/iso9660_ce_loop2.iso.= gz > new file mode 100644 > index 0000000000000000000000000000000000000000..f59e676475cfc8376256ba65= 047451b5ca969e5a > GIT binary patch > literal 904 > zcmb2|=3D3rP?urHZ``Rxt=3D{M#uq3<`+#@LT?l > zg?-)QBTE*}RZ}c{9Q>yELuJ{_9m)%n)Op{A ziNtYF2^VRR(nz1p>_2y(y8f5<9>;sh?Uh^KFSyM4EiAJ7cly!4-wLcf!dIHS*s@UA > zhCja~?;X4K>u z=3DBjg6=3D`r)Y=3DZof7+sf~F#{BN6r%eyL=3DPm!o7CR;g?thx(CXrJunsYt%PtM_`7M6= Se > zGvjwOe%S++4__GcO*ZH-(|EOMMjHR8@~P{8|9;f_VP4_v@ZWq^a})BXZrxrVb|;^I > zdvnQDuVz1KtAn3ExIKSXw_$VM{>*FgyB}{_HA}l#|K+#ce>Hk9Z<)R1ZpnpS_PvRh > z_DlPAH81<~V8yJpuhtYF`?~W> zuq^i2d9#?V$(MiIGZd8m+4NCz_q=3D+cfB)PK?Dq-pJ9kU#=3DIhIE54FY~PWqGj<7MV=3D > z^TQhZMZbkjt$KZ{e(mA!v!4n4+kLQ}``!9gckV|Xox5#8@#`(KKin$(K09USf$93U > z_K53WPu_DY_wc*brGL_UmVGp;5uLLv?egoy4{v@Hs^?t4q*uOo+09Lx3(C@`?%Vuv > z62pOdz4dYJ)!p%jS7|-FuX;FflCIpdz|g*Zy{jI5aFi3>>>AfAm$vy?P2AM(q7c7Z > zliiOd#<_pJSQ8i4oe>juanG9W#~Cp`pH|ex=3Dzq!#d44%(n}*xhnn~%Ua=3DoW+DoN`u > zI=3Do2E_4DFp&p`V#t5Y9W&Fk+fG(08dYT5nj(+a7lcUQbrv=3D84Xx#?wI%$DVw(}a$i > ztd?`{KXvk=3DN&l>uJ+oYOPKCC=3D-q;m6d6wSpw`r5l&z}A9-B$T}u63rnyC&xpUCJp~ > z_x|69FDEC@Z?=3DD|^7ifb{rl`C;(9mde2SEqqq_ZXD9eL-5xx0)|NiG^2tWDh-27Xh > c^m5?%o16ExrDG > literal 0 > HcmV?d00001 > > diff --git a/tests/iso9660_test.in b/tests/iso9660_test.in > index ed0a5bf8d4..44bc08c6df 100644 > --- a/tests/iso9660_test.in > +++ b/tests/iso9660_test.in > @@ -12,4 +12,19 @@ fi > "@builddir@/grub-fs-tester" rockridge_joliet > "@builddir@/grub-fs-tester" joliet_1999 > "@builddir@/grub-fs-tester" rockridge_1999 > -"@builddir@/grub-fs-tester" rockridge_joliet_1999 > \ No newline at end of file > +"@builddir@/grub-fs-tester" rockridge_joliet_1999 > + > +echo "Testing for proper recognition of CE loops ... " > +for fs in iso9660_ce_loop iso9660_ce_loop2; do > + tempdir=3D`mktemp -d "${TMPDIR:-/tmp}/${0##*/}.$(date '+%Y%m%d%H%M%S%= N').${fs}.XXX"` || > + { echo "Failed to make temporary directory"; exit 99; } > + gunzip <"$srcdir"/tests/${fs}.iso.gz >"${tempdir}/${fs}.iso" || exit = 99 > + output=3D$(LC_ALL=3DC timeout -s KILL "60" \ > + "@builddir@/grub-fstest" "${tempdir}/${fs}.iso" ls / ) || ret=3D$? > + rm -rf "$tempdir" > + if [ "${ret:-0}" -ne 0 -o -n "$output" ]; then > + echo "FAIL ($fs)" > + exit 1 > + fi > +done > +echo "PASS" Tested-by: Thomas Schmitt The test passes with unchanged grub-core/fs/iso9660.c. It fails with disabled loop breaker and with disabled processing of CE at the start of a continuation area. The message in test-suite.log is then: Testing for proper recognition of CE loops ... FAIL (iso9660_ce_loop) FAIL iso9660_test (exit status: 1) Have a nice day :) Thomas